Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor adbdgl-adapter to mirror adbpyg-adapter #29

Closed
aMahanna opened this issue Jul 29, 2022 · 0 comments · Fixed by #30
Closed

Refactor adbdgl-adapter to mirror adbpyg-adapter #29

aMahanna opened this issue Jul 29, 2022 · 0 comments · Fixed by #30
Assignees
Labels
enhancement New feature or request

Comments

@aMahanna
Copy link
Member

aMahanna commented Jul 29, 2022

The current adbdgl-adapter's implementation is out of date when compared to the new functionality that is offered within the adbpyg-adapter.

Given that both DGL and PyG are Graph Neural Network libraries (with strong similarities), it would be best to refactor how ArangoDB to DGL & DGL to ArangoDB is handled such that it mimics https://github.com/arangoml/pyg-adapter.

This will warrant a 3.0.0 release

@aMahanna aMahanna self-assigned this Jul 29, 2022
@aMahanna aMahanna added the enhancement New feature or request label Jul 29, 2022
aMahanna added a commit that referenced this issue Aug 5, 2022
todo: update jupyter notebook to reflect new functionality
aMahanna added a commit that referenced this issue Oct 26, 2023
* initial commit (WIP)

* checkpoint

* Update adapter.py

* checkpoint 2

* cleanup

* checkpoint

* checkpoint

* cleanup: `valid_meta`

* mvp: #29

todo: update jupyter notebook to reflect new functionality

* fix: black

* fix: flake8

* Update setup.py

* temp: try for 3.10

* new: 3.10 support

* cleanup: progress bars

* update: documentation

* Update README.md

* new: adbdgl 3.0.0 notebook

* new: address comments

* revive PR

improvements based on pyg-adapter, general code cleanup

* swap python 3.7 support for 3.11

3.7 has reached eol

* fix: PyG typos

* cleanup: udf behaviour (dgl to arangodb)

* fix: rich progress style

* lock python-arango version

* new: notebook output file

* code cleanup

* fix: explicit_metagraph

that took a while to find...

* cleanup function order

* more cleanup

* address comments

* fix: PyG typos

* Update README.md

* fix: typo

* DGL Refactor Updates (#31)

* initial commit

* bump

* cleanup workflows

* Update build.yml

* Update build.yml

* parameter renaming, new `use_async` param

* update release action

* Update README.md

* Update README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant