Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: change underscore to dash #1

Closed
Mariusthvdb opened this issue Jul 12, 2021 · 3 comments
Closed

FR: change underscore to dash #1

Mariusthvdb opened this issue Jul 12, 2021 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@Mariusthvdb
Copy link

Mariusthvdb commented Jul 12, 2021

HI, first of all, great work! nice to see the hue icons easily available in HA.

please let ,me suggest to change the icon names to use a dash between words instead of the underscore? This makes it more in lign with HA icon naming in general:

hue:wall-flood

versus

hue:wall_flood

just that bit nicer to the eye

@arallsopp
Copy link
Owner

That’s a fair observation. Thanks for the pointer. I’ll extend the script to be backwards compatible for all the current entries, and look to implement this in the next release.

@Mariusthvdb
Copy link
Author

Mariusthvdb commented Jul 13, 2021

cool, thanks!, another FR to go with that, please add some versioning in the card, so we can see it being loaded correctly in inspector

// Add card info to console
console.info(
  `%c HASS-HUE-ICONS  \n%c  Version 1.0.7    `,
  "color: orange; font-weight: bold; background: black",
  "color: white; font-weight: bold; background: dimgray",
 );

Schermafbeelding 2021-07-13 om 09 51 17

@arallsopp
Copy link
Owner

arallsopp commented Jul 13, 2021

Thanks @Mariusthvdb for the versioning tip. That’s in, as is the underscore to dash suggestion.

Makes it so much easier to spot which release I’m running when on my desktop.

This FR now satisfied, I believe.

@arallsopp arallsopp added the enhancement New feature or request label Jul 14, 2021
@arallsopp arallsopp self-assigned this Jul 14, 2021
@alvinchen1 alvinchen1 mentioned this issue Jul 17, 2021
arallsopp referenced this issue in Mariusthvdb/custom-icons May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants