Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hue Beyond #10

Closed
alvinchen1 opened this issue Jul 17, 2021 · 15 comments
Closed

Hue Beyond #10

alvinchen1 opened this issue Jul 17, 2021 · 15 comments
Assignees
Labels
icon request new custom icon

Comments

@alvinchen1
Copy link

What is the specific model of hue fixture/bulb that you want an icon for

Hello, great work, could we get an icon for the Hue Beyond?

Provide a URL that points to an image of this fixture/bulb

https://www.philips-hue.com/en-in/p/hue-white-and-color-ambiance-beyond-table-lamp/7120231I7

Additional context

@alvinchen1 alvinchen1 added the icon request new custom icon label Jul 17, 2021
@arallsopp
Copy link
Owner

Family day today, but will be on it later! :)

cheers.

@alvinchen1
Copy link
Author

Thanks! Cheers!

@arallsopp
Copy link
Owner

Hey @alvinchen1. I'm not really familiar with how this light looks when its on...

Can you tell me whether A, B or C will work best for how it behaves?

image

@alvinchen1
Copy link
Author

alvinchen1 commented Jul 17, 2021

It actually has two lights in it, one up and one down, so it has four total states, both off, both on, up on, and down on. For the purposes of this, I think it probably makes the most sense to offer A.

None of your other icons show different states, (ON/OFF), so why should this one be any different? Even though it has two lights in it and four total states. If you do consider offering different icons for on or off in the future (not suggesting that you do), then it would be hue:beyond = A (both are on), hue:beyond-up = B (up is on), and hue:beyond-down = C (down is on)., and maybe have one that is hue:beyond-off where everything is solid (both off).

Hope that makes sense.

EDIT: changed 1, 2, 3 to be A, B, C.

@arallsopp
Copy link
Owner

Got you. Perfectly explained. It gets complicated because the bit that lights up on the icon is the bit shaded black. So if I do go for states, they're the reverse of what we'd expect :)

I think I'll go with option 1, but will add the others as -alt variants.

@alvinchen1
Copy link
Author

Yup, sounds great. I personally would probably use the -alt variants to indicate which one is on/off...Thanks again.

@arallsopp
Copy link
Owner

arallsopp commented Jul 17, 2021

@alvinchen1: There you go. v.1.0.28 has it.

Icon Name Icon Name
hue:beyond-down hue:beyond-down hue:beyond-solid hue:beyond-solid
hue:beyond-up hue:beyond-up hue:beyond hue:beyond

I'd be interested to see your config for on/off if you get the chance to share it?

@arallsopp
Copy link
Owner

arallsopp commented Jul 18, 2021

Having thought on this, I think I named up and down the wrong way around vs your request. Again, tricky, as the solid bit will be the bit that lights up when it's used with state color.

(Eg: this is beyond-up, with the solid section at the top)

8035CA33-141E-4009-9B21-B765A77F537B

I'm wondering if it'd be better to rename them:

Icon Name Icon Name
hue:beyond hue:beyond hue:beyond-solid hue:beyond-solid
hue:beyond-up hue:beyond-solid-top hue:beyond-solid-bottom hue:beyond-solid-bottom

Breaking change, if we do, but probably minimal disruption if only a few people are using them currently.

@alvinchen1
Copy link
Author

Makes sense to me. I am one of those using the old icon names, but happy to change to what you feel is best.

@arallsopp
Copy link
Owner

Hey @alvinchen1.

Just to let you know, I'm going to be stopping development effort on this for a while, as my work is being stolen by another repo without permission, in breach of the CC license, and without any attempt to give credit to the original author or those who've helped me.

This project has always been offered as free to use, and for the benefit of the home assistant community rather than any individual. More than half of this library is the 80 or so original icons I've created, drawn and gifted to the home assistant community. Those icons are all original works, driven by requests from people like you, taken on as a willing task, and shared here on a non commercial basis for all who want them.

It felt good to give back, and the work was a reward in itself, but finding the icons I'm creating being offered elsewhere, proffered up alongside a request for paypal donations to support their creation is really not in the spirit of the community.

The whole experience has left a bad taste in my mouth, and I'll be stepping away for some time.

Cheers, and thanks for your interest.

Andy.

@alvinchen1
Copy link
Author

Hey man, that's sucks. Really appreciate all your help and work on this. And that totally sucks that they sourced it from you and monetized it. Especially curbing on your work. If you wanted to pull this private, I would totally understand doing so.

@arallsopp
Copy link
Owner

Thanks @alvinchen1. I don't want to do anything that could be punitive for the community, and making the icons harder to discover or find would only really hurt those I'd hoped to help. It also risks leaving the illegitimate repo as the only public source for the works I've created, which isn't a great legacy for things.

When you share something online, there's always a risk that someone will try to steal what's offered for free. I don't want the acts of a few solitary morons to ruin it for everyone else, but they do suck the joy out of it.

I'll be back, but with a little less faith in people.

@alvinchen1
Copy link
Author

Yup, I totally agree. You are in an unenviable situation with that and I completely understand. Again, thank you for what you did and taking the highroad on this situation.

@alvinchen1
Copy link
Author

alvinchen1 commented Nov 3, 2021

Hey @arallsopp, awesome call out from the lead developer for HA today. Saw your mention on the 2021.11 post. Cause you do good work!

@arallsopp
Copy link
Owner

Hey @alvinchen1. Thanks for the nudge. Wow. I feel quite proud! Goodness!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
icon request new custom icon
Projects
None yet
Development

No branches or pull requests

2 participants