Skip to content

Commit

Permalink
add ikea-death-star
Browse files Browse the repository at this point in the history 
to table
thank you @arallsopp
  • Loading branch information
@Mariusthvdb
Mariusthvdb authored May 12, 2022
1 parent fa06345 commit 5c04c30
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,6 @@ custom-icons includes legacy Mdi icons, and several special purpose icons made o
| ![custom:laptop-mac](https://raw.githubusercontent.com/mariusthvdb/custom-icons/main/docs/svgs/laptop-mac.svg)| custom:laptop-mac | Mdi legacy | ![custom:light-switch](https://raw.githubusercontent.com/mariusthvdb/custom-icons/main/docs/svgs/light-switch.svg)| custom:light-switch | Mdi legacy |
| ![custom:shutter-0](https://raw.githubusercontent.com/mariusthvdb/custom-icons/main/docs/svgs/shutter-0.svg)| custom:shutter-0 | @g-kiss | ![custom:shutter-1](https://raw.githubusercontent.com/mariusthvdb/custom-icons/main/docs/svgs/shutter-1.svg)| custom:shutter-1 | @g-kiss |
| ![custom:shutter-2](https://raw.githubusercontent.com/mariusthvdb/custom-icons/main/docs/svgs/shutter-2.svg)| custom:shutter-2 | @g-kiss | ![custom:shutter-3](https://raw.githubusercontent.com/mariusthvdb/custom-icons/main/docs/svgs/shutter-3.svg)| custom:shutter-3 | @g-kiss |
| ![custom:shutter-4](https://raw.githubusercontent.com/mariusthvdb/custom-icons/main/docs/svgs/shutter-4.svg)| custom:shutter-4 | @g-kiss |
| ![custom:shutter-4](https://raw.githubusercontent.com/mariusthvdb/custom-icons/main/docs/svgs/shutter-4.svg)| custom:shutter-4 | @g-kiss | ![custom:ikea-death-star](https://raw.githubusercontent.com/mariusthvdb/custom-icons/main/docs/svgs/ikea-death-star.svg)| custom:ikea-death-star | @arallsopp |
[//]: # (End Custom Icons)

7 comments on commit 5c04c30

@arallsopp
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

Hey. Just seeing this, I'm wondering if 'custom' is the best prefix. Could be a collision risk if there are other libraries. Perhaps use MCI (Mariusthvdb's Custom Icons)

@arallsopp
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, the @ names in the author column don't seem to work when I view your readme. You can go longform by using [text to show](link)

Icon Name Author
custom:shutter-3 custom:shutter-3 g-kiss
custom:ikea-death-star custom:ikea-death-star arallsopp

@Mariusthvdb
Copy link
Owner Author

@Mariusthvdb Mariusthvdb commented on 5c04c30 May 12, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ill change the links in the author field, maybe to the repo? or would the person handle be best

for the prefix, I dont really like to have my name in there, maybe cil, for custom icon library? dont think I saw that anywhere.

@arallsopp
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe cil, for custom icon library?

Nice. Yeah, that works!

@Mariusthvdb
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, ill try to do that this evening, before it gets too Breaking ;-)

@arallsopp
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I had one of those changes. We went from underscores to dashes back in issue 1. Can't remember who raised that ;)

@Mariusthvdb
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uhh..

Please sign in to comment.