Updates for aragonUI and other clean up #939
Conversation
| key={index} | ||
| href={`#${getAppPath({ | ||
| dao, | ||
| instanceId: 'permissions', | ||
| params: `app.${value.proxyAddress}`, | ||
| })}`} | ||
| target="_blank" | ||
| focusRingSpacing={[2, 2]} |
There was a problem hiding this comment.
Is this needed? I was more seeing it as an internal prop that Link uses, but if we need to use it, maybe we should make it part of Link prop types and document it.
There was a problem hiding this comment.
Admittedly this is a bit of a quickfix, but this was the reason:
Without the focusRingSpacing (using defaults):
With the override:
There was a problem hiding this comment.
mmm yes maybe we should fix the default then. I agree the first one could be improved, but the second one is too close to the characters IMO.
It might be a good case for em, so that it would depend on the text size… but the problem is that I don’t think there is a way to stop depending on the text size after a certain point (we don’t want huge spacing on large titles). But we could do some tests at different text sizes, maybe using a combination of px and em using calc(), and see if it works.
| horizontalPadding="none" | ||
| css="padding: 0" | ||
| > | ||
| <Link href={url} focusRingSpacing={[2, 2]}> |
There was a problem hiding this comment.
Same here for focusRingSpacing.
|
Ready! added the Figma document on the Product list. |
…tions * origin/newstyle: Optimize icons (#943) PropTypes: move fetch-required fields of AppType to be non-requi… (#946) Update ENS API changes from @aragon/wrapper (#944) Permissions: fix debounced search state on clearing filters (#942) Updates for aragonUI and other clean up (#939) AppCenter: update copy (#940)
Behaviour changes:
Chores:
fontandthemetotextStylesanduseTheme.@owisixseven We may want to design a nicer looking screen for when the user uses a wrong URL: