0.8 polish

[luisivan]

Master list of items to fix/polish for 0.8.

Completed

Client

• Once HelpScout has been enabled, trying to disable it in Preferences does nothing (just seems to remove the beacon CSS) (PR)
• HelpScout new designs (PR - includes changes in color, pending specs)
• Organization Switcher's dropdown appears on top of the org name
• Update DropDown api
• Update with new Field
• Native SidePanel overlay (only over app view?)
• Update with new Link
• Update AutoComplete, LocalIdentitiesAutoComplete
• Remove color, font, and theme imports from aragonUI
• Update large images (@owisixseven) Folder with the optimized img
• Redesign 404 screen (@owisixseven) - Designs here
• Update with AddressBadge's labelStyle, label
• Final design reviews (Sprint 29)
  • Activity panel
  • App center
  • DropDown headers and placeholders (ref Figma file)
• Safari:
  • Organization view is only rendered for ~50px from the top
  • Not loading app frontends
• Update screenshots for Voting, Finance, Tokens
• Test signer panel with Frame (see 0.8 polish #133 (comment))

Onboarding

• Notion list
• Disable balance check for contract accounts
• Move global preferences up so network settings can be modified (see designs)

Upgrade Modal

• Implement flow PR
• Always open showcase on first load (check date is before Oct. 1 + localstorage to avoid opening later)
• Add smaller images for showcase (@owisixseven) here the Figma files
• Fix internal padding in block text
• Update copy for 0.6 organizations ref
• Add button to show in Organization detail ref
• Fix wrong assets (see 0.8 polish #133 (comment))

Global Preferences

• Preferences tabbar has a double border, see fixed (there's two nested Bars, and removing border-radius from one of them fixes this)
• Global Preferences Help Scout: Fix z-indexes on components to show Global Preferences overlay on top of Help Scout button
• Add more padding to main Boxes ( => 24px) (to be fixed in aragonUI)
• Review Global Preferences Mobile (@dizzypaty sprint 27)
• Update large icons to optimized versions
• App badges in notifications' subscriptions
• Display app custom labels in notifications' filters
• Notifications polish

Permissions

• Decide on Tag usage for AppCard (ref)
• Replace ButtonText with Link
• ref
• Use AppBadges
• Add way to create previously unassigned permissions (and show all available permissions in app detail)
• Add 'view permission' back for burned permissions
• Add 'remove permission' to context menu for non-child entries
• Decide on context menu icons
• scrollIntoView() causes weird layout changes

App Center

• Check copy (ref)

Finance

• Empty state for 1st time when there is nothing in the Vault (designs) (ref)
  • Empty Transactions
  • Empty Token balances (designs pending)
• Disabled state buttons (ref)
• Info warning designs (ref - fix)
• Update DropDown api
• Update with new Field
• Update with new Link
• Update with new ButtonText
• Update to use useLayout() instead of useViewport()
• Replace ButtonText with Link
• Update with AddressBadge's labelStyle
• Double check copy (ref 1, ref 2, ref 3)

Tokens

• Update with new Field
• Update with new Link
• Update with new ButtonText
• Replace ButtonText with Link

Voting

• CardLayout fix on 1 and 2 items views (items span all available space) (fix on aragonUI)
• Update Badge component to Tag (needs Tag component from aragonUI - PR)
• Update Button in Header with new Button interface
• Update DropDown api
• Hide VoteActions until we have all the information necessary (to avoid flickers)
• Update with new Field
• Update with new Link
• Update with new ButtonText
• Replace ButtonText with Link
• App Badge data from aragon.js + filtering (@sohkai)
• Current balance of Token to display with balance at start of vote (@sohkai)
• Add enacted state to status box in vote detail

Agent

• Background script to remove mocked data (@sohkai, Sprint 27)
• Implement UI
• Test with real Agent (@sohkai Sprint 28)

aragonUI

• Support wide in DropDown (ref)
• Empty state text styles (ref)
• Decide on a text style for buttons (ref)
• Modal new styles (mainly overlay is now white, but double check spacing)
• Declare <Inside name="SidePanel"> in SidePanel, display the TabBar without the Bar if it’s inside of SidePanel
• Update Layout to provide mechanism to use all the vertical space and take care of overflow/scrolling (double check with scrolling issues) (@bpierre, Sprint 27)
• Update Field and TextInput for new styles
• Update Timer for new styles (text style + spacing)
• Update icons (spacing + stroke width, @owisixseven)
• Consistent padding + margin behaviour for Box, DataView, Tab, etc.
• AppBadge (@sohkai Sprint 29)
• Refresh disabled state for Button and DropDown ([designs]
• New toast styles (@AquiGorka Sprint 29)(https://www.figma.com/file/bZ1j7omfhdMCbtFahP3nEJ9B/Client?node-id=665%3A1))
• Empty DataView (handle when there are no entries or when filters result in no entries) (ref, ref)

[john-light]

I have tried:

• Issuing a token
• Creating a new question vote
• Making a withdrawal from Finance
• Modifying a permission

And each time I am given this error:

Your transaction wasn't signed and no tokens were sent. Error: “Transaction parameter 'name' is not a valid hex string”

And yet as far as I can tell, the transaction did go through:

[john-light]

I clicked the link:

• https://rinkeby.aragon.org/#/testorg3.aragonid.eth/?preferences=/notifications/verify/eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJ0b2tlbklkIjoyOSwic2NvcGUiOiJNQUdJQ0xJTksiLCJpYXQiOjE1Njc3MjMyODgsImV4cCI6MTU2Nzc2NjQ4OH0.OWiJ4UYjOv8_im1T-5a6cgHo2Cq2su2Qq2T3XSIUB2s

to verify my email, but the org at:

• https://nightly-rinkeby.aragon.org/#/testorg3/0x17e34cff97bbb1eaa2e31af75ffcf2f4098ebca7?preferences=/notifications

still says “awaiting verification”.

[john-light]

Email notifications button says “Sign in”. Which is weird because I’ve never signed up before… maybe given the way that this works this button should say "activate" or something like that?

[john-light]

Suggested revision to email notifications panel description:

Receive email notifications for new app events. For example, whenever a new vote is created or when tokens are issued, you’ll get an email informing you of this activity in your organization.

You will be asked to enter your email address whenever using a different browser session or device to access your notification subscriptions. This process doesn’t require a password, just for you to confirm your email address whenever you want to activate email notifications.

The email address you enter here is only used to send you notifications that you have explicitly opted into and will not be shared, rented, or sold for any marketing purposes.

[john-light]

Suggested revision to the copy in the email notification activation email:

You requested that we send you a link to verify your email and opt-in to email notifications. Use the button or link below to verify your email address. This link is only valid for the next 12 hours.

[john-light]

Some text box coloring looks a bit “off” in dark mode (e.g. the first yellow box shown below)

[john-light]

Can we expect dark mode to work on the apps as well? They currently look light compared to the wrapper:

[john-light]

"What do you want to do?" text is awkwardly white against a white eagle background in dark mode. Suggestion: Make the eagle a darker blue? (But lighter than the buttons and background)

[john-light]

When I open a vote, the URL does not change. I thought 0.8 would introduce the ability to link directly to a vote?

[john-light]

Suggested revision to copy in the Voting app:

Your vote was cast successfully

[john-light]

The voting app notes:

While the voting period is open, you can change your vote as many times as you wish.

I guess we have decided to continue allowing votes to be changed, rather than making the default that votes cannot be changed?

[john-light]

We can make the "Start date" for filters go back no earlier than the beginning of 2018 since there were no organizations on mainnet before then (and the client doesn't work with any rinkeby orgs created before then either)

[john-light]

"Remove token" permission does not appear in the "available permissions" for the Tokens app in the Permissions app

[john-light]

I created a vote to change the manager of the "Modify quorum" permission on the Voting app to 0xFFfFfFffFFfffFFfFFfFFFFFffFFFffffFfFFFfF and the resulting vote says ACL: Sets 'Any account' as the manager of the permission 'Modify quorum' in 'Voting'.

At the same time, the option to choose "Any account" as the manager has disappeared from the list of options:

[john-light]

The warning message:

Do not send ETH or ERC20 tokens to these addresses. If you’d like to deposit funds into this organization, you can do so from Finance.

could be added to the Installed Aragon apps section of the Organization system app.

[sohkai]

rinkeby.aragon.org/#/testorg3.aragonid.eth/?preferences=/notifications/verify/eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJ0b2tlbklkIjoyOSwic2NvcGUiOiJNQUdJQ0xJTksiLCJpYXQiOjE1Njc3MjMyODgsImV4cCI6MTU2Nzc2NjQ4OH0.OWiJ4UYjOv8_im1T-5a6cgHo2Cq2su2Qq2T3XSIUB2s

For this you'll need to use preview, I don't think the backend knows about nightly-rinkeby and redirects you to using rinkeby. This should be fixed soon. Now fixed.

Dark mode

Dark mode will be removed from the release; these are still development previews.

I thought 0.8 would introduce the ability to link directly to a vote?

This may be included for the release if we can get it in, otherwise it'll be released afterwards.

I guess we have decided to continue allowing votes to be changed, rather than making the default that votes cannot be changed?

This is a change that will require contract upgrades, and is scheduled for the next release (0.9).

We can make the "Start date" for filters go back no earlier than the beginning of 2018 since there were no organizations on mainnet before then (and the client doesn't work with any rinkeby orgs created before then either)

All the date pickers (in Finance and Voting) will be re-thought after the release.

"Remove token" permission does not appear in the "available permissions" for the Tokens app in the Permissions app

Part of the remaining pieces of Permissions; will be done before release.

I created a vote to change the manager of the "Modify quorum" permission on the Voting app to 0xFFfFfFffFFfffFFfFFfFFFFFffFFFffffFfFFFfF and the resulting vote says ACL: Sets 'Any account' as the manager of the permission 'Modify quorum' in 'Voting'.

Did you manually type in 0xFFfFfFffFFfffFFfFFfFFFFFffFFFffffFfFFFfF? This is actually a special value the ACL knows about (as it's a "safe" address) that represents "Any account".

We can add a warning to the panel about this if we detect it though? (See aragon/client#969)

[john-light]

@sohkai: Did you manually type in 0xFFfFfFffFFfffFFfFFfFFFFFffFFFffffFfFFFfF? This is actually a special value the ACL knows about (as it's a "safe" address) that represents "Any account".

I copy+pasted the address. The intention is to "discard" or "burn" the permission by assigning management to a burn account, not to give management to any account. Up until now I have been able to burn permissions by assigning them / their management to a burn address like this.

[john-light]

The App Badges no longer appear in the Permissions app:

[sohkai]

I copy+pasted the address. The intention is to "discard" or "burn" the permission by assigning management to a burn account, not to give management to any account. Up until now I have been able to burn permissions by assigning them / their management to a burn address like this.

Ahhh yes, actually the burn address is 0x0000....0001 (and that's the address that gets displayed as "Discarded").

[john-light]

@sohkai perhaps we can solve both issues (lack of an "any account" option in the dropdown, and confusion about what address to use to discard) by adding two options to the dropdown: one for "any account" and one for "discard", which will automatically fill in the correct addresses in the background?

Edit: Also, as you suggested earlier, if someone manually enters 0xf...f we can warn them this will translate automatically to "any account", and if someone manually enter 0x00...01 we can warn them this will translate automatically to "discard".

[sohkai]

@john-light These options are available through the panel already though:

[john-light]

@sohkai: These options are available through the panel already though:

"Remove the manager" doesn't have the same implication as "discard this permission" though does it? From the user guide:

If a manager removes themselves as a manager of a permission without re-assigning the manager role to another entity, then management of that action defaults to whichever entity manages the “Create permissions” action in the ACL app.

Whereas:

If the manager of an action is set as 0x0000000000000000000000000000000000000001 then no new manager can be set and permissions granted for that action will be locked forever.

So "remove the manager" and "discard this permission" really mean two different things, correct?

[sohkai]

@john-light Ehh yes, that second screenshot is wrong. We will have an explicit "discard" action for permissions that will open up the "discard" panel (similar to 0.7's) in the Permissions before launch.

You are correct that "remove" and "discard" are two different actions.