Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] some coma-separated words are considered as a time #145

Open
prochac opened this issue Nov 29, 2021 · 1 comment · May be fixed by #159
Open

[BUG] some coma-separated words are considered as a time #145

prochac opened this issue Nov 29, 2021 · 1 comment · May be fixed by #159

Comments

@prochac
Copy link

prochac commented Nov 29, 2021

, although they obviously don't.

I have prepared a test case replicating the problem and mocked the string we found it with. But I hope the committed one replicates the same issue.

prochac@942edac
@prochac
Copy link
Author

prochac commented Dec 1, 2021

Could it be related?
#108

klondikedragon added a commit to itlightning/dateparse that referenced this issue Dec 12, 2023
@klondikedragon
Add extensive format validation, bugfixes
1b1e0b3 
* Don't just assume we were given one of the valid formats.
* Also consolidate the parsing states that occur after timePeriod.
* Add subtests to make it easier to see what fails.
* Additional tests for 4-char timezone names.
* Fix araddon#117
* Fix araddon#150
* Fix araddon#157
* Fix araddon#145
* Fix araddon#108
* Fix araddon#137
* Fix araddon#130
* Fix araddon#123
* Fix araddon#109
* Fix araddon#98
* Addresses bug in araddon#100 (comment)

Adds test cases to verify the following are already fixed:
* araddon#94
@klondikedragon klondikedragon linked a pull request Dec 21, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@prochac