Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timezone 'Z' not parsed for time string with milliseconds after period #130

Open
zifengyu opened this issue Jul 24, 2021 · 0 comments · May be fixed by #159
Open

Timezone 'Z' not parsed for time string with milliseconds after period #130

zifengyu opened this issue Jul 24, 2021 · 0 comments · May be fixed by #159

Comments

@zifengyu
Copy link

'Z' is not parsed after timePeriod '.'. In below sample, the timezone is not detected and ParseIn will have incorrect result.

func main() {
	loc, _ := time.LoadLocation("Asia/Shanghai")
	inputs := []string{
		"1985-04-12T23:20:50Z",
		"1985-04-12T23:20:50.52Z"}
	for _, in := range inputs {
		t, _ := dateparse.ParseIn(in, loc)
		fmt.Println(t)
	}
}

https://goplay.space/#Kj1UBJ-bHsW

klondikedragon added a commit to itlightning/dateparse that referenced this issue Dec 12, 2023
* Don't just assume we were given one of the valid formats.
* Also consolidate the parsing states that occur after timePeriod.
* Add subtests to make it easier to see what fails.
* Additional tests for 4-char timezone names.
* Fix araddon#117
* Fix araddon#150
* Fix araddon#157
* Fix araddon#145
* Fix araddon#108
* Fix araddon#137
* Fix araddon#130
* Fix araddon#123
* Fix araddon#109
* Fix araddon#98
* Addresses bug in araddon#100 (comment)

Adds test cases to verify the following are already fixed:
* araddon#94
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant