fix(registry): signer-workflow string format#4663
Conversation
...of GitHub artifact attestations config. gh uses it as such, after prefixing with https://github.com/
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis pull request adds regex format validation to the signer workflow properties in both the JSON schema definition and Go struct tags for the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip CodeRabbit can generate a title for your PR based on the changes.Add |
|
We may want to modify the registry and start writing these as regexps in it, i.e. basically replacing plain |
|
The documentation and help messages do not state that the value of https://cli.github.com/manual/gh_attestation_verify However, based on the source code, it appears to be treated as one. I also confirmed that using a regular expression for signer_workflow: suzuki-shunsuke/go-release-workflow/.github/workflows/.*.yaml |
|
Probably this change causes errors. |
|
...of GitHub artifact attestations config.
gh uses it as such, after prefixing with https://github.com/
Check List
Require signed commits, so all commits must be signedSummary by CodeRabbit