Skip to content

feat(validate-json-schema): support more formats in ajv#977

Merged
suzuki-shunsuke merged 1 commit into
aquaproj:mainfrom
scop:fix/ajv-formats
Mar 25, 2026
Merged

feat(validate-json-schema): support more formats in ajv#977
suzuki-shunsuke merged 1 commit into
aquaproj:mainfrom
scop:fix/ajv-formats

Conversation

@scop

@scop scop commented Mar 24, 2026

Copy link
Copy Markdown
Contributor

Makes for example format: regex for strings work.

Refs ajv-validator/ajv-cli#188 (comment)

@github-actions

This comment was marked as resolved.

@suzuki-shunsuke

Copy link
Copy Markdown
Member

Thank you!

@suzuki-shunsuke suzuki-shunsuke merged commit c474593 into aquaproj:main Mar 25, 2026
6 checks passed
@github-project-automation github-project-automation Bot moved this to Done in main Mar 25, 2026
@suzuki-shunsuke

suzuki-shunsuke commented Mar 25, 2026

Copy link
Copy Markdown
Member

🤔

$ ajv --spec=draft2020 -c ajv-formats -s ../aqua/json-schema/registry.json -d pkgs/suzuki-shunsuke/ci-info/registry.yaml
module ajv-formats is invalid; it should export function
error: Cannot find module 'ajv-formats'
Require stack:
- /Users/shunsukesuzuki/.local/share/npm-global/lib/node_modules/ajv-cli/dist/commands/ajv.js
- /Users/shunsukesuzuki/.local/share/npm-global/lib/node_modules/ajv-cli/dist/commands/compile.js
- /Users/shunsukesuzuki/.local/share/npm-global/lib/node_modules/ajv-cli/dist/commands/index.js
- /Users/shunsukesuzuki/.local/share/npm-global/lib/node_modules/ajv-cli/dist/index.js

https://github.com/ajv-validator/ajv-cli/blob/58d6f074720d5dc0773c3786320b7d35718060cd/src/commands/ajv.ts#L75

@scop scop deleted the fix/ajv-formats branch March 25, 2026 20:26
@scop

scop commented Mar 25, 2026

Copy link
Copy Markdown
Contributor Author

Hmph, I do remember trying and seeing ajv-cli pulling in ajv-formats too, but it doesn't, I don't know what happened. Anyway #978 should fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants