Add IBM-Cloud/ibm-cloud-cli-release#51717
Conversation
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 32 minutes and 37 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughAdds package and registry declarations for the IBM Cloud CLI: a new package manifest with multiple pinned versions and HTTP registry entries that template IBM CDN download URLs, map extraction of the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
pkgs/IBM-Cloud/ibm-cloud-cli-release/registry.yaml (1)
7-7: Drop explicit defaultlink
linkis derivable fromrepo_owner/repo_name, so this can be omitted for consistency with registry style.As per coding guidelines, "Omit settings equivalent to default values (name, link, files entries when derivable from repo_owner and repo_name)"
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@pkgs/IBM-Cloud/ibm-cloud-cli-release/registry.yaml` at line 7, Remove the explicit "link" field from the registry.yaml entry (the "link: https://github.com/IBM-Cloud/ibm-cloud-cli-release" line) because the link is derivable from repo_owner/repo_name; update the registry entry by deleting that "link" key so the registry follows the style rule to omit default/derivable settings.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@pkgs/IBM-Cloud/ibm-cloud-cli-release/registry.yaml`:
- Around line 38-40: Update the Windows `files[].src` entries that currently use
"IBM_Cloud_CLI/ibmcloud.exe" to remove the ".exe" suffix so they read
"IBM_Cloud_CLI/ibmcloud"; locate the two occurrences in the registry.yaml
Windows overrides (the `files:` list entries with `name: ibmcloud` and `src:
IBM_Cloud_CLI/ibmcloud.exe`) and change the `src` values accordingly, ensuring
other platforms/entries remain unchanged.
---
Nitpick comments:
In `@pkgs/IBM-Cloud/ibm-cloud-cli-release/registry.yaml`:
- Line 7: Remove the explicit "link" field from the registry.yaml entry (the
"link: https://github.com/IBM-Cloud/ibm-cloud-cli-release" line) because the
link is derivable from repo_owner/repo_name; update the registry entry by
deleting that "link" key so the registry follows the style rule to omit
default/derivable settings.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 376980f5-5edf-4219-a212-7f23e8c15820
📒 Files selected for processing (3)
pkgs/IBM-Cloud/ibm-cloud-cli-release/pkg.yamlpkgs/IBM-Cloud/ibm-cloud-cli-release/registry.yamlregistry.yaml
There was a problem hiding this comment.
🧹 Nitpick comments (2)
registry.yaml (2)
3764-3775: Avoid overlappingversion_overridesranges.
>= 2.0.0, < 2.38.0overlaps with< 2.5.0. Narrowing the first range to>= 2.5.0, < 2.38.0makes intent and precedence clearer.♻️ Proposed cleanup
- - version_constraint: semver(">= 2.0.0, < 2.38.0") + - version_constraint: semver(">= 2.5.0, < 2.38.0") url: https://download.clis.cloud.ibm.com/ibm-cloud-cli/{{trimV .Version}}/binaries/IBM_Cloud_CLI_{{trimV .Version}}_{{.OS}}_{{.Arch}}.tgz🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@registry.yaml` around lines 3764 - 3775, Update the overlapping version constraints so precedence is unambiguous: change the entry with version_constraint ">= 2.0.0, < 2.38.0" (the block that includes the URL with IBM_Cloud_CLI_{{trimV .Version}}) to ">= 2.5.0, < 2.38.0" so it no longer overlaps the separate rule with version_constraint "< 2.5.0" (the error_message "Please use v2.5.0 or later").
3744-3747: Replace barelinuxwith specific verified architectures.The bare
linuxentry permits all architectures, but IBM Cloud CLI v2.42.0+ only publishes binaries foramd64,arm64,386,ppc64le, ands390x. Using barelinuxrisks 404 downloads for unsupported architectures likearmandriscv64. Replace with explicit entries:- linux/amd64 - linux/arm64 - linux/386 - linux/ppc64le - linux/s390x🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@registry.yaml` around lines 3744 - 3747, The supported_envs list currently contains a bare "linux" which permits all architectures; replace that single "linux" entry in the supported_envs array with explicit verified architectures used by IBM Cloud CLI v2.42.0+: linux/amd64, linux/arm64, linux/386, linux/ppc64le, and linux/s390x, keeping the existing darwin and windows/amd64 entries intact so downloads don't attempt unsupported archs.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@registry.yaml`:
- Around line 3764-3775: Update the overlapping version constraints so
precedence is unambiguous: change the entry with version_constraint ">= 2.0.0, <
2.38.0" (the block that includes the URL with IBM_Cloud_CLI_{{trimV .Version}})
to ">= 2.5.0, < 2.38.0" so it no longer overlaps the separate rule with
version_constraint "< 2.5.0" (the error_message "Please use v2.5.0 or later").
- Around line 3744-3747: The supported_envs list currently contains a bare
"linux" which permits all architectures; replace that single "linux" entry in
the supported_envs array with explicit verified architectures used by IBM Cloud
CLI v2.42.0+: linux/amd64, linux/arm64, linux/386, linux/ppc64le, and
linux/s390x, keeping the existing darwin and windows/amd64 entries intact so
downloads don't attempt unsupported archs.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: c5523c10-029f-4c04-beb1-41c5852a0cfc
📒 Files selected for processing (2)
pkgs/IBM-Cloud/ibm-cloud-cli-release/registry.yamlregistry.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
- pkgs/IBM-Cloud/ibm-cloud-cli-release/registry.yaml
dnwe
force-pushed
the
feat/IBM-Cloud/ibm-cloud-cli-release
branch
from
2408ab1 to
d1454fe
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@registry.yaml`:
- Around line 3763-3775: The broader semver block semver(">= 2.0.0, < 2.38.0")
currently covers versions <2.5.0 so the later error guard semver("< 2.5.0") is
never reached; fix by either narrowing the first constraint to semver(">= 2.5.0,
< 2.38.0") or moving the semver("< 2.5.0") block above the semver(">= 2.0.0, <
2.38.0") block so the unreachable error_message override executes for
unsupported versions.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: f4201ef5-f364-4281-a39a-04a7027a018d
📒 Files selected for processing (3)
pkgs/IBM-Cloud/ibm-cloud-cli-release/pkg.yamlpkgs/IBM-Cloud/ibm-cloud-cli-release/registry.yamlregistry.yaml
✅ Files skipped from review due to trivial changes (2)
- pkgs/IBM-Cloud/ibm-cloud-cli-release/registry.yaml
- pkgs/IBM-Cloud/ibm-cloud-cli-release/pkg.yaml
Signed-off-by: Dominic Evans <dominic.evans@uk.ibm.com>
dnwe
force-pushed
the
feat/IBM-Cloud/ibm-cloud-cli-release
branch
from
d1454fe to
2c36f52
Compare
|
@coderabbitai resume |
✅ Actions performedReviews resumed. |
suzuki-shunsuke
changed the title
|
Thank you! |
|
Thanks @suzuki-shunsuke ! |
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [aquaproj/aqua-registry](https://github.com/aquaproj/aqua-registry) | minor | `v4.492.0` → `v4.493.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>aquaproj/aqua-registry (aquaproj/aqua-registry)</summary> ### [`v4.493.0`](https://github.com/aquaproj/aqua-registry/releases/tag/v4.493.0) [Compare Source](aquaproj/aqua-registry@v4.492.0...v4.493.0) [Issues](https://github.com/aquaproj/aqua-registry/issues?q=is%3Aissue+milestone%3Av4.493.0) | [Merge Requests](https://github.com/aquaproj/aqua-registry/pulls?q=is%3Apr+milestone%3Av4.493.0) | <aquaproj/aqua-registry@v4.492.0...v4.493.0> #### 🎉 New Packages [#​51977](aquaproj/aqua-registry#51977) [trzsz/trzsz-go](https://github.com/trzsz/trzsz-go) - trzsz-go is the go version of trzsz, makes all terminals that support local shell to support trzsz ( trz / tsz ) [@​ZeroAurora](https://github.com/ZeroAurora) [#​51929](aquaproj/aqua-registry#51929) [micelio.dev/hif](https://micelio.dev/micelio/micelio/tree/hif) - The hif CLI - a forge-first version control system for the agent era [@​pepicrft](https://github.com/pepicrft) [#​51717](aquaproj/aqua-registry#51717) [IBM-Cloud/ibm-cloud-cli-release](https://github.com/IBM-Cloud/ibm-cloud-cli-release) - Command line interface for IBM Cloud [@​dnwe](https://github.com/dnwe) [#​51715](aquaproj/aqua-registry#51715) [pgplex/pgschema](https://github.com/pgplex/pgschema) - Terraform-style, declarative schema migration CLI for Postgres. Agent friendly [@​kaz](https://github.com/kaz) #### Fixes [#​51964](aquaproj/aqua-registry#51964) mvdan/sh: Support Windows [@​zeitlinger](https://github.com/zeitlinger) [#​51905](aquaproj/aqua-registry#51905) temporalio/temporal: refresh server bundle binaries [@​chaptersix](https://github.com/chaptersix) #### Security [#​51716](aquaproj/aqua-registry#51716) gleam-lang/gleam: GitHub artifact attestations config [@​scop](https://github.com/scop) </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4xMTMuMCIsInVwZGF0ZWRJblZlciI6IjQzLjExMy4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiLCJhdXRvbWF0aW9uOmJvdC1hdXRob3JlZCIsImRlcGVuZGVuY3ktdHlwZTo6bWlub3IiXX0=-->
2 participants
Add support for the ibmcloud tool, a command line interface for IBM Cloud
Note: binaries are hosted on IBM's CDN, not at GitHub Release assets, so this package is
type: httpand follows the same patterns as used in helm/helm and the various kubernetes packages.Check List
argd scommand when adding new packagesSummary by CodeRabbit