feat: enable windows support for latest Zellij#51341
Conversation
Changes from scaffold: - Removed checksum properties because they are checksum of executables yet. - Merge `version_overrides` properties that are same spec Refs: aquaproj#6780 (comment)
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughThe package entries for zellij were expanded to include multiple explicit versions, and the registry entries were converted from a single static asset definition to a version_constraint/version_overrides model that selects assets, formats, platform replacements, and per-version overrides (including Windows/rosetta2 handling). Changes
Estimated Code Review Effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
registry.yaml (1)
94335-94356: Redundant version override blocks can be merged.The
semver("<= 0.30.0")andsemver("<= 0.43.1")blocks have identical configurations (same asset pattern, format, replacements, and supported_envs). Since aqua processes overrides in order, removing the<= 0.30.0block would cause those versions to fall through to<= 0.43.1with the same result.♻️ Suggested simplification
- - version_constraint: semver("<= 0.30.0") - asset: zellij-{{.Arch}}-{{.OS}}.{{.Format}} - format: tar.gz - replacements: - amd64: x86_64 - arm64: aarch64 - darwin: apple-darwin - linux: unknown-linux-musl - supported_envs: - - linux - - darwin - version_constraint: semver("<= 0.43.1") asset: zellij-{{.Arch}}-{{.OS}}.{{.Format}} format: tar.gz🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@registry.yaml` around lines 94335 - 94356, The two override entries with version_constraint semver("<= 0.30.0") and semver("<= 0.43.1") are identical (same asset: zellij-{{.Arch}}-{{.OS}}.{{.Format}}, format: tar.gz, replacements and supported_envs) and can be merged by removing the redundant semver("<= 0.30.0") block; keep the broader semver("<= 0.43.1") entry so older versions still match the same override, ensuring the asset, format, replacements and supported_envs definitions from the remaining block (zellij-{{.Arch}}-{{.OS}}.{{.Format}} / tar.gz / replacements / supported_envs) are preserved in the file.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@registry.yaml`:
- Around line 94335-94356: The two override entries with version_constraint
semver("<= 0.30.0") and semver("<= 0.43.1") are identical (same asset:
zellij-{{.Arch}}-{{.OS}}.{{.Format}}, format: tar.gz, replacements and
supported_envs) and can be merged by removing the redundant semver("<= 0.30.0")
block; keep the broader semver("<= 0.43.1") entry so older versions still match
the same override, ensuring the asset, format, replacements and supported_envs
definitions from the remaining block (zellij-{{.Arch}}-{{.OS}}.{{.Format}} /
tar.gz / replacements / supported_envs) are preserved in the file.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 49f0661b-131f-4f09-b8fd-0eb4d0f628a7
📒 Files selected for processing (3)
pkgs/zellij-org/zellij/pkg.yamlpkgs/zellij-org/zellij/registry.yamlregistry.yaml
|
Thank you! |
It can install Zellij on Windows. Refs: aquaproj/aqua-registry#51341 Refs: https://github.com/aquaproj/aqua-registry/releases/tag/v4.491.0
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [aquaproj/aqua-registry](https://github.com/aquaproj/aqua-registry) | minor | `v4.487.0` → `v4.491.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>aquaproj/aqua-registry (aquaproj/aqua-registry)</summary> ### [`v4.491.0`](https://github.com/aquaproj/aqua-registry/releases/tag/v4.491.0) [Compare Source](aquaproj/aqua-registry@v4.490.0...v4.491.0) [Issues](https://github.com/aquaproj/aqua-registry/issues?q=is%3Aissue+milestone%3Av4.491.0) | [Merge Requests](https://github.com/aquaproj/aqua-registry/pulls?q=is%3Apr+milestone%3Av4.491.0) | <aquaproj/aqua-registry@v4.490.0...v4.491.0> #### 🎉 New Packages [#​51349](aquaproj/aqua-registry#51349) [azu/dockerfile-pin](https://github.com/azu/dockerfile-pin) - A CLI tool that adds `@sha256:<digest>` to FROM lines in Dockerfiles and image fields in docker-compose.yml to prevent supply chain attacks [@​azu](https://github.com/azu) #### Fixes [#​51341](aquaproj/aqua-registry#51341) Enable windows support for latest Zellij [@​attakei](https://github.com/attakei) [#​51352](aquaproj/aqua-registry#51352) goreleaser/goreleaser: Disable cosign verification at v2.15.0 and v2.15.1 [#​51351](aquaproj/aqua-registry#51351) anthropics/claude-code: Exclude v2.1.88 as it's unavailable [#​51350](aquaproj/aqua-registry#51350) Re-scaffold dandavison/delta ### [`v4.490.0`](https://github.com/aquaproj/aqua-registry/releases/tag/v4.490.0) [Compare Source](aquaproj/aqua-registry@v4.489.0...v4.490.0) [Issues](https://github.com/aquaproj/aqua-registry/issues?q=is%3Aissue+milestone%3Av4.490.0) | [Merge Requests](https://github.com/aquaproj/aqua-registry/pulls?q=is%3Apr+milestone%3Av4.490.0) | <aquaproj/aqua-registry@v4.489.0...v4.490.0> #### 🎉 New Packages [#​51332](aquaproj/aqua-registry#51332) [getdbt.com/dbt-fusion](https://docs.getdbt.com/docs/local/install-dbt) The next-generation engine for dbt [@​ryan-pip](https://github.com/ryan-pip) > \[!NOTE] > To update this package using Renovate, please update aqua-renovate-config to 2.12.0 or later. > <https://github.com/aquaproj/aqua-renovate-config/releases/tag/2.12.0> #### Fixes [#​51331](aquaproj/aqua-registry#51331) steveyegge/beads: Rename gastownhall/beads [#​51272](aquaproj/aqua-registry#51272) Azure/azure-dev: Re-scaffold [@​Petermarcu](https://github.com/Petermarcu) [#​51222](aquaproj/aqua-registry#51222) shinagawa-web/gomarklint: no assets for 2.1.0 [@​scop](https://github.com/scop) [#​51046](aquaproj/aqua-registry#51046) Re-scaffold magefile/mage [@​frozenbonito](https://github.com/frozenbonito) #### Security [#​51254](aquaproj/aqua-registry#51254) lxc/incus: GitHub artifact attestations config [@​scop](https://github.com/scop) ### [`v4.489.0`](https://github.com/aquaproj/aqua-registry/releases/tag/v4.489.0) [Compare Source](aquaproj/aqua-registry@v4.488.0...v4.489.0) [Issues](https://github.com/aquaproj/aqua-registry/issues?q=is%3Aissue+milestone%3Av4.489.0) | [Merge Requests](https://github.com/aquaproj/aqua-registry/pulls?q=is%3Apr+milestone%3Av4.489.0) | <aquaproj/aqua-registry@v4.488.0...v4.489.0> #### 🎉 New Packages [emacs-eask/cli](https://github.com/emacs-eask/cli) - CLI for building, running, testing, and managing your Emacs Lisp dependencies [@​djgoku](https://github.com/djgoku) #### Fixes [#​50956](aquaproj/aqua-registry#50956) dimo414/bkt: Split darwin arm64 support at 0.8.1 [@​mtibben](https://github.com/mtibben) [#​51180](aquaproj/aqua-registry#51180) zerocore-ai/microsandbox: Rename to superradcompany/microsandbox ### [`v4.488.0`](https://github.com/aquaproj/aqua-registry/releases/tag/v4.488.0) [Compare Source](aquaproj/aqua-registry@v4.487.0...v4.488.0) [Issues](https://github.com/aquaproj/aqua-registry/issues?q=is%3Aissue+milestone%3Av4.488.0) | [Merge Requests](https://github.com/aquaproj/aqua-registry/pulls?q=is%3Apr+milestone%3Av4.488.0) | <aquaproj/aqua-registry@v4.487.0...v4.488.0> #### 🎉 New Packages [#​50878](aquaproj/aqua-registry#50878) [RasKrebs/sonar](https://github.com/RasKrebs/sonar) - CLI tool for inspecting and managing services listening on localhost ports [@​TyceHerrman](https://github.com/TyceHerrman) #### Security [#​50868](aquaproj/aqua-registry#50868) terraprovider/statebridge: GitHub artifact attestations config [@​scop](https://github.com/scop) [#​51053](aquaproj/aqua-registry#51053) updatecli/updatecli: GitHub artifact attestations config [@​scop](https://github.com/scop) #### Fixes [#​50962](aquaproj/aqua-registry#50962) drager/wasm-pack: rename the package to wasm-bindgen/wasm-pack [#​50942](aquaproj/aqua-registry#50942) google/go-jsonnet: support v0.22.0 asset naming change [@​tak848](https://github.com/tak848) [#​50835](aquaproj/aqua-registry#50835) fix various typos [@​Marukome0743](https://github.com/Marukome0743) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4xMDIuMTAiLCJ1cGRhdGVkSW5WZXIiOiI0My4xMDIuMTAiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbIlJlbm92YXRlIEJvdCIsImF1dG9tYXRpb246Ym90LWF1dGhvcmVkIiwiZGVwZW5kZW5jeS10eXBlOjptaW5vciJdfQ==-->
Check List
argd scommand when adding new packagesDescription
Summary
This PR is for enable to install Zellij into Windows on latest version (>=0.44.0).
Why do I require this
Zellij v0.44.0 (latest update in this PR) has published Windows executables.
I want to use this on Windows too, current registry definition only supports macos and linux.
Therefore, I edit registry that it can install on Windows by these steps.
agrd sRefer to
Summary by CodeRabbit