fix(dimo414/bkt): split darwin arm64 support at 0.8.1#50956
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughSplit the Windows/zip registry entry: one entry now limited to semver("<= 0.8.0") (retains Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@pkgs/dimo414/bkt/registry.yaml`:
- Line 23: Add a pinned test version in pkg.yaml that falls inside the
0.5.5–0.8.0 range (e.g., "0.5.5") so the registry path governed by the
version_constraint semver("<= 0.8.0") and the middle block (linux-specific
overrides for 0.5.5–0.8.0) is exercised; specifically, update pkg.yaml’s pinned
versions list to include "0.5.5" alongside the existing "0.5.4" and "0.8.1"
entries to trigger the second resolution path defined in registry.yaml.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 28f9d7c4-a3eb-4b4c-9219-6461ed3f19a2
📒 Files selected for processing (2)
pkgs/dimo414/bkt/registry.yamlregistry.yaml
This comment was marked as duplicate.
This comment was marked as duplicate.
f0964e8 to
acc2eb9
Compare
This comment was marked as duplicate.
This comment was marked as duplicate.
❌ All commits must be signedAll commits of pull requests must be signed. Please see the document. |
❌ All commits must be signedAll commits of pull requests must be signed. Please see the document. |
4d7eec7 to
de60d49
Compare
❌ All commits must be signedAll commits of pull requests must be signed. Please see the document. |
de60d49 to
c43aea3
Compare
c43aea3 to
7657b97
Compare
|
Hey @suzuki-shunsuke, please let me know if any further changes are required |
|
Thank you! |
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [aquaproj/aqua-registry](https://github.com/aquaproj/aqua-registry) | minor | `v4.487.0` → `v4.491.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>aquaproj/aqua-registry (aquaproj/aqua-registry)</summary> ### [`v4.491.0`](https://github.com/aquaproj/aqua-registry/releases/tag/v4.491.0) [Compare Source](aquaproj/aqua-registry@v4.490.0...v4.491.0) [Issues](https://github.com/aquaproj/aqua-registry/issues?q=is%3Aissue+milestone%3Av4.491.0) | [Merge Requests](https://github.com/aquaproj/aqua-registry/pulls?q=is%3Apr+milestone%3Av4.491.0) | <aquaproj/aqua-registry@v4.490.0...v4.491.0> #### 🎉 New Packages [#​51349](aquaproj/aqua-registry#51349) [azu/dockerfile-pin](https://github.com/azu/dockerfile-pin) - A CLI tool that adds `@sha256:<digest>` to FROM lines in Dockerfiles and image fields in docker-compose.yml to prevent supply chain attacks [@​azu](https://github.com/azu) #### Fixes [#​51341](aquaproj/aqua-registry#51341) Enable windows support for latest Zellij [@​attakei](https://github.com/attakei) [#​51352](aquaproj/aqua-registry#51352) goreleaser/goreleaser: Disable cosign verification at v2.15.0 and v2.15.1 [#​51351](aquaproj/aqua-registry#51351) anthropics/claude-code: Exclude v2.1.88 as it's unavailable [#​51350](aquaproj/aqua-registry#51350) Re-scaffold dandavison/delta ### [`v4.490.0`](https://github.com/aquaproj/aqua-registry/releases/tag/v4.490.0) [Compare Source](aquaproj/aqua-registry@v4.489.0...v4.490.0) [Issues](https://github.com/aquaproj/aqua-registry/issues?q=is%3Aissue+milestone%3Av4.490.0) | [Merge Requests](https://github.com/aquaproj/aqua-registry/pulls?q=is%3Apr+milestone%3Av4.490.0) | <aquaproj/aqua-registry@v4.489.0...v4.490.0> #### 🎉 New Packages [#​51332](aquaproj/aqua-registry#51332) [getdbt.com/dbt-fusion](https://docs.getdbt.com/docs/local/install-dbt) The next-generation engine for dbt [@​ryan-pip](https://github.com/ryan-pip) > \[!NOTE] > To update this package using Renovate, please update aqua-renovate-config to 2.12.0 or later. > <https://github.com/aquaproj/aqua-renovate-config/releases/tag/2.12.0> #### Fixes [#​51331](aquaproj/aqua-registry#51331) steveyegge/beads: Rename gastownhall/beads [#​51272](aquaproj/aqua-registry#51272) Azure/azure-dev: Re-scaffold [@​Petermarcu](https://github.com/Petermarcu) [#​51222](aquaproj/aqua-registry#51222) shinagawa-web/gomarklint: no assets for 2.1.0 [@​scop](https://github.com/scop) [#​51046](aquaproj/aqua-registry#51046) Re-scaffold magefile/mage [@​frozenbonito](https://github.com/frozenbonito) #### Security [#​51254](aquaproj/aqua-registry#51254) lxc/incus: GitHub artifact attestations config [@​scop](https://github.com/scop) ### [`v4.489.0`](https://github.com/aquaproj/aqua-registry/releases/tag/v4.489.0) [Compare Source](aquaproj/aqua-registry@v4.488.0...v4.489.0) [Issues](https://github.com/aquaproj/aqua-registry/issues?q=is%3Aissue+milestone%3Av4.489.0) | [Merge Requests](https://github.com/aquaproj/aqua-registry/pulls?q=is%3Apr+milestone%3Av4.489.0) | <aquaproj/aqua-registry@v4.488.0...v4.489.0> #### 🎉 New Packages [emacs-eask/cli](https://github.com/emacs-eask/cli) - CLI for building, running, testing, and managing your Emacs Lisp dependencies [@​djgoku](https://github.com/djgoku) #### Fixes [#​50956](aquaproj/aqua-registry#50956) dimo414/bkt: Split darwin arm64 support at 0.8.1 [@​mtibben](https://github.com/mtibben) [#​51180](aquaproj/aqua-registry#51180) zerocore-ai/microsandbox: Rename to superradcompany/microsandbox ### [`v4.488.0`](https://github.com/aquaproj/aqua-registry/releases/tag/v4.488.0) [Compare Source](aquaproj/aqua-registry@v4.487.0...v4.488.0) [Issues](https://github.com/aquaproj/aqua-registry/issues?q=is%3Aissue+milestone%3Av4.488.0) | [Merge Requests](https://github.com/aquaproj/aqua-registry/pulls?q=is%3Apr+milestone%3Av4.488.0) | <aquaproj/aqua-registry@v4.487.0...v4.488.0> #### 🎉 New Packages [#​50878](aquaproj/aqua-registry#50878) [RasKrebs/sonar](https://github.com/RasKrebs/sonar) - CLI tool for inspecting and managing services listening on localhost ports [@​TyceHerrman](https://github.com/TyceHerrman) #### Security [#​50868](aquaproj/aqua-registry#50868) terraprovider/statebridge: GitHub artifact attestations config [@​scop](https://github.com/scop) [#​51053](aquaproj/aqua-registry#51053) updatecli/updatecli: GitHub artifact attestations config [@​scop](https://github.com/scop) #### Fixes [#​50962](aquaproj/aqua-registry#50962) drager/wasm-pack: rename the package to wasm-bindgen/wasm-pack [#​50942](aquaproj/aqua-registry#50942) google/go-jsonnet: support v0.22.0 asset naming change [@​tak848](https://github.com/tak848) [#​50835](aquaproj/aqua-registry#50835) fix various typos [@​Marukome0743](https://github.com/Marukome0743) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4xMDIuMTAiLCJ1cGRhdGVkSW5WZXIiOiI0My4xMDIuMTAiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbIlJlbm92YXRlIEJvdCIsImF1dG9tYXRpb246Ym90LWF1dGhvcmVkIiwiZGVwZW5kZW5jeS10eXBlOjptaW5vciJdfQ==-->
Check List
argd scommand when adding new packagesThis fixes
dimo414/bkton macOS ARM by splitting the current latest version range at0.8.1.Versions
0.6.0through0.8.0only shipx86_64-apple-darwin, so they still needrosetta2: true.From
0.8.1onward, upstream publishes nativeaarch64-apple-darwinassets, so the newest block now removesrosetta2and adds the top-levelarm64: aarch64replacement there.With this change, macOS ARM resolves
bkt.v{{.Version}}.aarch64-apple-darwin.zipfor0.8.1+, while older versions continue to use Rosetta-backedx86_64-apple-darwin. Linux ARM continues to resolveaarch64-unknown-linux-gnu.I verified this locally on Apple Silicon by:
aquabinary in/tmpargd grto regenerate the merged rootregistry.yamlaqua exec -- bkt --versionwith a freshAQUA_ROOT_DIRThe debug logs showed aqua downloading
https://github.com/dimo414/bkt/releases/download/0.8.1/bkt.v0.8.1.aarch64-apple-darwin.zip, andbkt --versioncompleted successfully.AI assistance was used to help investigate and prepare this change, and I reviewed the final patch before submitting.
Summary by CodeRabbit