added cell background of empty rows#6353
Merged
Conversation
SatishGandham
suggested changes
Aug 3, 2021
app/client/src/components/designSystems/appsmith/TableComponent/TableUtilities.tsx
Outdated
Show resolved
Hide resolved
SatishGandham
suggested changes
Aug 4, 2021
app/client/src/components/designSystems/appsmith/TableComponent/TableUtilities.tsx
Show resolved
Hide resolved
SatishGandham
approved these changes
Aug 4, 2021
Contributor
|
Hey @riodeuno , Saw this was in the icebox and still got picked up. Can you please take a look at this to see if it looks right, I am not sure why this moved into the iceBox into the first place |
riodeuno
approved these changes
Aug 30, 2021
Contributor
|
@somangshu This was reprioritised to a lower priority deferring to other issues, which were more critical at the time. |
albinAppsmith
pushed a commit
that referenced
this pull request
Sep 8, 2021
* remove outermost quotes (#6938) * This method removes the outermost quotes - single or double quotes - so that end users don't have to do it via javascript inside widget fields where they are meant to be bound. * fix: Wrap JSON.stringify for text widget binding(suggested widgets) (#6651) * Table widget: default selected row, 0th (#5930) * added cell background of empty rows (#6353) * added cell background of empty rows * added tooltips for all the btns in comment card (#6952) * updated button and link button as v2 design Co-authored-by: Sumit Kumar <sumit@appsmith.com> Co-authored-by: akash-codemonk <67054171+akash-codemonk@users.noreply.github.com> Co-authored-by: Bhavin K <58818598+techbhavin@users.noreply.github.com> Co-authored-by: Pranav Kanade <pranav@appsmith.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2868
Type of change
How Has This Been Tested?
Checklist:
Test coverage results 🧪
🔴 Total coverage has decreased