Fix corners of button group are cut off when there is just one button#41129
Fix corners of button group are cut off when there is just one button#41129cmppoon wants to merge 2 commits intoappsmithorg:releasefrom
Conversation
WalkthroughA new CSS rule was added to the ButtonGroupWrapper styled component to ensure that when the button group contains only a single child, the border-radius is uniformly applied to all corners of that button. Changes
Estimated code review effort1 (~2 minutes) Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🧠 Learnings (2)📓 Common learningsapp/client/src/widgets/ButtonGroupWidget/component/index.tsx (1)Learnt from: brayn003 🧰 Additional context used🧠 Learnings (2)📓 Common learningsapp/client/src/widgets/ButtonGroupWidget/component/index.tsx (1)Learnt from: brayn003 🔇 Additional comments (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
|
This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected. |
|
This PR has been closed because of inactivity. |
Description
Hello. I came across this open issue #41122, so I would like to attempt to solve it. This is my first PR for appsmith. Please let me know if any changes are needed. Thanks!
Tip
Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).
Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.
Fixes #
Issue Numberor
Fixes
Issue URL#41122Warning
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.
Automation
/ok-to-test tags=""
🔍 Cypress test results
Caution
If you modify the content in this section, you are likely to disrupt the CI result for your PR.
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit