Skip to content

fix: improve infinite scroll reset logic in TableWidgetV2 #40609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rahulbarwal merged 1 commit into from
May 8, 2025
Merged

fix: improve infinite scroll reset logic in TableWidgetV2 #40609

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions app/client/src/widgets/TableWidgetV2/widget/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1045,14 +1045,14 @@ class TableWidgetV2 extends BaseWidget<TableWidgetProps, WidgetState> {

// Reset widget state when infinite scroll is initially enabled
// This should come after all updateInfiniteScrollProperties are done
if (!prevProps.infiniteScrollEnabled && infiniteScrollEnabled) {
this.resetTableForInfiniteScroll();
}
const didInfiniteScrollEnabledChange =
prevProps.infiniteScrollEnabled !== infiniteScrollEnabled;
const didComponentHeightChange =
prevProps.componentHeight !== componentHeight;

// Reset widget state when height changes while infinite scroll is enabled
if (
infiniteScrollEnabled &&
prevProps.componentHeight !== componentHeight
didInfiniteScrollEnabledChange ||
(infiniteScrollEnabled && didComponentHeightChange)
) {
this.resetTableForInfiniteScroll();
}
Expand Down
Loading