fix: improve infinite scroll reset logic in TableWidgetV2

[rahulbarwal]

Description

Problem
Table would show inconsistent views or appear empty when infinite scroll setting changed or component height was modified.

Root cause
Page number was not reset properly during changes to infinite scroll or component height, causing the table to render an incorrect or empty state.

Solution
This PR handles improving the reset logic for the table when infinite scroll is enabled or component height changes. It refactors the reset conditions, introduces variables to track relevant state changes, and ensures the table resets correctly to maintain consistent behavior.

Fixes #40411
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags="@tag.Table"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/14903775919
Commit: efe1c54
Cypress dashboard.
Tags: @tag.Table
Spec:

---

Thu, 08 May 2025 10:36:21 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

• Yes
• No

Summary by CodeRabbit

• Refactor
  • Improved the logic for resetting the table when infinite scroll is enabled or when the component height changes, resulting in clearer and more consistent behavior. No visible changes to features or exported entities.

[coderabbitai]

Walkthrough

The update refactors the logic in the TableWidgetV2 component's componentDidUpdate method to clarify and consolidate the conditions under which the table state is reset. It introduces boolean flags to make the reset logic more explicit when infinite scroll is enabled or the component height changes.

Changes

File(s)	Change Summary
app/client/src/widgets/TableWidgetV2/widget/index.tsx	Refactored componentDidUpdate to use boolean flags for infinite scroll and height change; consolidated reset logic.

Sequence Diagram(s)

sequenceDiagram
    participant TableWidgetV2
    participant TableState

    TableWidgetV2->>TableWidgetV2: componentDidUpdate(prevProps)
    alt Infinite scroll enabled state changed OR (Infinite scroll enabled AND height changed)
        TableWidgetV2->>TableState: resetTableForInfiniteScroll()
    end

Loading

Possibly related PRs

• fix: simplify table reset logic in TableWidgetV2 #40486: Refactors the internal implementation of the resetTableForInfiniteScroll method, which is invoked by the logic updated in this PR.
• fix: reset table page number on infinite scroll reset #40603: Modifies resetTableForInfiniteScroll to reset the page number, closely related to the reset logic refactored in this PR.
• feat: reset table when infinite scroll is turned on #40066: Introduces and enhances the resetTableForInfiniteScroll method in the same file and lifecycle method as this PR.

Suggested labels

Bug, Widgets Product, Table Widget V2, ok-to-test, Query Widgets & IDE Pod

Suggested reviewers

• jacquesikot
• AmanAgarwal041

Poem

When tables scroll and heights ascend,
Logic’s refactored, clear to the end.
With booleans bright and resets in sight,
Infinite scroll now works just right.
Code flows smooth, with bugs out of view—
TableWidgetV2, we’re proud of you!
🧑‍💻✨

Tip

⚡️ Faster reviews with caching

• CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.

Enjoy the performance boost—your workflow just got faster.

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0e5252c and efe1c54.

📒 Files selected for processing (1)

• app/client/src/widgets/TableWidgetV2/widget/index.tsx (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (6)

• GitHub Check: checkTestLabel
• GitHub Check: client-check-cyclic-deps / check-cyclic-dependencies
• GitHub Check: client-build / client-build
• GitHub Check: client-unit-tests / client-unit-tests
• GitHub Check: client-lint / client-lint
• GitHub Check: client-prettier / prettier-check

🔇 Additional comments (1)

app/client/src/widgets/TableWidgetV2/widget/index.tsx (1)

1048-1056: Improved code readability with clear variable names

The refactoring introduces well-named boolean flags to clarify when the table should reset, making the logic more maintainable. This directly fixes the issue where tables displayed inconsistently when infinite scroll settings changed or component height was modified.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[rahulbarwal]

/build-deploy-preview skip-tests=true

[github-actions]

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/14903262699.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 40609.
recreate: .

[github-actions]

Deploy-Preview-URL: https://ce-40609.dp.appsmith.com