chore: Adjust WDS icon stroke

[ichik]

Description

Fixes #39762

Before	After

Automation

/ok-to-test tags="@tag.Sanity"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/14034743991
Commit: ed53a10
Cypress dashboard.
Tags: @tag.Sanity
Spec:

---

Mon, 24 Mar 2025 12:46:07 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

• Yes
• No

Summary by CodeRabbit

• Style
  • Updated icon density settings across various density levels, resulting in a more consistent and visually appealing icon appearance.

[coderabbitai]

Walkthrough

The pull request updates the tokensConfigs.json file by increasing the pixel values for icon density settings. Adjustments are made to the "tight," "regular," and "loose" density categories by modifying the stroke thickness values assigned to keys "1" through "4" within each category. No changes to exported or public entities were made.

Changes

File	Summary
app/client/.../tokensConfigs.json	Updated density pixel values for icons in "tight," "regular," and "loose" settings (keys 1-4 modified).

Assessment against linked issues

Objective	Addressed	Explanation
Adjust small icon size stroke thickness (#39762)	✅

Possibly related issues

• Adjust WDS icon stroke tokens #31206: The modifications to density values for icons may enhance icon legibility, aligning with the objectives discussed in this issue.

Possibly related PRs

• chore: WDS Refinement inner spacing #36505: Updates inner spacing values in the same configuration file, connecting it with the current density adjustments.

Suggested labels

Task, Enhancement, ok-to-test, WDS team

Suggested reviewers

• KelvinOm
• vinay-appsmith
• danielmorris-as

Poem

In the realm of pixels and code,
The icons now wear a bolder mode.
Density refined, a crisp new art,
Each stroke a masterpiece, a work of heart.
Cheers to the tweaks that'll set us apart!
🚀🌟

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0c7c05d and ed53a10.

📒 Files selected for processing (1)

• app/client/packages/design-system/theming/src/token/src/tokensConfigs.json (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (8)

• GitHub Check: parse-tags
• GitHub Check: client-lint / client-lint
• GitHub Check: client-build / client-build
• GitHub Check: client-prettier / prettier-check
• GitHub Check: client-unit-tests / client-unit-tests
• GitHub Check: chromatic-deployment
• GitHub Check: chromatic-deployment
• GitHub Check: storybook-tests

🔇 Additional comments (3)

app/client/packages/design-system/theming/src/token/src/tokensConfigs.json (3)

41-44: Updated "tight" density stroke values are clear and consistent.
The new values ("2px", "1.75px", "1.5px", "1.25px") show a consistent descending pattern, which appears to align with the intended design adjustments. Please verify that these updated stroke widths render visually as expected against the PR’s design comparison images.

---

47-50: "Regular" density stroke values updated successfully.
The updated values ("2.25px", "2px", "1.75px", "1.5px") maintain the descending order and reflect an appropriate adjustment in icon stroke. Ensure that these modifications meet the new design specifications for icon presentation.

---

53-56: "Loose" density stroke values have been adjusted appropriately.
The new stroke values ("2.5px", "2.25px", "2px", "1.75px") follow the same pattern as the other density categories and should offer a balanced visual experience. Please double-check the visual outcome in the context of the overall design system.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[ichik]

@KelvinOm it appears that stroke parameters were being applied “scaled” and not absolute, otherwise, I have no explanation of the visuals. Having this inverse progression makes everything looks okay, but we may need to reconsider overall how we do application of density and sizing in icons.