chore: WDS Refinement inner spacing

[ichik]

Description

Fixes #34208

Spacing Settings	Before	After
Regular-Regular
Regular-Big
Tight-Big

Default settings on a whole app

Before	After

Automation

/ok-to-test tags="@tag.Anvil"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/11012828581
Commit: 31c8020
Cypress dashboard.
Tags: @tag.Anvil
Spec:

---

Tue, 24 Sep 2024 11:51:40 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

• Yes
• No

Summary by CodeRabbit

• New Features
  • Adjusted inner spacing metrics for improved layout consistency.
  • Updated user sizing ratio for enhanced user interface adaptability.

[coderabbitai]

Walkthrough

The changes in this pull request involve adjustments to the tokensConfigs.json file, specifically modifying values within the innerSpacing section. The vertical inner spacing metric for the key "V" has been decreased from 1.4 to 1.2, while the "userSizingRatio" has been increased from 0.5 to 1.35. Other keys in the section remain unchanged, indicating a focused refinement of spacing parameters.

Changes

File Path	Change Summary
app/client/packages/design-system/theming/src/token/src/tokensConfigs.json	Updated innerSpacing values: "V" changed from 1.4 to 1.2, "userSizingRatio" changed from 0.5 to 1.35.

Assessment against linked issues

Objective	Addressed	Explanation
Adjust inner spacing in Buttons for when theme sizing is set to big (#34208)	✅

🌟 In the realm of design, a tweak here, a change there,
Inner spaces adjusted, with thoughtful care.
From 1.4 to 1.2, a subtle shift,
User sizing ratio, a generous lift!
Buttons now breathe, with room to play,
A harmonious balance, brightening the day! 🌈

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Outside diff range and nitpick comments (1)

app/client/packages/design-system/theming/src/token/src/tokensConfigs.json (1)

21-26: Class, let's summarize our learnings from this configuration change.

Today, we've observed two significant adjustments in our design system:

1. A slight reduction in vertical inner spacing.
2. A substantial increase in the user sizing ratio.

These changes, dear students, are like fine-tuning the instruments in an orchestra. They should harmonize our button designs, especially in the "big" theme sizing. However, remember that in the complex symphony of web design, a change in one section can resonate throughout the entire composition.

For your homework, I want you to consider:

1. How might these changes affect other components that rely on these spacing values?
2. What testing strategies would you employ to ensure these changes don't create unintended consequences?

Remember, in the world of design systems, every adjustment is a teachable moment!

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 9731728 and 31c8020.

Files selected for processing (1)

• app/client/packages/design-system/theming/src/token/src/tokensConfigs.json (1 hunks)

Additional comments not posted (2)

app/client/packages/design-system/theming/src/token/src/tokensConfigs.json (2)

26-26: Now, class, let's turn our attention to the dramatic increase in user sizing ratio.

Students, notice how we've significantly increased the "userSizingRatio" from 0.5 to 1.35. This is like giving our design elements a growth spurt! This change should address the need for more spacious buttons in the "regular-big" and "tight-big" configurations.

Can anyone hypothesize how this might impact the overall user interface? Remember, with great size comes great responsibility - we must ensure our layout doesn't become unwieldy.

Let's investigate how this change might affect our application:

#!/bin/bash
# Description: Check for components that might be impacted by the user sizing ratio change

# Test: Search for components or styles that use sizing calculations
rg --type typescript --type javascript --type css --type scss -i '(size|width|height).*calc'

---

21-21: Class, let's examine the change in vertical inner spacing.

Now, students, observe how we've adjusted the "V" value from 1.4 to 1.2. This reduction in vertical inner spacing is like tightening the lines in your notebook - it creates a more compact appearance. However, we must ensure this doesn't make our buttons feel cramped.

Can anyone tell me how this change might affect the overall button aesthetics? Remember, in design, every pixel counts!

Let's conduct a quick experiment to see how this change affects our buttons:

[github-actions]

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.