fix: making import messaging artifact agnostic#39869
Conversation
WalkthroughThis pull request introduces new constants for Git-related messaging in the client application. Two new constant objects, Changes
Assessment against linked issues
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (8)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
github-actions
bot
added
Git Product
brayn003
added
ok-to-test
github-actions
bot
added
Git Product
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
app/client/src/git/ce/constants/messages.tsx (1)
4-4: Inconsistent ellipsis usage.The wait text here uses two dots, while
CONNECT_GIT.WAIT_TEXTon line 15 uses three dots. For consistency, the standard ellipsis should have three dots.- WAIT_TEXT: "Please wait while we import via Git..", + WAIT_TEXT: "Please wait while we import via Git...",
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
app/client/src/git/ce/constants/messages.tsx(1 hunks)app/client/src/git/components/ConnectModal/ConnectInitialize/index.tsx(6 hunks)
🧰 Additional context used
🧬 Code Definitions (1)
app/client/src/git/components/ConnectModal/ConnectInitialize/index.tsx (1)
app/client/src/git/ce/constants/messages.tsx (2)
CONNECT_GIT(7-17)IMPORT_GIT(1-5)
⏰ Context from checks skipped due to timeout of 90000ms (8)
- GitHub Check: perform-test / rts-build / build
- GitHub Check: perform-test / client-build / client-build
- GitHub Check: perform-test / server-build / server-unit-tests
- GitHub Check: client-unit-tests / client-unit-tests
- GitHub Check: client-prettier / prettier-check
- GitHub Check: client-lint / client-lint
- GitHub Check: client-check-cyclic-deps / check-cyclic-dependencies
- GitHub Check: client-build / client-build
🔇 Additional comments (7)
app/client/src/git/ce/constants/messages.tsx (2)
1-5: New Git import constants look good.The
IMPORT_GITconstant object with text properties for Git import functionality provides clear, reusable messages.
7-17: New Git connection constants are well-structured.The
CONNECT_GITconstant object provides comprehensive text properties for various stages of the Git connection process.app/client/src/git/components/ConnectModal/ConnectInitialize/index.tsx (5)
44-44: Step texts updated to use constants.Step text definitions now reference the new constants, which improves maintainability.
Also applies to: 48-49, 52-53
88-93: Next step button texts updated appropriately.The
nextStepTextobject now references the constants with proper conditional logic for import vs. connect scenarios.
201-202: Modal header now uses contextual constants.The modal header now dynamically displays either the import or connect title based on the
isImportflag.
240-241: Status message updated to use constants.The loading status message now uses the appropriate constant based on the operation type.
267-268: Previous step button text updated.Button text now uses the
CONNECT_GIT.PREV_STEPconstant, improving consistency.
github-actions
bot
added
Low
## Description Fixes appsmithorg#39868 Fixes appsmithorg#39875 ## Automation /ok-to-test tags="@tag.Git" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/14030327995> > Commit: 910d99b > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=14030327995&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Git` > Spec: > <hr>Mon, 24 Mar 2025 09:14:17 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced updated user interface prompts for Git import and connection workflows, providing clearer instructions and call-to-action texts. - **Bug Fixes** - Corrected capitalization in tooltips for consistency, changing "git repo" to "Git repo." - **Refactor** - Streamlined messaging across Git integration steps to ensure a consistent and intuitive user experience. - Simplified text output for Git import messaging. - Added a new variable to track modified modules in status change calculations. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
2 participants
Description
Fixes #39868
Fixes #39875
Automation
/ok-to-test tags="@tag.Git"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/14030327995
Commit: 910d99b
Cypress dashboard.
Tags:
@tag.GitSpec:
Mon, 24 Mar 2025 09:14:17 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit
New Features
Bug Fixes
Refactor