Conversation
WalkthroughThis pull request removes a Git import message constant from the messages file and simplifies the control flow in the import modal. In the constants file, the exported function that returned a Git import limitation message is eliminated. In the import modal, the logic and conditional rendering based on the Anvil layout state are removed, resulting in the Git import card being rendered unconditionally (when not in editor mode). Changes
Sequence Diagram(s)sequenceDiagram
participant U as User
participant M as ImportModal
participant C as GitImportCard
U->>M: Open Import Modal
M->>C: Render GitImportCard (without Anvil layout check)
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (8)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
2f7b854 to
e3c70d5
Compare
e3c70d5 to
1b7663f
Compare
## Description Removed anvil feature flag check for Git import. ## Automation /ok-to-test tags="@tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/13925483139> > Commit: 1b7663f > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13925483139&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` > Spec: > <hr>Tue, 18 Mar 2025 15:00:04 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Removed an outdated warning message related to Git import limitations. - Streamlined the import interface so that Git import options display consistently without conditional warnings. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Description
Removed anvil feature flag check for Git import.
Automation
/ok-to-test tags="@tag.Sanity"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/13925483139
Commit: 1b7663f
Cypress dashboard.
Tags:
@tag.SanitySpec:
Tue, 18 Mar 2025 15:00:04 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit