Skip to content

chore: remove anvil flag for git#39785

Merged
KelvinOm merged 1 commit intoreleasefrom
chore/git-import
Mar 18, 2025
Merged

chore: remove anvil flag for git#39785
KelvinOm merged 1 commit intoreleasefrom
chore/git-import

Conversation

@KelvinOm
Copy link
Collaborator

@KelvinOm KelvinOm commented Mar 18, 2025

Description

Removed anvil feature flag check for Git import.

Automation

/ok-to-test tags="@tag.Sanity"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/13925483139
Commit: 1b7663f
Cypress dashboard.
Tags: @tag.Sanity
Spec:


Tue, 18 Mar 2025 15:00:04 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

  • Refactor
    • Removed an outdated warning message related to Git import limitations.
    • Streamlined the import interface so that Git import options display consistently without conditional warnings.

@KelvinOm KelvinOm added the ok-to-test Required label for CI label Mar 18, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 18, 2025

Walkthrough

This pull request removes a Git import message constant from the messages file and simplifies the control flow in the import modal. In the constants file, the exported function that returned a Git import limitation message is eliminated. In the import modal, the logic and conditional rendering based on the Anvil layout state are removed, resulting in the Git import card being rendered unconditionally (when not in editor mode).

Changes

File(s) Change Summary
app/client/.../constants/messages.ts Removed the export of IMPORT_FROM_GIT_DISABLED_IN_ANVIL which returned a Git import limitation message.
app/client/.../ImportModal.tsx Removed the useSelector hook and associated logic for checking the Anvil layout; simplified the rendering logic to always show the GitImportCard when toEditor is false.

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant M as ImportModal
    participant C as GitImportCard
    U->>M: Open Import Modal
    M->>C: Render GitImportCard (without Anvil layout check)
Loading

Possibly related PRs

Suggested labels

Git Product, Task

Suggested reviewers

  • ApekshaBhosale
  • jsartisan
  • sagar-qa007

Poem

In lines of code, a shift takes place,
A Git message fades without a trace.
Logic flows now smooth and free,
Simplicity for all to see.
Code and cheer in harmony!


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between 2f7b854 and 1b7663f.

📒 Files selected for processing (2)
  • app/client/src/ce/constants/messages.ts (0 hunks)
  • app/client/src/pages/common/ImportModal.tsx (3 hunks)
💤 Files with no reviewable changes (1)
  • app/client/src/ce/constants/messages.ts
🚧 Files skipped from review as they are similar to previous changes (1)
  • app/client/src/pages/common/ImportModal.tsx
⏰ Context from checks skipped due to timeout of 90000ms (8)
  • GitHub Check: perform-test / rts-build / build
  • GitHub Check: perform-test / client-build / client-build
  • GitHub Check: perform-test / server-build / server-unit-tests
  • GitHub Check: client-unit-tests / client-unit-tests
  • GitHub Check: client-lint / client-lint
  • GitHub Check: client-check-cyclic-deps / check-cyclic-dependencies
  • GitHub Check: client-prettier / prettier-check
  • GitHub Check: client-build / client-build

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label Mar 18, 2025
jsartisan
jsartisan previously approved these changes Mar 18, 2025
@KelvinOm KelvinOm added ok-to-test Required label for CI and removed ok-to-test Required label for CI labels Mar 18, 2025
@KelvinOm KelvinOm merged commit 9a48da4 into release Mar 18, 2025
45 checks passed
@KelvinOm KelvinOm deleted the chore/git-import branch March 18, 2025 15:01
github-actions bot pushed a commit to Zeral-Zhang/appsmith that referenced this pull request Apr 12, 2025
## Description
Removed anvil feature flag check for Git import. 

## Automation

/ok-to-test tags="@tag.Sanity"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/13925483139>
> Commit: 1b7663f
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=13925483139&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Sanity`
> Spec:
> <hr>Tue, 18 Mar 2025 15:00:04 UTC
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **Refactor**
- Removed an outdated warning message related to Git import limitations.
- Streamlined the import interface so that Git import options display
consistently without conditional warnings.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Required label for CI skip-changelog Adding this label to a PR prevents it from being listed in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants