chore: Fixing email verification on signup

[trishaanand]

Description

If email verification is turned on, on sign up the user is not getting logged out in case they need to verify their email. This fixes that issue.

Fixes #Issue Number
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/test sanity

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/13973800139
Commit: 81eac95
Cypress dashboard.
Tags: @tag.Sanity
Spec:

---

Thu, 20 Mar 2025 16:37:15 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

• Yes
• No

Summary by CodeRabbit

• Bug Fixes
  • Enhanced the authentication flow by fully terminating obsolete sessions after verification, ensuring that any residual session data is completely cleared for improved security.

[coderabbitai]

Walkthrough

This pull request refactors the postVerificationRequiredHandler method in the authentication success handler. The update removes the security context from the session attributes and then explicitly invalidates the session, ensuring that the session is cleared from Redis. The subsequent steps—retrieving the redirect URL and directing to the verification pending screen—remain unchanged. No changes were made to any exported or public entities.

Changes

File	Change Summary
app/.../AuthenticationSuccessHandlerCE.java	Updated postVerificationRequiredHandler method to remove the security context and explicitly invalidate the session before redirect operations.

Sequence Diagram(s)

sequenceDiagram
    participant C as Client
    participant H as AuthSuccessHandler
    participant S as Session Store (Redis)
    
    C->>H: Initiate post-verification handling
    H->>S: Remove security context
    H->>S: Invalidate session
    H->>H: Retrieve redirect URL
    H->>C: Redirect to verification pending page

Loading

Possibly related PRs

• chore: Do not trigger session creation before auth completes in signup flow #39691: Involved similar session handling changes in the signupAndLogin method, aligning modifications between session invalidation and security context management.

Suggested labels

Bug, ok-to-test

Suggested reviewers

• mohanarpit
• nidhi-nair
• sharat87

Poem

In the realm of code so fine,
A session ends, the stars align.
Security now takes its stand,
With session cleared across the land.
Cheers to safe code, bright and grand!
🚀🎉

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9de62e0 and 81eac95.

📒 Files selected for processing (1)

• app/server/appsmith-server/src/main/java/com/appsmith/server/authentication/handlers/ce/AuthenticationSuccessHandlerCE.java (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: server-spotless / spotless-check
• GitHub Check: server-unit-tests / server-unit-tests

🔇 Additional comments (1)

app/server/appsmith-server/src/main/java/com/appsmith/server/authentication/handlers/ce/AuthenticationSuccessHandlerCE.java (1)

173-188: Improved session invalidation logic

The session invalidation enhancement properly clears the Redis session after removing the security context. This is a necessary fix to ensure users are fully logged out when email verification is required, forcing them to go through the email verification flow.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.