chore: Do not trigger session creation before auth completes in signup flow

[nidhi-nair]

Description

Tip

Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).

Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.

Fixes #Issue Number
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags="@tag.Sanity"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/13810907027
Commit: 5a1cdef
Cypress dashboard.
Tags: @tag.Sanity
Spec:

---

Wed, 12 Mar 2025 12:48:55 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

• Yes
• No

Summary by CodeRabbit

• Refactor
  • Enhanced the signup and login flow to optimize session handling and security, resulting in a smoother and more robust authentication experience for users.

[coderabbitai]

Walkthrough

This change streamlines the management of session and security context in the signupAndLogin method of the UserSignupCEImpl class. The modification removes the session retrieval from the initial Mono.zip call and delays it until after the authentication success handler is invoked. The security context is now directly retrieved from the tuple and then stored in the session attributes via a subsequent operation. The error handling remains consistent with previous behavior.

Changes

File(s)	Change Summary
app/.../UserSignupCEImpl.java	Removed direct session retrieval from Mono.zip; now retrieves session after authentication success and stores security context accordingly.

Sequence Diagram(s)

sequenceDiagram
    participant US as UserSignupCEImpl
    participant MZ as Mono.zip
    participant EX as Exchange
    participant AS as AuthenticationSuccessHandler

    US->>MZ: Call Mono.zip with (auth success, security context)
    MZ-->>US: Return Tuple (auth success, security context)
    US->>AS: Invoke authentication success handler
    AS->>EX: Retrieve session from exchange
    EX-->>AS: Return session
    AS->>US: Map security context to session attributes
    alt Empty tuple
        US->>US: Return error
    end

Loading

Possibly related PRs

• fix: Signup from OAuth not being detected correctly #37697: Addresses related modifications in AuthenticationSuccessHandlerCE for user authentication success, influencing session and security context management.

Suggested labels

Bug, ok-to-test

Suggested reviewers

• mohanarpit
• sharat87
• pratapaprasanna

Poem

In code we refine the flow so neat,
With sessions shifted and contexts complete.
A tiny tweak with a clever twist,
Our logic sings like a perfect gist.
Cheers to clean code, a developer's treat!
🚀✨
Happy coding!

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c417c30 and 5a1cdef.

📒 Files selected for processing (1)

• app/server/appsmith-server/src/main/java/com/appsmith/server/solutions/ce/UserSignupCEImpl.java (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (5)

• GitHub Check: perform-test / client-build / client-build
• GitHub Check: perform-test / rts-build / build
• GitHub Check: perform-test / server-build / server-unit-tests
• GitHub Check: server-spotless / spotless-check
• GitHub Check: server-unit-tests / server-unit-tests

🔇 Additional comments (2)

app/server/appsmith-server/src/main/java/com/appsmith/server/solutions/ce/UserSignupCEImpl.java (2)

161-167: Improvement in session creation timing

The change appropriately delays session retrieval until after authentication completes rather than including it in the initial Mono.zip operation. This aligns with the PR objective and represents a more efficient approach.

---

190-196: Clean implementation of security context storage

The security context is now correctly stored in the session attributes only after authentication has succeeded. This is a more logical sequence and prevents unnecessary session creation for failed authentication attempts.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.