Skip to content

chore: Adding permission check for the plus button in tabs list #39694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ankitakinger merged 1 commit into from
Mar 12, 2025
Merged

chore: Adding permission check for the plus button in tabs list #39694

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion app/client/src/pages/AppIDE/layouts/components/EditorTabs/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,10 @@ import { ScreenModeToggle } from "./ScreenModeToggle";
import { EditableTab } from "./EditableTab";
import { TabSelectors } from "./constants";
import { AddTab } from "./AddTab";
import { useFeatureFlag } from "utils/hooks/useFeatureFlag";
import { FEATURE_FLAG } from "ee/entities/FeatureFlag";
import { getPagePermissions } from "selectors/editorSelectors";
import { getHasCreateActionPermission } from "ee/utils/BusinessFeatures/permissionPageHelpers";

const EditorTabs = () => {
const location = useLocation();
Expand All @@ -42,9 +46,19 @@ const EditorTabs = () => {
const [showNudge, dismissNudge] = useShowSideBySideNudge();
const { addClickHandler } = useIDETabClickHandlers();
const isJSLoading = useIsJSAddLoading();
const hideAdd = segmentMode === EditorEntityTabState.Add || !files.length;

const currentEntity = identifyEntityFromPath(location.pathname);
const isFeatureEnabled = useFeatureFlag(FEATURE_FLAG.license_gac_enabled);
const pagePermissions = useSelector(getPagePermissions);
const canCreateActions = getHasCreateActionPermission(
isFeatureEnabled,
pagePermissions,
);
const hideAdd =
segmentMode === EditorEntityTabState.Add ||
!files.length ||
!canCreateActions;

const showEntityListButton =
ideViewMode === EditorViewMode.SplitScreen && files.length > 0;

Expand Down
2 changes: 1 addition & 1 deletion app/client/src/pages/Editor/gitSync/components/PushFailedWarning.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ const Container = styled.div`
// eslint-disable-next-line @typescript-eslint/no-explicit-any
export default function PushFailedWarning({ closeHandler, error }: any) {
return (
<Container className="ankita">
<Container>
<Callout isClosable kind="error" onClose={closeHandler}>
<>
<Text type={TextType.H5}>{error.errorType}</Text>
Expand Down
Loading