chore: Adding permission check for the plus button in tabs list

[ankitakinger]

Description

Adding permission check for the plus button in tabs list to handle the edge case in GAC where we see a new query tab with no datasource options in the page to create one.

Fixes #39673

Automation

/ok-to-test tags="@tag.IDE"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/13811690526
Commit: 6501918
Cypress dashboard.
Tags: @tag.IDE
Spec:

---

Wed, 12 Mar 2025 13:19:18 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

• Yes
• No

Summary by CodeRabbit

• New Features
  • Enhanced the editor’s tab behavior so the "Add" button is only displayed when files are present and the user has the appropriate permissions.
• Style
  • Refined the display styling of push failure warnings for a cleaner appearance.

[coderabbitai]

Walkthrough

This pull request updates two components. In the EditorTabs component, new imports for feature flags and permission checks are added, and the logic that controls the visibility of the "Add" tab is enhanced by incorporating an additional permission check. In the PushFailedWarning component, a redundant CSS class ("ankita") is removed from the Container component, which alters the styling without affecting functionality.

Changes

File	Change Summary
app/client/.../EditorTabs/index.tsx	Added imports (useFeatureFlag, FEATURE_FLAG, getPagePermissions, getHasCreateActionPermission) and updated logic for the hideAdd variable to include a permission check for creating actions.
app/client/.../PushFailedWarning.tsx	Removed the "ankita" className from the Container component, modifying the styling context.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant EditorTabs
    participant FeatureFlag
    participant PermissionsSelector
    participant ActionPermission

    User->>EditorTabs: Open editor tabs
    EditorTabs->>FeatureFlag: useFeatureFlag(FEATURE_FLAG)
    EditorTabs->>PermissionsSelector: getPagePermissions
    EditorTabs->>ActionPermission: getHasCreateActionPermission(isFeatureEnabled, pagePermissions)
    ActionPermission-->>EditorTabs: Return canCreateActions result
    EditorTabs-->>User: Render tabs with updated hideAdd logic

Loading

Possibly related PRs

• fix: Tab navigation issue in multi page apps #38272: Adjusted EditorTabs behavior with changes to the handleTabClick function, directly relating to tab control logic modifications.
• fix: Adding permission check for the view tab on datasource editor #37308: Introduced permission checks for UI components, aligning with the new permission logic in the EditorTabs component.
• chore: Removing the hook for create actions permission #39470: Modified permission handling for creating actions, closely connected to the use of getHasCreateActionPermission in this pull request.

Suggested labels

Bug, Task, IDE Product, Platform Administration Pod, RBAC Product, ok-to-test, Medium

Suggested reviewers

• hetunandu

Poem

In our code where tabs decide,
Permissions now help guide the ride.
Feature flags illuminate the way,
A cleaner UI comes into play.
A style refined with one less tag,
Our code sings a triumphant flag!
🚀 Happy coding!

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c417c30 and 6501918.

📒 Files selected for processing (2)

• app/client/src/pages/AppIDE/layouts/components/EditorTabs/index.tsx (2 hunks)
• app/client/src/pages/Editor/gitSync/components/PushFailedWarning.tsx (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (7)

• GitHub Check: perform-test / rts-build / build
• GitHub Check: perform-test / server-build / server-unit-tests
• GitHub Check: client-unit-tests / client-unit-tests
• GitHub Check: client-lint / client-lint
• GitHub Check: client-build / client-build
• GitHub Check: client-check-cyclic-deps / check-cyclic-dependencies
• GitHub Check: client-prettier / prettier-check

🔇 Additional comments (4)

app/client/src/pages/Editor/gitSync/components/PushFailedWarning.tsx (1)

14-14: Clean-up completed: Removed redundant className

The className "ankita" has been removed from the Container component. This was likely a temporary class used for styling or debugging.

app/client/src/pages/AppIDE/layouts/components/EditorTabs/index.tsx (3)

31-34: Added required imports for permission check functionality

The imports needed for the feature flag and permission verification are properly included.

---

51-56: Permission check setup implemented

The code properly retrieves the feature flag state and page permissions, then passes them to the permission helper function.

---

57-60: Plus button visibility logic updated

The hideAdd condition now includes the permission check, addressing the issue where users without create action permissions would see the plus button but couldn't create datasources.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.