chore: added upcoming section for gac enabled users#39563
chore: added upcoming section for gac enabled users#39563AmanAgarwal041 merged 5 commits intoreleasefrom
Conversation
WalkthroughThis pull request introduces a new constant for upcoming SaaS integrations and extends component interfaces with an optional Changes
Sequence Diagram(s)sequenceDiagram
participant S as mapStateToProps
participant API as APIOrSaasPlugins
participant PD as PremiumDatasources
participant PT as PremiumTag
S->>API: Provide isGACEnabled flag
API->>PD: Render with props including isGACEnabled and premiumPlugins
alt isGACEnabled true & premiumPlugins exist
PD->>PD: Display "Upcoming SaaS Integrations" section
else
PD->>PT: Render static PremiumTag via createMessage
end
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (8)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
app/client/src/pages/Editor/IntegrationEditor/APIOrSaasPlugins.tsx (1)
357-361: Comment should be updated for clarity.The comment refers to a Notion doc for context, which is appropriate, but the phrasing could be improved for better developer understanding.
- // We are using this feature flag to identify whether its the enterprise/business user - ref : https://www.notion.so/appsmith/Condition-for-showing-Premium-Soon-tag-datasources-184fe271b0e2802cb55bd63f468df60d + // Feature flag to determine if Google Analytics Connector (GAC) is enabled - ref: https://www.notion.so/appsmith/Condition-for-showing-Premium-Soon-tag-datasources-184fe271b0e2802cb55bd63f468df60d
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
app/client/src/ce/constants/messages.ts(1 hunks)app/client/src/pages/Editor/IntegrationEditor/APIOrSaasPlugins.tsx(6 hunks)app/client/src/pages/Editor/IntegrationEditor/PremiumDatasources/Helpers.ts(0 hunks)app/client/src/pages/Editor/IntegrationEditor/PremiumDatasources/index.tsx(3 hunks)
💤 Files with no reviewable changes (1)
- app/client/src/pages/Editor/IntegrationEditor/PremiumDatasources/Helpers.ts
⏰ Context from checks skipped due to timeout of 90000ms (5)
- GitHub Check: client-lint / client-lint
- GitHub Check: client-check-cyclic-deps / check-cyclic-dependencies
- GitHub Check: client-build / client-build
- GitHub Check: client-unit-tests / client-unit-tests
- GitHub Check: client-prettier / prettier-check
🔇 Additional comments (9)
app/client/src/ce/constants/messages.ts (1)
2639-2640: LGTM - New constant for upcoming SaaS integrations messaging.The addition of this constant follows the established pattern of the codebase for message externalization.
app/client/src/pages/Editor/IntegrationEditor/APIOrSaasPlugins.tsx (4)
85-85: Appropriate interface extension for new conditional feature.Adding the optional
isGACEnabledproperty to the interface properly supports the GAC-dependent feature.
249-251: Correct conditional rendering based on GAC status.This change ensures PremiumDatasources are only shown when GAC is not enabled, aligning with the PR objective.
296-305: Feature implementation for GAC users showing upcoming integrations.The new section for upcoming SaaS integrations is correctly implemented with proper conditional rendering. This satisfies the PR objective to add this section specifically for GAC-enabled users.
395-395: LGTM - Properly exposed the GAC status to component props.This ensures the component has access to the required feature flag state.
app/client/src/pages/Editor/IntegrationEditor/PremiumDatasources/index.tsx (4)
16-20: Simplified PremiumTag styling with fixed colors.The tag styling is now consistent rather than conditionally styled. This simplification improves maintainability.
30-30: Added isGACEnabled prop to support new conditional rendering.This prop enables the component to adapt its behavior based on GAC status.
34-35: Properly forwarding GAC status to handler function.This ensures consistent behavior when interacting with premium datasources.
56-61: Implemented conditional tag rendering based on GAC status.The premium tag is now only shown when GAC is not enabled, fulfilling the requirements stated in the PR objectives.
|
/build-deploy-preview skip-tests=true |
|
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/13673049176. |
…39511-upcoming-sections
|
/build-deploy-preview skip-tests=true |
|
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/13692480609. |
|
Deploy-Preview-URL: https://ce-39563.dp.appsmith.com |
app/client/src/pages/Editor/IntegrationEditor/PremiumDatasources/index.tsx
Show resolved
Hide resolved
|
/build-deploy-preview skip-tests=true |
|
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/13715993371. |
|
/build-deploy-preview skip-tests=true |
|
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/13717910064. |
|
Deploy-Preview-URL: https://ce-39563.dp.appsmith.com |
Description
Upcoming SaaS inetgrationsfor gacEnabled users.Fixes #39511
or
Fixes
Issue URLWarning
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.
Automation
/ok-to-test tags="@tag.Datasource"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/13719106986
Commit: 0df6900
Cypress dashboard.
Tags:
@tag.DatasourceSpec:
Fri, 07 Mar 2025 11:35:59 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit
New Features
Bug Fixes
Refactor