chore: git tag - adding ui improvments by brayn003 · Pull Request #39972 · appsmithorg/appsmith

brayn003 · 2025-03-31T01:34:57Z

Description

Changes the look of TabRelease to be cleaner
Removes beta tag when release_git_package_enabled feature flag is enabled

Automation

/ok-to-test tags="@tag.Git,@tag.Module"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/14173821996
Commit: eeac00c
Cypress dashboard.
Tags: @tag.Git,@tag.Module
Spec:

Mon, 31 Mar 2025 15:16:47 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

Yes
No

Summary by CodeRabbit

New Features
- Introduced a configuration flag for managing the release package feature.
Style
- Updated module labels to conditionally display a beta indicator.
- Revised interface text for releasing versions and displaying commit details.
- Enhanced layout and visual styling for commit information and release version selection.
Refactor
- Streamlined the release button logic to require only a release version, improving usability.
- Removed unused props and logic from the release version radio group component.
- Restructured the latest commit information component for improved visual hierarchy.

coderabbitai · 2025-03-31T01:35:11Z

Walkthrough

This pull request updates several parts of the application. The messages.ts file now includes functions that dynamically display a beta label based on a passed boolean. A new feature flag, release_git_package_enabled, has been introduced. In addition, UI text constants in a Git-related messages file have been updated, while multiple Git components have been refactored to improve layout, styling, and logic. The release button logic and release version components have also been modified to adjust which props are used and how the UI is rendered.

Changes

File(s)	Change Summary
`app/client/src/ce/constants/messages.ts`	Updated `js_create_modules` and `queries_create_modules` functions to accept a boolean parameter and conditionally append a beta label.
`app/client/src/ce/entities/FeatureFlag.ts`	Introduced a new feature flag `release_git_package_enabled` in both the `FEATURE_FLAG` constant and its default value object.
`app/client/src/git/ce/constants/messages.tsx`	Changed `TAB_RELEASE.TITLE` from "Release version" to "Release a new version" and added `LATEST_COMMIT_INFO.TITLE: "Commit"`.
`app/client/src/git/components/LatestCommitInfo/LatestCommitInfoView.tsx`	Refactored rendering logic: removed the old `Container` and introduced new styled components (`TitleText`, `MutedText`, `LoadingContainer`) to improve layout and loading state handling.
`app/client/src/git/components/OpsModal/TabRelease/TabReleaseView.tsx`	Modified release button disabling logic to depend solely on the presence of `releaseVersion` rather than both `releaseVersion` and `releaseNotes`.
`app/client/src/git/components/ReleaseVersionRadioGroup/ReleaseVersionRadioGroupView.tsx` and `.../ReleaseVersionRadioGroup/index.tsx`	Removed the `releasedAt` prop and corresponding logic; added styled components (`TitleText`, `CurrentVersionTag`, `NextVersionTag`) to enhance UI presentation and adjust layout.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant TabReleaseView
    participant ReleaseProcessor

    User->>TabReleaseView: Enter releaseVersion
    TabReleaseView-->>TabReleaseView: Check if releaseVersion is provided
    alt releaseVersion exists
        TabReleaseView->>ReleaseProcessor: Trigger release process
    else
        TabReleaseView->>User: Keep release button disabled
    end

Possibly related PRs

chore: git fixes - removing beta tag #39733: Involved similar modifications to message constants by updating functions to accept a boolean parameter for conditional beta labeling.

Suggested labels

Task, Git Product, ok-to-test, Packages Product

Suggested reviewers

ashit-rath
ApekshaBhosale

Poem

In our code, a new twist unfurls,
Dynamic strings dance like precious pearls.
Feature flags light up the night,
Styled components bringing delight.
A release button sings a simpler tune,
Celebrating changes beneath the code moon.

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between 843f93c and eeac00c.

📒 Files selected for processing (2)

app/client/src/git/components/ReleaseVersionRadioGroup/ReleaseVersionRadioGroupView.test.tsx (0 hunks)
app/client/src/git/components/ReleaseVersionRadioGroup/ReleaseVersionRadioGroupView.tsx (2 hunks)

💤 Files with no reviewable changes (1)

app/client/src/git/components/ReleaseVersionRadioGroup/ReleaseVersionRadioGroupView.test.tsx

🧰 Additional context used

🧬 Code Definitions (1)

app/client/src/git/components/ReleaseVersionRadioGroup/ReleaseVersionRadioGroupView.tsx (1)

app/client/src/git/ce/constants/messages.tsx (1)

RELEASE_VERSION_RADIO_GROUP (36-39)

⏰ Context from checks skipped due to timeout of 90000ms (5)

GitHub Check: client-unit-tests / client-unit-tests
GitHub Check: client-lint / client-lint
GitHub Check: client-check-cyclic-deps / check-cyclic-dependencies
GitHub Check: client-build / client-build
GitHub Check: client-prettier / prettier-check

🔇 Additional comments (7)

app/client/src/git/components/ReleaseVersionRadioGroup/ReleaseVersionRadioGroupView.tsx (7)

2-2: Updated imports to support new styled components and icon.

The addition of Icon and styled imports are necessary for the UI enhancements implemented in this PR.

Also applies to: 6-6

8-19: Good use of styled components for UI improvements.

Creating dedicated styled components improves code maintainability and encapsulates styling logic. The components create clear visual distinction between current and next version tags.

57-60: Improved spacing and Typography component.

Increasing the gap to spaces-3 and using the custom TitleText component improves readability and visual hierarchy.

61-70: RadioGroup component layout improvements.

The RadioGroup has been restructured with better spacing and orientation properties. The explicit UNSAFE_gap property ensures consistent spacing between radio options.

71-83: Enhanced version display with icon.

The addition of the arrow icon between version tags creates a clearer visual relationship between current and next versions. The CurrentVersionTag styled component provides better visual distinction.

84-91: Improved next version tag styling.

The NextVersionTag styled component with purple accent colors helps users distinguish the proposed next version more easily.

23-26: Interface simplification is appropriate.

Removing the unused releasedAt property from the interface aligns with the PR objective to clean up the component.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai plan to trigger planning for file edits and PR creation.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

…git-tag-7

sneha122

LGTM

## Description - Changes the look of TabRelease to be cleaner - Removes beta tag when `release_git_package_enabled` feature flag is enabled ## Automation /ok-to-test tags="@tag.Git,@tag.Module" ### 🔍 Cypress test results  > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/14173821996> > Commit: eeac00c > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=14173821996&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Git,@tag.Module` > Spec: > <hr>Mon, 31 Mar 2025 15:16:47 UTC  ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No  ## Summary by CodeRabbit - **New Features** - Introduced a configuration flag for managing the release package feature. - **Style** - Updated module labels to conditionally display a beta indicator. - Revised interface text for releasing versions and displaying commit details. - Enhanced layout and visual styling for commit information and release version selection. - **Refactor** - Streamlined the release button logic to require only a release version, improving usability. - Removed unused props and logic from the release version radio group component. - Restructured the latest commit information component for improved visual hierarchy.

Rudraprasad Das added 2 commits March 31, 2025 03:15

chore: ui changes for tab release

d91586b

chore: removing is beta for feature flag

af2bc1b

github-actions bot added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label Mar 31, 2025

Rudraprasad Das added 3 commits March 31, 2025 03:41

chore: fixing build

ecbc8ed

Merge branch 'release' of github.com:appsmithorg/appsmith into chore/…

843f93c

…git-tag-7

chore: fixing tests

eeac00c

sneha122 approved these changes Mar 31, 2025

View reviewed changes

brayn003 added the ok-to-test Required label for CI label Mar 31, 2025

brayn003 merged commit c675c03 into release Mar 31, 2025
50 checks passed

brayn003 deleted the chore/git-tag-7 branch March 31, 2025 17:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: git tag - adding ui improvments#39972

chore: git tag - adding ui improvments#39972
brayn003 merged 5 commits intoreleasefrom
chore/git-tag-7

brayn003 commented Mar 31, 2025 •

edited by github-actions bot

Loading

Uh oh!

coderabbitai bot commented Mar 31, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

sneha122 left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

brayn003 commented Mar 31, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Automation

🔍 Cypress test results

Communication

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Mar 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

sneha122 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

brayn003 commented Mar 31, 2025 •

edited by github-actions bot

Loading

coderabbitai bot commented Mar 31, 2025 •

edited

Loading