fix: move to page redirection issue fixed for paragon integration

[sneha122]

Description

This PR fixes issue where if we move external saas integration query from page 1 to page 2, redirection to page 2 was not happening. It's been fixed in this PR. This issue was there for remote as well as AI plugin, it's been fixed as well.

Fixes #39163
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags="@tag.Datasource"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/13286248107
Commit: 1cae0a7
Cypress dashboard.
Tags: @tag.Datasource
Spec:

---

Wed, 12 Feb 2025 14:03:01 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

• Yes
• No

Summary by CodeRabbit

• Refactor
  • Streamlined internal navigation logic for plugin workflows by replacing multiple conditional checks with a structured approach. The update improves code maintainability without impacting existing end-user functionality.

[coderabbitai]

Walkthrough

The changes refactor the handleMoveOrCopySaga function in the sagas file. The refactoring replaces multiple conditional branches with a switch statement that checks the pluginType. The new structure consolidates the handling of PluginType.DB and PluginType.INTERNAL into a default case, while the cases for PluginType.API and PluginType.SAAS remain similar. Overall, the control flow is made more structured by eliminating redundant if checks, without altering public or exported entities.

Changes

File	Summary of Changes
app/.../sagas/ActionSagas.ts	Refactored handleMoveOrCopySaga by replacing multiple if statements with a switch statement; consolidated handling for DB and INTERNAL.

Sequence Diagram(s)

sequenceDiagram
    participant Caller as Caller
    participant Saga as handleMoveOrCopySaga
    participant Navigator as Navigation Logic

    Caller->>Saga: Invoke with pluginType
    alt PluginType.API or PluginType.SAAS
        Saga->>Navigator: Execute appropriate navigation logic
    else PluginType.DB or PluginType.INTERNAL (and others)
        Saga->>Navigator: Execute default navigation logic
    end

Loading

Suggested labels

Bug, ok-to-test, Integrations Product, Integrations Pod General, Query & JS Pod, Task

Suggested reviewers

• ankitakinger
• AmanAgarwal041

Poem

In the code where logic now sways,
A switch takes charge in vibrant displays,
Internal checks merge into one, so clear,
API and SAAS stand firm right here,
In this refactor, simplicity sings its tune 🎶
Cheers to code that makes our progress bloom!

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between be3809f and 1cae0a7.

📒 Files selected for processing (1)

• app/client/src/sagas/ActionSagas.ts (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (5)

• GitHub Check: client-check-cyclic-deps / check-cyclic-dependencies
• GitHub Check: client-lint / client-lint
• GitHub Check: client-unit-tests / client-unit-tests
• GitHub Check: client-build / client-build
• GitHub Check: client-prettier / prettier-check

🔇 Additional comments (1)

app/client/src/sagas/ActionSagas.ts (1)

1072-1106: LGTM! Improved control flow for handling redirections.

The switch statement refactoring enhances code readability and maintainability while fixing the page redirection issue. The separation of concerns for different plugin types is now clearer.

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sneha122]

/build-deploy-preview skip-tests=true

[github-actions]

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/13286286010.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 39215.
recreate: .

[github-actions]

Deploy-Preview-URL: https://ce-39215.dp.appsmith.com