fix: Datasource API split changes

[sneha122]

Description

This PR contains CE and EE split changes for DatasourcesApi.ts

Fixes #Issue Number
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags="@tag.All"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/14103345701
Commit: aa7ce51
Cypress dashboard.
Tags: @tag.All
Spec:

---

Thu, 27 Mar 2025 10:45:32 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

• Yes
• No

Summary by CodeRabbit

Summary by CodeRabbit

• New Features

  • Enhanced datasource management now leverages improved enterprise services, offering a more robust and streamlined experience when configuring and managing data connections.
  • Introduced new interfaces for SSH key management, expanding type definitions related to Git.

• Refactor

  • Standardized internal integrations to consistently utilize the upgraded enterprise functionalities across the application.

[coderabbitai]

Walkthrough

This pull request refactors datasource import paths without altering the underlying functionality. The updates change import sources for both CreateDatasourceConfig and DatasourcesApi from the base api namespace to the enterprise-specific ee/api namespace. Additionally, an import for ApiResponse in one file is updated from a relative to an absolute path. A new file is added that introduces an extended DatasourcesApi class in the Enterprise Edition context.

Changes

File(s)	Change Summary
app/.../datasourceActions.ts, app/.../DBOrMostPopularPlugins.tsx, app/.../DatasourcesSagas.ts	Updated import for CreateDatasourceConfig from "api/DatasourcesApi" to "ee/api/DatasourcesApi".
app/.../ApplicationSagas.tsx, app/.../DatasourcesSagas.ts	Updated import for DatasourcesApi from "api/DatasourcesApi" to "ee/api/DatasourcesApi".
app/.../ce/api/DatasourcesApi.ts	Changed import for ApiResponse from a relative ("./ApiResponses") to an absolute path ("api/ApiResponses").
app/.../ee/api/DatasourcesApi.ts	New file added. Introduced a DatasourcesApi class that extends CE_DatasourcesApi and is exported as the default.

Sequence Diagram(s)

sequenceDiagram
    participant UI
    participant Saga
    participant EE_API

    UI->>Saga: Trigger datasource action
    Saga->>EE_API: Invoke API method
    EE_API-->>Saga: Return API response
    Saga-->>UI: Deliver result

Loading

Possibly related PRs

• chore: git pkg - package integration with git #39342: The changes in the main PR, which involve updating the import path for the CreateDatasourceConfig type, are related to the changes in the retrieved PR, as both involve modifications to the import paths for the DatasourcesApi module, indicating a shared context in the codebase.
• chore: Create query selector #37018: The changes in the main PR are related to the same CreateDatasourceConfig type being modified in the datasourceActions.ts file, which is also referenced in the retrieved PR's updates to the createTempDatasourceFromForm function.
• feat: paragon frontend ds creation implementation added #38456: The changes in the main PR, which involve updating the import path for the CreateDatasourceConfig type, are directly related to the changes in the retrieved PR, as both involve modifications to the import paths for the DatasourcesApi module, specifically transitioning to the ee namespace.

Suggested labels

Enhancement, Task, Integrations Product, Query & JS Pod, Git Product

Suggested reviewers

• ayushpahwa
• AmanAgarwal041

Poem

In code we ventured on a changing trail,
Shifting paths from old to bold without fail.
From "api" to "ee", our imports realign,
A new API class makes the code shine.
Cheers to clean structure and a joyful compile!
✨🚀

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

app/client/src/git/types.ts (1)

62-66: Fix typo in property name.

There's a typo in the property name platFormSupported - it should be platformSupported (camelCase) for consistency with TypeScript naming conventions.

export interface SSHKeyType {
  keySize: number;
-  platFormSupported: string;
+  platformSupported: string;
  protocolName: string;
}

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between 9b7e282 and aa7ce51.

📒 Files selected for processing (2)

• app/client/src/git/types.ts (1 hunks)
• app/client/src/reducers/uiReducers/gitSyncReducer.ts (1 hunks)

✅ Files skipped from review due to trivial changes (1)

• app/client/src/reducers/uiReducers/gitSyncReducer.ts

⏰ Context from checks skipped due to timeout of 90000ms (8)

• GitHub Check: perform-test / rts-build / build
• GitHub Check: perform-test / client-build / client-build
• GitHub Check: perform-test / server-build / server-unit-tests
• GitHub Check: client-lint / client-lint
• GitHub Check: client-check-cyclic-deps / check-cyclic-dependencies
• GitHub Check: client-unit-tests / client-unit-tests
• GitHub Check: client-prettier / prettier-check
• GitHub Check: client-build / client-build

🔇 Additional comments (1)

app/client/src/git/types.ts (1)

68-72: LGTM! The GetSSHKeyResponseData interface looks well-defined.

The interface properly uses the SSHKeyType array and includes the optional publicKey property, which is appropriately marked with the optional modifier.