Skip to content

chore: Accept app mode param in fetch environment action #38786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ashit-rath merged 2 commits into from
Jan 23, 2025
Merged

chore: Accept app mode param in fetch environment action #38786

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc09542
chore: Add mode in fetch environment action
ashit-rath Jan 21, 2025
980841c
Merge branch 'release' into fix/env-view-mode-ce
ashit-rath Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion app/client/src/ce/actions/environmentAction.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import type { APP_MODE } from "entities/App";

// Redux action to show the environment info modal before deploy
export const showEnvironmentDeployInfoModal = () => ({});

Expand All @@ -11,12 +13,14 @@ export const setCurrentEditingEnvironmentID = (currentEditingId: string) => ({
export const fetchingEnvironmentConfigs = ({
editorId,
fetchDatasourceMeta = false,
mode,
workspaceId,
}: {
editorId: string;
fetchDatasourceMeta: boolean;
workspaceId: string;
mode?: APP_MODE;
Comment thread
ayushpahwa marked this conversation as resolved.
}) => ({
type: "",
payload: { workspaceId, editorId, fetchDatasourceMeta },
payload: { workspaceId, editorId, fetchDatasourceMeta, mode },
});
1 change: 1 addition & 0 deletions app/client/src/ce/sagas/ApplicationSagas.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,6 +293,7 @@ export function* fetchAppAndPagesSaga(
payload: {
workspaceId: response.data.workspaceId,
editorId: response.data.application?.id,
mode: request.mode,
},
});

Expand Down