chore: Accept app mode param in fetch environment action

[ashit-rath]

Description

Adds mode as a a param to the fetchingEnvironmentConfigs action to handle the environment resolution on page load. The extended code is in EE where this change is leveraged.

EE PR https://github.com/appsmithorg/appsmith-ee/pull/5977

Automation

/ok-to-test tags="@tag.Sanity"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/12926385771
Commit: 980841c
Cypress dashboard.
Tags: @tag.Sanity
Spec:

---

Thu, 23 Jan 2025 10:53:11 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

• Yes
• No

Summary by CodeRabbit

• New Features
  • Enhanced environment configuration fetching with optional application mode parameter
  • Improved workspace ID setting to include application mode context

[coderabbitai]

Walkthrough

The pull request introduces modifications to environment configuration fetching by adding an optional mode parameter to the fetchingEnvironmentConfigs function. This change allows for more flexible handling of application mode during environment configuration retrieval, with updates spanning across environmentAction.ts and ApplicationSagas.tsx to propagate the mode information through the application's state management system.

Changes

File	Change Summary
app/client/src/ce/actions/environmentAction.ts	Added optional mode: APP_MODE parameter to fetchingEnvironmentConfigs function
app/client/src/ce/sagas/ApplicationSagas.tsx	Updated SET_CURRENT_WORKSPACE_ID action payload to include mode from request

Possibly related PRs

• fix: Revert PageSaga changes #36666: Updates to page loading action creators
• fix: Plugin Action Editor navigation issue with git #37670: Navigation improvements in Plugin Action Editor
• chore: Add code split for adding package pull status indicator #37944: Refactoring of application data fetching methods

Suggested Labels

Git Product, ok-to-test, skip-changelog

Suggested Reviewers

• sharat87
• nidhi-nair
• subrata71

Poem

Code flows like river's might,
Mode parameter takes its flight,
Configs dance with newfound grace,
Saga's payload finds its place,
Flexibility blooms so bright! 🚀✨

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 704e473 and 980841c.

📒 Files selected for processing (2)

• app/client/src/ce/actions/environmentAction.ts (2 hunks)
• app/client/src/ce/sagas/ApplicationSagas.tsx (1 hunks)

🧰 Additional context used

📓 Learnings (1)

app/client/src/ce/actions/environmentAction.ts (1)

Learnt from: AmanAgarwal041
PR: appsmithorg/appsmith#29266
File: app/client/src/ce/actions/environmentAction.ts:15-16
Timestamp: 2024-11-12T08:11:36.416Z
Learning: The `type` property in the `fetchingEnvironmentConfigs` action creator is intentionally left as an empty string to imitate the functionality of the enterprise edition, as per the user's clarification.

⏰ Context from checks skipped due to timeout of 90000ms (5)

• GitHub Check: client-lint / client-lint
• GitHub Check: client-check-cyclic-deps / check-cyclic-dependencies
• GitHub Check: client-build / client-build
• GitHub Check: client-unit-tests / client-unit-tests
• GitHub Check: client-prettier / prettier-check

🔇 Additional comments (3)

app/client/src/ce/actions/environmentAction.ts (2)

1-1: LGTM! Clean import addition.

The APP_MODE type import is correctly added.

---

16-16: LGTM! Well-structured parameter addition.

The optional mode parameter is properly typed and correctly propagated to the payload.

Also applies to: 22-22, 25-25

app/client/src/ce/sagas/ApplicationSagas.tsx (1)

296-296: LGTM! Proper propagation of mode parameter.

The mode parameter is correctly forwarded from the request to the SET_CURRENT_WORKSPACE_ID action payload.

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[ayushpahwa]

LGTM, small comment added.