Skip to content

chore: Make Split screen feature GA #38731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hetunandu merged 1 commit into from
Jan 17, 2025
Merged

chore: Make Split screen feature GA #38731

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion app/client/cypress/support/Objects/FeatureFlags.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import { ObjectsRegistry } from "./Registry";
import produce from "immer";

const defaultFlags = {
release_side_by_side_ide_enabled: true,
rollout_remove_feature_walkthrough_enabled: false, // remove this flag from here when it's removed from code
release_git_modularisation_enabled: true,
};
Expand Down
9 changes: 0 additions & 9 deletions app/client/src/IDE/hooks/useIsInSideBySideEditor.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,6 @@ import type { Store } from "redux";
const JS_COLLECTION_EDITOR_PATH =
"/app/app-name/page-665dd1103e4483728c9ed11a/edit/jsObjects";
const NON_JS_COLLECTION_EDITOR_PATH = "/some-other-path";
const FEATURE_FLAGS = {
rollout_side_by_side_enabled: true,
};

const renderUseIsInSideBySideEditor = (
history: MemoryHistory,
Expand All @@ -41,7 +38,6 @@ describe("useIsInSideBySideEditor", () => {
const store = testStore(
getIDETestState({
ideView: EditorViewMode.SplitScreen,
featureFlags: FEATURE_FLAGS,
}),
);

Expand All @@ -54,7 +50,6 @@ describe("useIsInSideBySideEditor", () => {
const store = testStore(
getIDETestState({
ideView: EditorViewMode.FullScreen,
featureFlags: FEATURE_FLAGS,
}),
);

Expand All @@ -71,7 +66,6 @@ describe("useIsInSideBySideEditor", () => {
const store = testStore(
getIDETestState({
ideView: EditorViewMode.SplitScreen,
featureFlags: FEATURE_FLAGS,
}),
);

Expand All @@ -88,7 +82,6 @@ describe("useIsInSideBySideEditor", () => {
const store = testStore(
getIDETestState({
ideView: EditorViewMode.SplitScreen,
featureFlags: FEATURE_FLAGS,
}),
);

Expand All @@ -105,7 +98,6 @@ describe("useIsInSideBySideEditor", () => {
const store = testStore(
getIDETestState({
ideView: EditorViewMode.SplitScreen,
featureFlags: FEATURE_FLAGS,
}),
);

Expand All @@ -130,7 +122,6 @@ describe("useIsInSideBySideEditor", () => {
const store = testStore(
getIDETestState({
ideView: EditorViewMode.SplitScreen,
featureFlags: FEATURE_FLAGS,
}),
);

Expand Down
4 changes: 0 additions & 4 deletions app/client/src/ce/entities/FeatureFlag.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,12 @@ export const FEATURE_FLAG = {
license_widget_rtl_support_enabled: "license_widget_rtl_support_enabled",
ab_one_click_learning_popover_enabled:
"ab_one_click_learning_popover_enabled",
release_side_by_side_ide_enabled: "release_side_by_side_ide_enabled",
ab_appsmith_ai_query: "ab_appsmith_ai_query",
rollout_remove_feature_walkthrough_enabled:
"rollout_remove_feature_walkthrough_enabled",
rollout_eslint_enabled: "rollout_eslint_enabled",
release_drag_drop_building_blocks_enabled:
"release_drag_drop_building_blocks_enabled",
rollout_side_by_side_enabled: "rollout_side_by_side_enabled",
release_layout_conversion_enabled: "release_layout_conversion_enabled",
release_anvil_toggle_enabled: "release_anvil_toggle_enabled",
release_git_persist_branch_enabled: "release_git_persist_branch_enabled",
Expand Down Expand Up @@ -79,11 +77,9 @@ export const DEFAULT_FEATURE_FLAG_VALUE: FeatureFlags = {
license_git_continuous_delivery_enabled: false,
license_widget_rtl_support_enabled: false,
ab_one_click_learning_popover_enabled: false,
release_side_by_side_ide_enabled: false,
ab_appsmith_ai_query: false,
rollout_remove_feature_walkthrough_enabled: true,
rollout_eslint_enabled: false,
rollout_side_by_side_enabled: false,
release_layout_conversion_enabled: false,
release_anvil_toggle_enabled: false,
release_git_persist_branch_enabled: false,
Expand Down
1 change: 0 additions & 1 deletion ...t/src/components/editorComponents/PartialImportExport/PartialExportModal/unitTestUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12764,7 +12764,6 @@ export const defaultAppState = {
release_show_new_sidebar_announcement_enabled: false,
rollout_app_sidebar_enabled: false,
ab_one_click_learning_popover_enabled: false,
release_side_by_side_ide_enabled: false,
license_git_unlimited_repo_enabled: false,
ask_ai_js: false,
license_connection_pool_size_enabled: false,
Expand Down
13 changes: 0 additions & 13 deletions app/client/src/pages/Editor/IDE/EditorPane/JS/JSRender.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,6 @@ import { EditorEntityTab, EditorViewMode } from "ee/entities/IDE/constants";
import { PageFactory } from "test/factories/PageFactory";
import { JSObjectFactory } from "test/factories/Actions/JSObject";

const FeatureFlags = {
rollout_side_by_side_enabled: true,
};

const basePageId = "0123456789abcdef00000000";

describe("IDE Render: JS", () => {
Expand All @@ -24,7 +20,6 @@ describe("IDE Render: JS", () => {
</Route>,
{
url: `/app/applicationSlug/pageSlug-${basePageId}/edit/jsObjects`,
featureFlags: FeatureFlags,
},
);

Expand All @@ -49,7 +44,6 @@ describe("IDE Render: JS", () => {
{
url: `/app/applicationSlug/pageSlug-${basePageId}/edit/jsObjects`,
initialState: state,
featureFlags: FeatureFlags,
},
);

Expand All @@ -73,7 +67,6 @@ describe("IDE Render: JS", () => {
</Route>,
{
url: `/app/applicationSlug/pageSlug-${basePageId}/edit/jsObjects/add`,
featureFlags: FeatureFlags,
},
);

Expand All @@ -98,7 +91,6 @@ describe("IDE Render: JS", () => {
{
url: `/app/applicationSlug/pageSlug-${basePageId}/edit/jsObjects/add`,
initialState: state,
featureFlags: FeatureFlags,
},
);

Expand Down Expand Up @@ -137,7 +129,6 @@ describe("IDE Render: JS", () => {
{
url: `/app/applicationSlug/pageSlug-${page.basePageId}/edit/jsObjects/${js1.baseId}`,
initialState: state,
featureFlags: FeatureFlags,
},
);

Expand Down Expand Up @@ -194,7 +185,6 @@ describe("IDE Render: JS", () => {
{
url: `/app/applicationSlug/pageSlug-${page.basePageId}/edit/jsObjects/${js2.baseId}`,
initialState: state,
featureFlags: FeatureFlags,
},
);

Expand Down Expand Up @@ -241,7 +231,6 @@ describe("IDE Render: JS", () => {
{
url: `/app/applicationSlug/pageSlug-${page.basePageId}/edit/jsObjects/${js3.baseId}/add`,
initialState: state,
featureFlags: FeatureFlags,
},
);

Expand Down Expand Up @@ -283,7 +272,6 @@ describe("IDE Render: JS", () => {
{
url: `/app/applicationSlug/pageSlug-${page.basePageId}/edit/jsObjects/${js4.baseId}/add`,
initialState: state,
featureFlags: FeatureFlags,
},
);

Expand Down Expand Up @@ -334,7 +322,6 @@ describe("IDE Render: JS", () => {
{
url: `/app/applicationSlug/pageSlug-${page.basePageId}/edit/jsObjects/${Main_JS.baseId}`,
initialState: state,
featureFlags: FeatureFlags,
},
);

Expand Down
22 changes: 2 additions & 20 deletions app/client/src/pages/Editor/IDE/EditorPane/Query/QueryRender.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,6 @@ import { PageFactory } from "test/factories/PageFactory";
import { screen, waitFor } from "@testing-library/react";
import { GoogleSheetFactory } from "test/factories/Actions/GoogleSheetFactory";

const FeatureFlags = {
rollout_side_by_side_enabled: true,
};

const basePageId = "0123456789abcdef00000000";

describe("IDE URL rendering of Queries", () => {
Expand All @@ -28,7 +24,6 @@ describe("IDE URL rendering of Queries", () => {
</Route>,
{
url: `/app/applicationSlug/pageSlug-${basePageId}/edit/queries`,
featureFlags: FeatureFlags,
},
);

Expand All @@ -51,7 +46,6 @@ describe("IDE URL rendering of Queries", () => {
{
url: `/app/applicationSlug/pageSlug-${basePageId}/edit/queries`,
initialState: state,
featureFlags: FeatureFlags,
},
);

Expand All @@ -73,7 +67,6 @@ describe("IDE URL rendering of Queries", () => {
</Route>,
{
url: `/app/applicationSlug/pageSlug-${basePageId}/edit/queries/add`,
featureFlags: FeatureFlags,
},
);

Expand Down Expand Up @@ -102,7 +95,6 @@ describe("IDE URL rendering of Queries", () => {
{
url: `/app/applicationSlug/pageSlug-${basePageId}/edit/queries/add`,
initialState: state,
featureFlags: FeatureFlags,
},
);

Expand Down Expand Up @@ -148,7 +140,6 @@ describe("IDE URL rendering of Queries", () => {
{
url: `/app/applicationSlug/pageSlug-${page.basePageId}/edit/api/${anApi.baseId}`,
initialState: state,
featureFlags: FeatureFlags,
},
);

Expand Down Expand Up @@ -205,7 +196,6 @@ describe("IDE URL rendering of Queries", () => {
{
url: `/app/applicationSlug/pageSlug-${page.basePageId}/edit/api/${anApi.baseId}`,
initialState: state,
featureFlags: FeatureFlags,
},
);

Expand Down Expand Up @@ -250,7 +240,6 @@ describe("IDE URL rendering of Queries", () => {
{
url: `/app/applicationSlug/pageSlug-${page.basePageId}/edit/api/${anApi.baseId}/add`,
initialState: state,
featureFlags: FeatureFlags,
},
);

Expand Down Expand Up @@ -292,7 +281,6 @@ describe("IDE URL rendering of Queries", () => {
{
url: `/app/applicationSlug/pageSlug-${page.basePageId}/edit/api/${anApi.baseId}/add`,
initialState: state,
featureFlags: FeatureFlags,
},
);

Expand Down Expand Up @@ -347,7 +335,6 @@ describe("IDE URL rendering of Queries", () => {
url: `/app/applicationSlug/pageSlug-${page.basePageId}/edit/queries/${anQuery.baseId}`,
sagasToRun: sagasToRunForTests,
initialState: state,
featureFlags: FeatureFlags,
},
);

Expand Down Expand Up @@ -402,7 +389,6 @@ describe("IDE URL rendering of Queries", () => {
url: `/app/applicationSlug/pageSlug-${page.basePageId}/edit/queries/${anQuery.baseId}`,
sagasToRun: sagasToRunForTests,
initialState: state,
featureFlags: FeatureFlags,
},
);

Expand Down Expand Up @@ -448,7 +434,7 @@ describe("IDE URL rendering of Queries", () => {
{
url: `/app/applicationSlug/${page.slug}-${page.pageId}/edit/queries/${anQuery.baseId}/add`,
initialState: state,
featureFlags: FeatureFlags,

sagasToRun: sagasToRunForTests,
},
);
Expand Down Expand Up @@ -492,7 +478,6 @@ describe("IDE URL rendering of Queries", () => {
url: `/app/applicationSlug/pageSlug-${page.basePageId}/edit/queries/${anQuery.baseId}/add`,
sagasToRun: sagasToRunForTests,
initialState: state,
featureFlags: FeatureFlags,
},
);

Expand Down Expand Up @@ -548,7 +533,6 @@ describe("IDE URL rendering of Queries", () => {
url: `/app/applicationSlug/pageSlug-${page.basePageId}/edit/saas/google-sheets-plugin/api/${anQuery.baseId}`,
sagasToRun: sagasToRunForTests,
initialState: state,
featureFlags: FeatureFlags,
},
);

Expand Down Expand Up @@ -597,7 +581,6 @@ describe("IDE URL rendering of Queries", () => {
url: `/app/applicationSlug/pageSlug-${page.basePageId}/edit/saas/google-sheets-plugin/api/${anQuery.baseId}`,
sagasToRun: sagasToRunForTests,
initialState: state,
featureFlags: FeatureFlags,
},
);

Expand Down Expand Up @@ -646,7 +629,7 @@ describe("IDE URL rendering of Queries", () => {
{
url: `/app/applicationSlug/pageSlug-${page.basePageId}/edit/saas/google-sheets-plugin/api/${anQuery.baseId}/add`,
initialState: state,
featureFlags: FeatureFlags,

sagasToRun: sagasToRunForTests,
},
);
Expand Down Expand Up @@ -691,7 +674,6 @@ describe("IDE URL rendering of Queries", () => {
url: `/app/applicationSlug/pageSlug-${page.basePageId}/edit/saas/google-sheets-plugin/api/${anQuery.baseId}/add`,
sagasToRun: sagasToRunForTests,
initialState: state,
featureFlags: FeatureFlags,
},
);

Expand Down
8 changes: 0 additions & 8 deletions app/client/src/pages/Editor/IDE/EditorPane/UI/UIRender.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,6 @@ import {
} from "test/factories/WidgetFactoryUtils";
import { EditorViewMode } from "ee/entities/IDE/constants";

const FeatureFlags = {
rollout_side_by_side_enabled: true,
};

const pageId = "0123456789abcdef00000000";

describe("IDE URL rendering: UI", () => {
Expand All @@ -32,7 +28,6 @@ describe("IDE URL rendering: UI", () => {
</Route>,
{
url: `/app/applicationSlug/pageSlug-${pageId}/edit`,
featureFlags: FeatureFlags,
initialState: state,
},
);
Expand All @@ -52,7 +47,6 @@ describe("IDE URL rendering: UI", () => {
</Route>,
{
url: `/app/applicationSlug/pageSlug-${pageId}/edit/widgets`,
featureFlags: FeatureFlags,
initialState: state,
},
);
Expand Down Expand Up @@ -101,7 +95,6 @@ describe("IDE URL rendering: UI", () => {
</Route>,
{
url,
featureFlags: FeatureFlags,
initialState: state,
},
);
Expand All @@ -126,7 +119,6 @@ describe("IDE URL rendering: UI", () => {
</Route>,
{
url: `/app/applicationSlug/pageSlug-${pageId}/edit`,
featureFlags: FeatureFlags,
initialState: state,
},
);
Expand Down
Loading
Loading