chore: Make Split screen feature GA

[hetunandu]

Description

Remove all feature flags that control Split screen feature and make it Generally Available

Fixes #29867

Automation

/ok-to-test tags="@tag.All"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/12825281116
Commit: eb71398
Cypress dashboard.
Tags: @tag.All
Spec:

---

Fri, 17 Jan 2025 09:48:46 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

• Yes
• No

Summary by CodeRabbit

Based on the comprehensive summary, here are the release notes:

• Feature Flags

  • Removed side-by-side IDE related feature flags from the application
  • Simplified feature flag configuration

• Editor Behavior

  • Unconditionally set editor to split-screen mode when creating new queries and JavaScript collections
  • Removed conditional rendering based on side-by-side editor feature flag

• Testing

  • Updated test suites to remove side-by-side editor feature flag references
  • Simplified test configurations for various editor components

These changes streamline the IDE's configuration and remove feature flag complexity around side-by-side editing.

[coderabbitai]

Walkthrough

This pull request focuses on removing feature flags and associated logic related to the side-by-side IDE functionality. The changes span multiple files across the client application, systematically eliminating references to release_side_by_side_ide_enabled and rollout_side_by_side_enabled flags. The modifications simplify the codebase by removing conditional rendering and feature flag checks, effectively making the side-by-side editor mode a default state.

Changes

File Path	Change Summary
cypress/support/Objects/FeatureFlags.ts	Removed release_side_by_side_ide_enabled from default flags
ce/entities/FeatureFlag.ts	Deleted release_side_by_side_ide_enabled and rollout_side_by_side_enabled from feature flags
pages/Editor/IDE/EditorPane/*/*.test.tsx	Removed feature flag constants in multiple test files
pages/Editor/IDE/EditorTabs/index.tsx	Removed getIsSideBySideEnabled selector and related checks
sagas/ActionSagas.ts & sagas/JSPaneSagas.ts	Unconditionally set editor view mode to SplitScreen
selectors/ideSelectors.tsx	Removed getIsSideBySideEnabled selector

Assessment against linked issues

Objective	Addressed	Explanation
Side by Side IDE Implementation [#29867]	✅

Possibly related PRs

• chore: Removes GA feature flag release_show_partial_import_export_enabled #33563: Feature flag cleanup
• fix: remove building blocks on canvas #33761: Removal of side-by-side state management
• feat: side-by-side edit mode hover analytics #34185: Side-by-side widget analytics

Suggested Labels

Enhancement, IDE Product, IDE Pod, skip-changelog

Suggested Reviewers

• ApekshaBhosale
• NandanAnantharamu
• ankitakinger

Poem

In the realm of code, where flags once flew,
Side-by-side IDE bids its adieu 🏁
Simplicity reigns, complexity fades
A cleaner path through digital glades 🌈
Farewell, feature flags, your time is through! 💻

Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

app/client/src/pages/Editor/IDE/EditorPane/Query/QueryRender.test.tsx (1)

437-437: Fix inconsistent formatting of sagasToRun property.

The sagasToRun property has inconsistent formatting in the render options object. Consider aligning it with other properties.

-
-          sagasToRun: sagasToRunForTests,
+          sagasToRun: sagasToRunForTests,

Also applies to: 632-632

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3e259b8 and eb71398.

📒 Files selected for processing (13)

• app/client/cypress/support/Objects/FeatureFlags.ts (0 hunks)
• app/client/src/IDE/hooks/useIsInSideBySideEditor.test.tsx (0 hunks)
• app/client/src/ce/entities/FeatureFlag.ts (0 hunks)
• app/client/src/components/editorComponents/PartialImportExport/PartialExportModal/unitTestUtils.ts (0 hunks)
• app/client/src/pages/Editor/IDE/EditorPane/JS/JSRender.test.tsx (0 hunks)
• app/client/src/pages/Editor/IDE/EditorPane/Query/QueryRender.test.tsx (2 hunks)
• app/client/src/pages/Editor/IDE/EditorPane/UI/UIRender.test.tsx (0 hunks)
• app/client/src/pages/Editor/IDE/EditorPane/components/SegmentAddHeader.tsx (1 hunks)
• app/client/src/pages/Editor/IDE/EditorTabs/Editortabs.test.tsx (0 hunks)
• app/client/src/pages/Editor/IDE/EditorTabs/index.tsx (1 hunks)
• app/client/src/sagas/ActionSagas.ts (1 hunks)
• app/client/src/sagas/JSPaneSagas.ts (1 hunks)
• app/client/src/selectors/ideSelectors.tsx (1 hunks)

🔥 Files not summarized due to errors (1)

• app/client/src/components/editorComponents/PartialImportExport/PartialExportModal/unitTestUtils.ts: Error: Server error: no LLM provider could handle the message

💤 Files with no reviewable changes (7)

• app/client/src/components/editorComponents/PartialImportExport/PartialExportModal/unitTestUtils.ts
• app/client/src/pages/Editor/IDE/EditorPane/JS/JSRender.test.tsx
• app/client/cypress/support/Objects/FeatureFlags.ts
• app/client/src/IDE/hooks/useIsInSideBySideEditor.test.tsx
• app/client/src/pages/Editor/IDE/EditorPane/UI/UIRender.test.tsx
• app/client/src/pages/Editor/IDE/EditorTabs/Editortabs.test.tsx
• app/client/src/ce/entities/FeatureFlag.ts

⏰ Context from checks skipped due to timeout of 90000ms (8)

• GitHub Check: perform-test / rts-build / build
• GitHub Check: perform-test / server-build / server-unit-tests
• GitHub Check: perform-test / client-build / client-build
• GitHub Check: client-lint / client-lint
• GitHub Check: client-check-cyclic-deps / check-cyclic-dependencies
• GitHub Check: client-unit-tests / client-unit-tests
• GitHub Check: client-build / client-build
• GitHub Check: client-prettier / prettier-check

🔇 Additional comments (6)

app/client/src/pages/Editor/IDE/EditorPane/components/SegmentAddHeader.tsx (1)

2-2: Clean and simplified component structure.

The removal of feature flag checks has made the component more maintainable with static styling.

Also applies to: 14-14

app/client/src/selectors/ideSelectors.tsx (1)

9-9: Simplified selector implementation.

Direct state access improves performance by removing unnecessary feature flag checks.

app/client/src/pages/Editor/IDE/EditorTabs/index.tsx (1)

4-4: Streamlined component rendering logic.

Direct view mode checks improve code clarity and maintainability by removing feature flag complexity.

app/client/src/pages/Editor/IDE/EditorPane/Query/QueryRender.test.tsx (1)

Line range hint 1-724: Well-structured test cases with simplified setup.

The removal of feature flag checks has made the test cases more focused and easier to maintain.

app/client/src/sagas/JSPaneSagas.ts (1)

868-868: LGTM! Simplified the code by making split screen mode unconditional.

The change aligns with making the Split screen feature GA by removing the feature flag check.

app/client/src/sagas/ActionSagas.ts (1)

1198-1198: LGTM! Consistent with the changes in JSPaneSagas.ts.

The change aligns with making the Split screen feature GA by removing the feature flag check.