16/01 Daily Promotion by kamakshibhat-appsmith · Pull Request #38689 · appsmithorg/appsmith

kamakshibhat-appsmith · 2025-01-16T07:46:57Z

Description

Tip

Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).

Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.

Fixes #Issue Number
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags=""

🔍 Cypress test results

Caution

If you modify the content in this section, you are likely to disrupt the CI result for your PR.

Communication

Should the DevRel and Marketing teams inform users about this change?

Yes
No

## Description This PR adds focus ring for CTA's in the platform. Fixes #37699 ## Automation /ok-to-test tags="@tag.Sanity" ### 🔍 Cypress test results  > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/12742601686> > Commit: 2597087 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12742601686&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` > Spec: > <hr>Mon, 13 Jan 2025 08:19:28 UTC  ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No  ## Summary by CodeRabbit - **New Features** - Enhanced focus state styling for the select component, improving visibility when active. - Updated focus management for buttons, inputs, and various components to utilize `:focus-visible`, enhancing accessibility. - Refined keyboard navigation and interaction logic for the color picker component. - Introduced new props for conditional focus styling in the editor and button components. - Added support for AI assistance features in the code editor. - Improved focus ring visibility in the segmented control and switch components. - **Bug Fixes** - Improved accessibility and visual clarity of focus outlines across the application. - **Chores** - Removed outdated focus outline rules, allowing for a more streamlined styling approach.

## Description We have identified that the mock database is accessible to multiple stakeholders, increasing the risk of data corruption. To address this, we have commented out unnecessary and potentially flaky test code to ensure stability and reliability. Fixes # https://app.zenhub.com/workspaces/qa-63316faf86bb2e170ed2e46b/issues/gh/appsmithorg/appsmith/38602 ## Automation /ok-to-test tags="@tag.Datasource" ### 🔍 Cypress test results  > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/12743407394> > Commit: f74f769 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12743407394&attempt=2" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Datasource` > Spec: > <hr>Mon, 13 Jan 2025 09:51:58 UTC  ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No  ## Summary by CodeRabbit - **Tests** - Modified Cypress test for Mock Databases by removing specific query count and response verification assertions.

## Description Skipping case due to : #38156 Fixes # #38156 ## Automation /ok-to-test tags="@tag.Settings" ### 🔍 Cypress test results  > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/12746823242> > Commit: ac771ea > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12746823242&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Settings` > Spec: > <hr>Mon, 13 Jan 2025 12:31:16 UTC  ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No  ## Summary by CodeRabbit - **Tests** - Temporarily disabled a test suite for file upload testing - Skipped test suite due to known issue

…nd data side pane with new ADS component (#38621) ## Description Replacing the entity group list component on state inspector and data side pane with new ADS component Fixes [#38290](#38290) ## Automation /ok-to-test tags="@tag.Datasource" ### 🔍 Cypress test results  > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/12763738469> > Commit: a4b7172 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12763738469&attempt=2" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Datasource` > Spec: > <hr>Tue, 14 Jan 2025 09:50:48 UTC  ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No  ## Summary by CodeRabbit ## Release Notes - **New Features** - Enhanced list item styling with configurable height. - Added support for dynamic item count in entity groups. - Improved icon rendering with customizable dimensions. - Introduced a new constant for default group list size. - **Improvements** - Simplified rendering of grouped items in various components. - Refined type safety for boolean assignments. - Updated state management for entity groups. - Enhanced control over item visibility in modals and lists. - **Technical Updates** - Introduced new data attributes for enhanced component interactions. - Modernized component rendering logic. - Replaced custom styled list with a dedicated `EntityGroupsList` component for better maintainability. - Expanded story examples for the `ListItem` component to showcase various configurations.

## Description - Adds `isInitialized` state for git components - Adds message to autocommit progressbar - Adds proper loading state for merge dropdown Fixes #38593 Fixes #38594 ## Automation /ok-to-test tags="@tag.Git" ### 🔍 Cypress test results  > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/12753560383> > Commit: bd7a581 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12753560383&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Git` > Spec: > <hr>Mon, 13 Jan 2025 19:21:01 UTC  ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No  ## Summary by CodeRabbit - **New Features** - Added initialization tracking for Git-related components. - Enhanced Git editor initialization state management. - Introduced new selectors for retrieving Git artifact initialization states. - **Bug Fixes** - Improved conditional rendering for Git quick actions. - Updated merge status tracking and display logic. - **Refactor** - Introduced new hooks for Git artifact initialization. - Updated state management for Git-related UI components.

## Description Fixes flakiness for merge via remote spec ## Automation /ok-to-test tags="@tag.Git" ### 🔍 Cypress test results  > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/12765495211> > Commit: 7f83e90 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12765495211&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Git` > Spec: > <hr>Tue, 14 Jan 2025 11:18:09 UTC  ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No  ## Summary by CodeRabbit - **Tests** - Updated Git synchronization test suite for merging changes - Modified test file to streamline page creation and merging process - Added new test path for Anvil Widgets tests - Removed commented test file path and related comment

## Description Fix : https://theappsmith.slack.com/archives/CGBPVEJ5C/p1736920490455829 Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Settings" ### 🔍 Cypress test results  > [!CAUTION] > If you modify the content in this section, you are likely to disrupt the CI result for your PR.  ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No  ## Summary by CodeRabbit - **Chores** - Updated Docker image build workflow to improve error handling when removing Docker images.

## Description > [!TIP] > _Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team)._ > > _Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR._ Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.Settings" ### 🔍 Cypress test results  > [!WARNING] > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/12783144157> > Commit: 0a2d970 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12783144157&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: @tag.Settings > Spec: > It seems like **no tests ran** 😔. We are not able to recognize it, please check <a href="https://github.com/appsmithorg/appsmith/actions/runs/12783144157" target="_blank">workflow here</a>. > <hr>Wed, 15 Jan 2025 07:01:28 UTC  ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No  ## Summary by CodeRabbit - **Documentation** - Updated description for PR number input parameter in GitHub Actions workflow configuration

## Description Minor improvement. Fixes # https://app.zenhub.com/workspaces/qa-63316faf86bb2e170ed2e46b/issues/gh/appsmithorg/appsmith/38320 ## Automation /ok-to-test tags="@tag.Settings" ### 🔍 Cypress test results  > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/12745102566> > Commit: 6fd0683 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12745102566&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Settings` > Spec: > <hr>Mon, 13 Jan 2025 10:43:28 UTC  ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No  ## Summary by CodeRabbit - **Tests** - Enhanced Cypress end-to-end tests for Admin settings page - Added improved loading state and document readiness assertions - Increased test robustness by ensuring stable application state before interactions

coderabbitai · 2025-01-16T07:47:04Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (2)

pg
release

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

RakshaKShetty

Approved

albinAppsmith and others added 19 commits January 13, 2025 14:43

chore: [ADS] Entity Tree Hover interactions (#38615)

bfd66e5

fix: Issue with Api Body content type selection (#38597)

a7f7d3f

Revert "feat: Added focus ring for focus visible (#37700)" (#38650)

e1b3b0d

fix: [ADS] Entity Tree node overflow (#38651)

d5551aa

chore: Move IDE Sidebar into ADS (#38641)

357664f

fix: Separate Plugin Entity from Action (#38582)

a23bcbf

chore: Fix theme CE change only in EE (#38657)

329c797

chore: Update mixpanel masking classname (#38661)

446eb2b

fix: copy changes to the description and content of modal (#38637)

b496e4a

fix: AI query not showing any bottom tabs (#38687)

2b8ba77

kamakshibhat-appsmith requested a review from RakshaKShetty January 16, 2025 07:46

kamakshibhat-appsmith requested review from a team, ApekshaBhosale, ayushpahwa, sagar-qa007 and sharat87 as code owners January 16, 2025 07:46

kamakshibhat-appsmith requested a review from a team January 16, 2025 07:46

kamakshibhat-appsmith requested a review from a team as a code owner January 16, 2025 07:46

kamakshibhat-appsmith requested review from AnaghHegde and removed request for a team January 16, 2025 07:46

RakshaKShetty approved these changes Jan 16, 2025

View reviewed changes

btsgh merged commit 2eb168f into master Jan 16, 2025
18 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

16/01 Daily Promotion#38689

16/01 Daily Promotion#38689
btsgh merged 19 commits intomasterfrom
release

kamakshibhat-appsmith commented Jan 16, 2025

Uh oh!

coderabbitai bot commented Jan 16, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

RakshaKShetty left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

kamakshibhat-appsmith commented Jan 16, 2025

Description

Automation

🔍 Cypress test results

Communication

Uh oh!

coderabbitai bot commented Jan 16, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

RakshaKShetty left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants