Skip to content

chore: Fix theme CE change only in EE#38657

Merged
hetunandu merged 3 commits intoreleasefrom
chore/avoid-merge-issue
Jan 15, 2025
Merged

chore: Fix theme CE change only in EE#38657
hetunandu merged 3 commits intoreleasefrom
chore/avoid-merge-issue

Conversation

@hetunandu
Copy link
Member

@hetunandu hetunandu commented Jan 15, 2025

Description

While working on https://github.com/appsmithorg/appsmith-ee/pull/5914 saw that this certain CE change was only applied in EE. This PR makes sure the file in both repo is consistent

Automation

/ok-to-test tags="@tag.Sanity"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/12784507851
Commit: 89ff9b8
Cypress dashboard.
Tags: @tag.Sanity
Spec:


Wed, 15 Jan 2025 09:20:04 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

  • Refactor
    • Updated import statements in the useTheme hook to use explicit imports for theming-related hooks
    • Improved code clarity by specifying individual hook sources

@hetunandu hetunandu requested a review from dvj1988 January 15, 2025 06:07
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 15, 2025

Walkthrough

The pull request involves refactoring import statements in the useTheme.tsx file within the design system's theming package. The changes replace a wildcard import with explicit, individual imports for various theme-related hooks. This modification improves import clarity by directly specifying the source of each imported hook, while maintaining the existing functional implementation of the useTheme hook.

Changes

File Change Summary
app/client/packages/design-system/theming/src/hooks/src/useTheme.tsx Replaced wildcard import import { ... } from "./" with explicit individual imports for useSizing, useSpacing, useTypography, useIconSizing, and useIconDensity

Suggested Labels

skip-changelog, ok-to-test

Suggested Reviewers

  • sharat87

Poem

🎨 Imports dancing, clear and bright
No more wildcards hiding from sight
Each hook now speaks its true name
Clarity becomes the coding game
Refactoring with elegant might! 🧩


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a23bcbf and 54670bc.

📒 Files selected for processing (1)
  • app/client/packages/design-system/theming/src/hooks/src/useTheme.tsx (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (10)
  • GitHub Check: perform-test / rts-build / build
  • GitHub Check: perform-test / client-build / client-build
  • GitHub Check: perform-test / server-build / server-unit-tests
  • GitHub Check: client-unit-tests / client-unit-tests
  • GitHub Check: client-lint / client-lint
  • GitHub Check: client-build / client-build
  • GitHub Check: client-prettier / prettier-check
  • GitHub Check: chromatic-deployment
  • GitHub Check: chromatic-deployment
  • GitHub Check: storybook-tests
🔇 Additional comments (1)
app/client/packages/design-system/theming/src/hooks/src/useTheme.tsx (1)

7-11: LGTM! Clean import refactoring.

The explicit imports improve code clarity and make dependencies more traceable. This change aligns with best practices for module imports while maintaining the same functionality.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label Jan 15, 2025
@hetunandu hetunandu added the ok-to-test Required label for CI label Jan 15, 2025
@hetunandu hetunandu enabled auto-merge (squash) January 15, 2025 06:11
@hetunandu hetunandu merged commit 329c797 into release Jan 15, 2025
@hetunandu hetunandu deleted the chore/avoid-merge-issue branch January 15, 2025 09:20
github-actions bot pushed a commit to Zeral-Zhang/appsmith that referenced this pull request Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Required label for CI skip-changelog Adding this label to a PR prevents it from being listed in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants