Conversation
WalkthroughThis pull request focuses on enhancing the Oracle data source test suite in Cypress. The changes involve updating the test structure, improving SQL query formatting, and simplifying deployment logic. A new Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
app/client/cypress/e2e/Regression/ServerSide/Datasources/Oracle_Spec.ts (3)
151-161: Check labeling consistency in source data
Using properties"name","value","code"can be confusing if not standardized. Confirm uniform usage across the code for clarity.
345-349: Consider using data- attributes for deployment actions*
While the code callsdeployMode.DeployApp()and other methods, any reliance on plain text for buttons like "Submit" might be more robust if replaced by data-based locators.
482-492: Confirmation flow
Properly tests the confirmation dialog with “No” response. Consider referencing a data attribute for the button to avoid plain text usage.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
app/client/cypress/e2e/Regression/ServerSide/Datasources/Oracle_Spec.ts(10 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
app/client/cypress/e2e/Regression/ServerSide/Datasources/Oracle_Spec.ts (1)
Pattern app/client/cypress/**/**.*: Review the following e2e test code written using the Cypress test library. Ensure that:
- Follow best practices for Cypress code and e2e automation.
- Avoid using cy.wait in code.
- Avoid using cy.pause in code.
- Avoid using agHelper.sleep().
- Use locator variables for locators and do not use plain strings.
- Use data-* attributes for selectors.
- Avoid Xpaths, Attributes and CSS path.
- Avoid selectors like .btn.submit or button[type=submit].
- Perform logins via API with LoginFromAPI.
- Perform logout via API with LogOutviaAPI.
- Perform signup via API with SignupFromAPI.
- Avoid using it.only.
- Avoid using after and aftereach in test cases.
- Use multiple assertions for expect statements.
- Avoid using strings for assertions.
- Do not use duplicate filenames even with different paths.
- Avoid using agHelper.Sleep, this.Sleep in any file in code.
🔇 Additional comments (8)
app/client/cypress/e2e/Regression/ServerSide/Datasources/Oracle_Spec.ts (8)
22-23: New import for PluginActionForm is appropriate
This import clearly complements the subsequent usage of PluginActionForm.
24-24: Initialize the form instance consistently
The variable name pluginActionForm seems clear. Ensure naming consistency across the codebase if similar patterns exist.
189-199: Table creation logic looks correct
Everything appears valid for the test scenario. No immediate issues identified.
250-274: Multi-line insert statements
They align well with Oracle syntax and appear consistent with the test approach.
369-380: Conditional UPDATE suits the test
No syntax issues found. Good job demonstrating distinct conditions.
390-395: Re-deploy approach
Refreshing the page before redeployment can be beneficial for stability. No concerns here.
Line range hint 409-438: DELETE query looks comprehensive
The multi-condition WHERE clause and subsequent validation steps are appropriate for the test scenario.
470-477: Toggling settings and removing on-page load run
This follows Cypress best practices. Good job disabling unnecessary auto-runs that can complicate testing.
## Description Issue with oracle spec in hosted version of ci. Fixes # https://app.zenhub.com/workspaces/stability-pod-6690c4814e31602e25cab7fd/issues/gh/appsmithorg/appsmith/38434 Success RUN: https://internal.appsmith.com/app/cypress-dashboard/all-runs-65890b3c81d7400d08fa9ede?branch=master ## Automation /ok-to-test tags="@tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/12566791033> > Commit: 3283b4d > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12566791033&attempt=2" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` > Spec: > <hr>Wed, 01 Jan 2025 07:26:18 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Tests** - Enhanced Oracle data source test suite with improved query validation - Refined SQL query formatting and test case structure - Simplified application deployment process in test scenarios <!-- end of auto-generated comment: release notes by coderabbit.ai -->
2 participants
Description
Issue with oracle spec in hosted version of ci.
Fixes # https://app.zenhub.com/workspaces/stability-pod-6690c4814e31602e25cab7fd/issues/gh/appsmithorg/appsmith/38434
Success RUN: https://internal.appsmith.com/app/cypress-dashboard/all-runs-65890b3c81d7400d08fa9ede?branch=master
Automation
/ok-to-test tags="@tag.Sanity"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/12566791033
Commit: 3283b4d
Cypress dashboard.
Tags:
@tag.SanitySpec:
Wed, 01 Jan 2025 07:26:18 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit