fix: Airgap case handle

[sagar-qa007]

Description

Exclusion for airgap.

Fixes # https://app.zenhub.com/workspaces/stability-pod-6690c4814e31602e25cab7fd/issues/gh/appsmithorg/appsmith/38412

Automation

/ok-to-test tags="@tag.Sanity,@tag.Settings"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/12545684013
Commit: 591f14d
Cypress dashboard.
Tags: @tag.Sanity,@tag.Settings
Spec:

---

Mon, 30 Dec 2024 11:54:12 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

• Yes
• No

Summary by CodeRabbit

• Tests
  • Updated Cypress test for Admin Settings page
  • Added exclusion tag for airgap environments
  • Refactored test case syntax

[coderabbitai]

Walkthrough

The pull request introduces modifications to a Cypress end-to-end test for the Admin Settings page. The primary change involves adding a new tag @tag.excludeForAirgap to a specific test case, which indicates that this test should be skipped in airgap environments. The test case was also refactored to use arrow function syntax, though the core testing logic remains unchanged.

Changes

File	Change Summary
app/client/cypress/e2e/Regression/ClientSide/AdminSettings/Admin_settings_spec.ts	Added @tag.excludeForAirgap tag to test case Refactored test case to use arrow function syntax

Suggested labels

Bug, ok-to-test, Test

Suggested reviewers

• ApekshaBhosale
• NandanAnantharamu

Possibly related PRs

• test: Admin setting test cases #38172: Enhances Cypress end-to-end tests for the Admin Settings page, directly related to the current modifications

Poem

🧪 In Cypress realm, a test takes flight
Tagged for airgap, out of sight
Arrow functions dance with grace
Refactoring leaves no trace
Testing magic, clean and bright! 🚀

Tip

CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command @coderabbitai generate docstrings to have CodeRabbit automatically generate docstrings for your pull request. We would love to hear your feedback on Discord.

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 692e394 and 591f14d.

📒 Files selected for processing (1)

• app/client/cypress/e2e/Regression/ClientSide/AdminSettings/Admin_settings_spec.ts (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

app/client/cypress/e2e/Regression/ClientSide/AdminSettings/Admin_settings_spec.ts (1)

Pattern app/client/cypress/**/**.*: Review the following e2e test code written using the Cypress test library. Ensure that:

• Follow best practices for Cypress code and e2e automation.
• Avoid using cy.wait in code.
• Avoid using cy.pause in code.
• Avoid using agHelper.sleep().
• Use locator variables for locators and do not use plain strings.
• Use data-* attributes for selectors.
• Avoid Xpaths, Attributes and CSS path.
• Avoid selectors like .btn.submit or button[type=submit].
• Perform logins via API with LoginFromAPI.
• Perform logout via API with LogOutviaAPI.
• Perform signup via API with SignupFromAPI.
• Avoid using it.only.
• Avoid using after and aftereach in test cases.
• Use multiple assertions for expect statements.
• Avoid using strings for assertions.
• Do not use duplicate filenames even with different paths.
• Avoid using agHelper.Sleep, this.Sleep in any file in code.

🔇 Additional comments (1)

app/client/cypress/e2e/Regression/ClientSide/AdminSettings/Admin_settings_spec.ts (1)

209-237: Looks good!

The introduction of the @tag.excludeForAirgap tag aligns with our test organization guidelines, allowing selective test execution in non-airgap environments. The function uses locator variables for selecting elements, and follows Cypress best practices for intercepting network requests.

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[NandanAnantharamu]

Lgtm