25/11 - Daily promotion by shadabbuchh · Pull Request #37669 · appsmithorg/appsmith

shadabbuchh · 2024-11-25T06:23:24Z

Description

Tip

Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).

Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.

Fixes #Issue Number
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags=""

🔍 Cypress test results

Caution

If you modify the content in this section, you are likely to disrupt the CI result for your PR.

Communication

Should the DevRel and Marketing teams inform users about this change?

Yes
No

## Description We are shifting the linter engine for jshint to eslint. This PR adds the package needed for the same and also adds the required configs. The eslint feature is behing a rollout feature flag, it's currently at 0% right now. > [!NOTE] > This PR is part of a series of [stacked diffs](https://newsletter.pragmaticengineer.com/p/stacked-diffs) and might have changes from it's parent PRs. Untill the blocking parent PRs are merged, this diff would show more changes than are relevant for this PR. Blocking PRs: - #36548 Fixes #37254 ## Automation /test js sanity ### 🔍 Cypress test results  > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/11965021215> > Commit: 579e477 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11965021215&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.JS, @tag.Sanity` > Spec: > <hr>Fri, 22 Nov 2024 02:49:47 UTC  ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No  ## Summary by CodeRabbit ## Release Notes - **New Features** - Integrated ESLint support alongside existing JSHint functionality for enhanced linting capabilities. - Added a new dependency for ESLint linting. - **Improvements** - Enhanced error handling and reporting for linting errors, ensuring consistency across different linting tools. - Updated testing framework to accommodate multiple linter types without duplicating logic. - Introduced new functions for sanitizing and converting ESLint errors to the application's format. - Added support for structured cloning in the testing setup. - Improved logic for determining main actions and error handling in conditional expressions. - **Bug Fixes** - Improved logic for handling lint errors, particularly in differentiating between ESLint and JSHint errors. - **Documentation** - Updated comments for clarity on linting processes and configurations.

Added daterpicker component along with other components needed for it like Calendar andTimeField Datepicker ![CleanShot 2024-11-21 at 12 38 20@2x](https://github.com/user-attachments/assets/334cdbb9-10f8-442a-93d8-c62b83668972) Calendar ![CleanShot 2024-11-21 at 12 38 54@2x](https://github.com/user-attachments/assets/6123a842-5c32-48f1-86f9-56ffe249fedf) Timefield ![CleanShot 2024-11-21 at 12 41 56@2x](https://github.com/user-attachments/assets/b9b2dc3c-91fd-4b90-99f4-461685be7b37) /ok-to-test tags="@tag.Anvil"  ## Summary by CodeRabbit ## Release Notes - **New Features** - Introduced a `Calendar` component for date selection and display. - Added a `DatePicker` component for selecting dates and times with enhanced error handling. - Launched a `TimeField` component for time input with optional prefix and suffix. - Updated `TextField` component replacing the previous `TextInput` for improved usability. - **Bug Fixes** - Enhanced styling and responsiveness of input components. - **Documentation** - Added Storybook stories for `Calendar`, `DatePicker`, and `TimeField` components to showcase functionalities and configurations. - **Chores** - Refactored imports to utilize the new `TextField` component across various widgets.   > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/11970103158> > Commit: a1a552c > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11970103158&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Anvil` > Spec: > <hr>Fri, 22 Nov 2024 10:01:23 UTC

Fix linting exceptions in `ctl`. ## Automation /test sanity ### 🔍 Cypress test results  > [!WARNING] > Tests have not run on the HEAD 1f2242a yet > <hr>Fri, 22 Nov 2024 10:06:23 UTC  ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No  ## Summary by CodeRabbit ## Release Notes - **New Features** - Enhanced backup and restore processes with improved user prompts and error handling. - Added support for optional command-line flags during database imports. - **Bug Fixes** - Improved error handling for various operations, including database exports and imports. - Enhanced logging for backup errors to provide more context. - **Documentation** - Updated user prompts and error messages for clarity during backup and restore operations. - **Tests** - Expanded test coverage for backup functionalities and utility functions to ensure robust error handling and output validation. - **Chores** - Updated dependencies to enhance TypeScript development experience.

## Description Updates Plugin Action Editor to defer the plugin check till needed. This ensures the usage of Plugin Action Context in scenarios the config is not needed. Eg: If we want to show Plugin Action Response in App View Mode but not the form, we can still use the Plugin Action Editor with its context. ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results  > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/11973235246> > Commit: 88d7be1 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11973235246&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Fri, 22 Nov 2024 14:25:16 UTC  ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No  ## Summary by CodeRabbit ## Release Notes - **New Features** - Enhanced error message presentation with centered layout in various components. - Improved rendering logic for form configurations, ensuring clearer separation based on type. - **Bug Fixes** - Simplified error handling in the `PluginActionEditor` component, removing unnecessary error checks. - Updated error handling in the `ActionSettings` component to improve message display. - **Documentation** - Updated error handling and rendering logic for better user experience.

Loading env variables at import time doesn't work now since we're importing first, and them loading env variables, after having moved to TypeScript. This PR fixes that in the mailer module. ## Automation /test sanity ### 🔍 Cypress test results  > [!CAUTION] > If you modify the content in this section, you are likely to disrupt the CI result for your PR.  ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No  ## Summary by CodeRabbit - **Bug Fixes** - Improved error handling for email configuration by ensuring environment variables are validated before sending emails. - **Refactor** - Adjusted the scope of several environment variables to enhance code organization and maintainability.

These packages were installed in daf60fa for use with the `appsmithctl migrate` command, which has never been documented, been deprecated and then deleted from code for some time now. Removing these packages now as we don't need them any longer. Tested on EE and verified `/test all` to have passed. ## Automation /test sanity ### 🔍 Cypress test results  > [!CAUTION] > If you modify the content in this section, you are likely to disrupt the CI result for your PR.  ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No  ## Summary by CodeRabbit - **New Features** - Updated the base image to `ubuntu:20.04` for improved compatibility. - Introduced a new builder stage for Caddy with the `caddy-ratelimit` module. - Enhanced support for internationalization by setting environment variables for language and locale. - **Improvements** - Streamlined package installation process by removing unnecessary packages. - Optimized the final image size with cleanup commands and maintained essential database services.

## Automation /test sanity ### 🔍 Cypress test results  > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/11987511676> > Commit: 22f0a6f > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11987511676&attempt=2" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` > Spec: > <hr>Sat, 23 Nov 2024 14:45:28 UTC  ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No  ## Summary by CodeRabbit ## Release Notes - **Chores** - Removed Algolia Search configuration from various files, including environment variables and configuration scripts. - **Refactor** - Simplified search-related components and utility functions by removing Algolia dependencies, enhancing clarity and usability. - **Bug Fixes** - Adjusted search item type handling to improve type safety and reduce complexity. These updates streamline the application by eliminating unnecessary dependencies and refining existing functionalities.

Now that we've moved to TypeScript, this PR fixes missing type annotations in `backup.ts` and `restore.ts`. ## Automation /test sanity ### 🔍 Cypress test results  > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/11988138792> > Commit: 5770dd0 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11988138792&attempt=2" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` > Spec: > <hr>Sun, 24 Nov 2024 01:02:33 UTC  ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No  ## Summary by CodeRabbit - **New Features** - Enhanced error handling for password mismatches during backup encryption. - Improved test coverage for backup functionality, including backup paths and disk space validation. - **Bug Fixes** - Refined backup cleanup logic to ensure proper file retention and removal. - **Refactor** - Introduced a new `BackupState` class to manage backup process state. - Streamlined password handling and improved code structure for better readability. - Updated type safety for several functions in the backup and restore processes. - Simplified exit process in error handling for restore functionality.

Adding our Youtube link shield to our readme so users can easily subscribe from Github. ## Description > [!TIP] > _Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team)._ > Per recommendation from Abhishek and as a best practice to drive developers to our Youtube account for learning purposes, we are adding the youtube badge shield to the README to showcase the amount of views from our channel and subscribe directly using the link Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="" ### 🔍 Cypress test results  > [!WARNING] > Tests have not run on the HEAD 4ab34c0 yet > <hr>Mon, 14 Oct 2024 20:27:52 UTC  ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No  ## Summary by CodeRabbit - **New Features** - Added new badges to the README for the Appsmith YouTube channel, showcasing subscriber count and total views. - **Documentation** - Enhanced visibility of the YouTube channel within the README without altering existing content structure.

We don't use `wget`, just `curl` in all places. Tested with full suite on EE. ## Automation /test sanity ### 🔍 Cypress test results  > [!CAUTION] > If you modify the content in this section, you are likely to disrupt the CI result for your PR.  ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No  ## Summary by CodeRabbit - **Chores** - Updated PostgreSQL version from 13 to 14 in the installation process. - Removed `wget` from the package installation command, streamlining the setup. - Retained language settings and environment variables for compatibility. - Maintained existing installation steps for Java and NodeJS, ensuring consistency.

coderabbitai · 2024-11-25T06:23:31Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (2)

pg
release

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

RakshaKShetty

Approved

Ayush Pahwa and others added 10 commits November 22, 2024 14:26

shadabbuchh requested a review from RakshaKShetty November 25, 2024 06:23

shadabbuchh requested review from KelvinOm, pratapaprasanna and sharat87 as code owners November 25, 2024 06:23

RakshaKShetty approved these changes Nov 25, 2024

View reviewed changes

yatinappsmith merged commit 9eb9e3d into master Nov 25, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

25/11 - Daily promotion#37669

25/11 - Daily promotion#37669
yatinappsmith merged 10 commits intomasterfrom
release

shadabbuchh commented Nov 25, 2024

Uh oh!

coderabbitai bot commented Nov 25, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

RakshaKShetty left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

shadabbuchh commented Nov 25, 2024

Description

Automation

🔍 Cypress test results

Communication

Uh oh!

coderabbitai bot commented Nov 25, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

RakshaKShetty left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants