chore: Remove Algolia, we don't use it anymore#37664
Conversation
WalkthroughThe changes in this pull request primarily involve the removal of Algolia Search-related configurations from various files. This includes environment variable declarations, Nginx configuration settings, Jest configuration, and references in the application code. The modifications suggest a significant shift in the application's dependency on Algolia, as related properties have been eliminated from multiple components, including the main configuration interfaces and utility functions. Changes
Suggested labels
Suggested reviewers
Warning Rate limit exceeded@sharat87 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 4 minutes and 24 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📜 Recent review detailsConfiguration used: .coderabbit.yaml ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (11)
💤 Files with no reviewable changes (10)
🔇 Additional comments (1)app/client/src/components/editorComponents/GlobalSearch/SearchResults.tsx (1)
The simplified type definition improves type safety by removing the unused Algolia IHit type. Let's verify complete removal of Algolia dependencies: ✅ Verification successfulType simplification looks good - no remaining Algolia dependencies found The removal of 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Check for any remaining Algolia references
# Look for Algolia-related imports, types, or configurations
# Search for any remaining Algolia references in TypeScript/JavaScript files
rg -i "algolia|IHit" --type ts --type js
# Search for Algolia in package.json dependencies
rg -i "algolia" package.json
# Look for any Algolia environment variables
rg -i "algolia" .env* docker*
Length of output: 11991 Script: #!/bin/bash
# Let's verify Algolia removal more thoroughly
# Check for Algolia-related imports and types in TypeScript files
ast-grep --pattern 'import $_ from "@algolia/$_"'
# Check for Algolia-related types and interfaces
ast-grep --pattern 'interface $_ extends IHit'
# Check for any remaining Algolia configuration or usage
rg -i "algolia" --type ts --type js -g '!*.test.*' -g '!*fixtures*' -g '!*mock*'
# Check for Algolia-related dependencies in package.json files
fd package.json --exec rg -i "algolia" {}
Length of output: 131052 Script: #!/bin/bash
# Let's check for any remaining Algolia references in the codebase
# Focusing on the specific directory and related files
# Check for Algolia-related imports and usage in SearchResults.tsx and related files
rg -i "algolia|IHit" "app/client/src/components/editorComponents/GlobalSearch/" -A 2 -B 2
# Check for any Algolia-related types/interfaces in the types directory
rg -i "algolia|IHit" "app/client/src/types/"
# Look for any Algolia configuration in the GlobalSearch directory
rg -i "algolia" "app/client/src/components/editorComponents/GlobalSearch/" --type ts --type js
Length of output: 289 Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
github-actions
bot
added
the
skip-changelog
sharat87
requested review from
hetunandu,
mohanarpit,
rajatagrawal and
riodeuno
## Automation /test sanity ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/11987511676> > Commit: 22f0a6f > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11987511676&attempt=2" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` > Spec: > <hr>Sat, 23 Nov 2024 14:45:28 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Release Notes - **Chores** - Removed Algolia Search configuration from various files, including environment variables and configuration scripts. - **Refactor** - Simplified search-related components and utility functions by removing Algolia dependencies, enhancing clarity and usability. - **Bug Fixes** - Adjusted search item type handling to improve type safety and reduce complexity. These updates streamline the application by eliminating unnecessary dependencies and refining existing functionalities. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
2 participants
Automation
/test sanity
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/11987511676
Commit: 22f0a6f
Cypress dashboard.
Tags:
@tag.SanitySpec:
Sat, 23 Nov 2024 14:45:28 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit
Release Notes
Chores
Refactor
Bug Fixes
These updates streamline the application by eliminating unnecessary dependencies and refining existing functionalities.