25/10 Daily Promotion by btsgh · Pull Request #37082 · appsmithorg/appsmith

btsgh · 2024-10-25T05:58:21Z

Description

Tip

Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).

Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.

Fixes #Issue Number
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags=""

🔍 Cypress test results

Caution

If you modify the content in this section, you are likely to disrupt the CI result for your PR.

Communication

Should the DevRel and Marketing teams inform users about this change?

Yes
No

## Description > This PR removes the extra metrics that were added which clouded up the newrelic. Old PR #37010 is to be closed because extra indentation was added due to the IDE configuration. Fixes #37051 ## Automation /ok-to-test tags="@tag.Sanity" ### 🔍 Cypress test results  > [!IMPORTANT] > 🟣 🟣 🟣 Your tests are running. > Tests running at: <https://github.com/appsmithorg/appsmith/actions/runs/11493693400> > Commit: 51ecb28 > Workflow: `PR Automation test suite` > Tags: `@tag.Sanity` > Spec: `` > <hr>Thu, 24 Oct 2024 06:16:14 UTC  ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No

/ok-to-test tags="@tag.All" This PR updates the WidgetQueryGeneratorForm to only allow queries so that it looks like a query selector. This is needed for chat widget where the widget can only bind Appsmith AI queries. ![CleanShot 2024-10-23 at 12 30 32](https://github.com/user-attachments/assets/c1237435-3e9e-4cfd-8c2e-c762c76089bd) PS: The above image is an example where TableWidget had allowedDatasourcestypes as "Mysql" ( just for testing )  ## Summary by CodeRabbit ## Summary by CodeRabbit - **New Features** - Introduced a new dropdown variant "Connect to query" for improved datasource selection. - Enhanced handling of dynamic query options and datasource filtering based on context. - **Improvements** - Updated the Widget Query Generator Form to support new properties for better data management. - Improved control flow in dropdown options to ensure appropriate options are displayed based on the current context. - Enhanced the One Click Binding Control to utilize new properties for better interaction with the Widget Query Generator Form. - **Bug Fixes** - Refined logic for displaying datasource options, preventing unnecessary options from appearing.   > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/11493055126> > Commit: d6e322c > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11493055126&attempt=2" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Thu, 24 Oct 2024 06:53:37 UTC

## Description This PR refactors the action duplication saga and action calls to remove dependency on pageID. As far as CE code is concerned, this PR doesn't change any functionality for the end user. Those changes are done for workflows editor in EE. Fixes #36886 ## Automation /test all ### 🔍 Cypress test results  > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/11462274307> > Commit: 04dfbfb > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11462274307&attempt=2" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Tue, 22 Oct 2024 16:21:32 UTC  ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No  ## Summary by CodeRabbit - **New Features** - Introduced a new hook, `useHandleDuplicateClick`, enhancing action duplication functionality. - Added a new interface and function for generating destination ID information. - **Bug Fixes** - Updated action request structure to use `destinationEntityId` for consistency across components. - **Documentation** - Enhanced success message flexibility for action copy notifications. - **Tests** - Added unit tests for the `ActionEntityContextMenu` component to ensure proper functionality and rendering. - **Refactor** - Improved context menu handling based on entity types for better user experience.

…CESS action (#37013) ## Description `FETCH_FORM_CONFIG_SUCCESS` is part of the EVAL trigger action list and is used to trigger evaluation in other entities such as templates, packages, and modules. This was part of the pre-consolidated API implementation, where fetching form configurations was a separate API call, and we needed to re-trigger the evaluation once the form configurations were fetched. With the consolidated API now including form configurations, there is no longer a need to re-trigger evaluation upon the dispatch of the `FETCH_FORM_CONFIG_SUCCESS` action. This change ensures that `FETCH_ALL_PAGE_ENTITY_COMPLETION` is dispatched after the `FETCH_FORM_CONFIG_SUCCESS` action. This update eliminates an unnecessary evaluation cycle during the initial page load. Fixes #`Issue Number` _or_ Fixes `Issue URL` > [!WARNING] > _If no issue exists, please create an issue first, and check with the maintainers if the issue is valid._ ## Automation /ok-to-test tags="@tag.All" ### 🔍 Cypress test results  > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/11473435022> > Commit: 23ec501 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11473435022&attempt=2" target="_blank">Cypress dashboard</a>. > Tags: `@tag.All` > Spec: > <hr>Wed, 23 Oct 2024 09:05:06 UTC  ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No  ## Summary by CodeRabbit - **New Features** - Improved loading process for plugins and datasources, now integrated within the page themes and actions loading. - **Bug Fixes** - Enhanced initialization sequence for the editor setup, ensuring timely server reset after setup completion.

## Description Adding new name editor for JS object in toolbar under modularised flow. Fixes [#36964](#36964) ## Automation /ok-to-test tags="@tag.Sanity, @tag.JS" ### 🔍 Cypress test results  > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/11496788011> > Commit: 7ae7ec7 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11496788011&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity, @tag.JS` > Spec: > <hr>Thu, 24 Oct 2024 10:42:17 UTC  ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No  ## Summary by CodeRabbit - **New Features** - Introduced a new optional name editor in the JSEditor, allowing users to edit JavaScript object names dynamically. - Enhanced the JSEditorToolbar to conditionally render the name editor based on user permissions. - **Bug Fixes** - Simplified the props for the JSObjectNameEditor component by removing unnecessary properties. - **Documentation** - Updated export statements to ensure accessibility of the new JSObjectNameEditor component across modules.

## Description We’ve often faced challenges in running server-specific tests efficiently for individual PRs. To streamline this process and improve testing speed, I’ve implemented the workflow dispatch feature, enabling quick and on-demand execution of server tests. Fixes #`37060` ## Automation /ok-to-test tags="@tag.IDE" ### 🔍 Cypress test results  > [!WARNING] > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/11497895741> > Commit: 48c3cd9 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=11497895741&attempt=6" target="_blank">Cypress dashboard</a>. > Tags: @tag.IDE > Spec: > It seems like **no tests ran** 😔. We are not able to recognize it, please check <a href="https://github.com/appsmithorg/appsmith/actions/runs/11497895741" target="_blank">workflow here</a>. > <hr>Fri, 25 Oct 2024 05:13:19 UTC  ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No

coderabbitai · 2024-10-25T05:58:28Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (2)

pg
release

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

kamakshibhat-appsmith

25/10 Approved

NilanshBansal and others added 6 commits October 24, 2024 06:48

btsgh requested a review from kamakshibhat-appsmith October 25, 2024 05:58

btsgh requested review from a team, ayushpahwa and sharat87 as code owners October 25, 2024 05:58

btsgh requested a review from a team October 25, 2024 05:58

kamakshibhat-appsmith approved these changes Oct 25, 2024

View reviewed changes

btsgh merged commit f170b92 into master Oct 25, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

25/10 Daily Promotion#37082

25/10 Daily Promotion#37082
btsgh merged 6 commits intomasterfrom
release

btsgh commented Oct 25, 2024

Uh oh!

coderabbitai bot commented Oct 25, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

kamakshibhat-appsmith left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

btsgh commented Oct 25, 2024

Description

Automation

🔍 Cypress test results

Communication

Uh oh!

coderabbitai bot commented Oct 25, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

kamakshibhat-appsmith left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants