Closed
Conversation
github-actions
bot
added
the
skip-changelog
NilanshBansal
requested changes
Oct 22, 2024
Contributor
There was a problem hiding this comment.
@rishabhrathod01 can you please check the reason for the large number of indentation changes in this PR? It is difficult to review the actual changes.
Contributor
Author
@NilanshBansal This was pushed after the spotless apply run, not sure why this indentation changes are showing up. There is no spotless config change too recently in the pom.xml. I will revert the changes and check in some time. |
NilanshBansal
approved these changes
Oct 22, 2024
2 tasks
Contributor
|
Closing this PR because changes are introduced in #37052 |
NilanshBansal
added a commit
that referenced
this pull request
Oct 24, 2024
## Description > This PR removes the extra metrics that were added which clouded up the newrelic. Old PR #37010 is to be closed because extra indentation was added due to the IDE configuration. Fixes #37051 ## Automation /ok-to-test tags="@tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!IMPORTANT] > 🟣 🟣 🟣 Your tests are running. > Tests running at: <https://github.com/appsmithorg/appsmith/actions/runs/11493693400> > Commit: 51ecb28 > Workflow: `PR Automation test suite` > Tags: `@tag.Sanity` > Spec: `` > <hr>Thu, 24 Oct 2024 06:16:14 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No
github-actions bot
pushed a commit
to Zeral-Zhang/appsmith
that referenced
this pull request
Nov 20, 2024
## Description > This PR removes the extra metrics that were added which clouded up the newrelic. Old PR appsmithorg#37010 is to be closed because extra indentation was added due to the IDE configuration. Fixes appsmithorg#37051 ## Automation /ok-to-test tags="@tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!IMPORTANT] > 🟣 🟣 🟣 Your tests are running. > Tests running at: <https://github.com/appsmithorg/appsmith/actions/runs/11493693400> > Commit: 51ecb28 > Workflow: `PR Automation test suite` > Tags: `@tag.Sanity` > Spec: `` > <hr>Thu, 24 Oct 2024 06:16:14 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the metrics that are overpopulating newRelic for the JS object update flow
Automation
/ok-to-test tags="@tag.Sanity"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/11463743078
Commit: 94bd147
Cypress dashboard.
Tags:
@tag.SanitySpec:
Wed, 23 Oct 2024 07:48:23 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?