Conversation
WalkthroughThe changes introduce a new output variable, Changes
Poem
Tip We have updated our review workflow to use the Anthropic's Claude family of models. Please share any feedback in the discussion post on our Discord. TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (2)
- .github/workflows/build-client-server-count.yml (3 hunks)
- .github/workflows/build-client-server.yml (3 hunks)
Additional comments not posted (5)
.github/workflows/build-client-server.yml (3)
17-17: Great job introducing theis-pg-buildoutput variable! 👍The
is-pg-buildoutput variable is correctly set based on the condition that checks if the base reference of the pull request is 'pg'. This will allow subsequent jobs to conditionally perform actions based on the pull request's context.
31-31: Excellent work setting theis-pg-buildoutput variable! 🌟The
is-pg-buildoutput variable is correctly set in theargsstep based on the condition that checks if the base reference of the pull request is 'pg'. This ensures that the variable is available for subsequent jobs to use.
97-97: Nicely done passing theis-pg-buildoutput variable to theserver-buildjob! 🙌By passing the
is-pg-buildoutput variable from thefile-checkjob to theserver-buildjob, you enable theserver-buildjob to conditionally perform actions based on the pull request's context. This enhances the flexibility and control flow of the build process..github/workflows/build-client-server-count.yml (2)
33-33: Great job adding theis-pg-buildoutput variable! 👍The code segment correctly sets the
is-pg-buildoutput variable based on the conditiongithub.event.client_payload.pull_request.base.ref == 'pg'. This variable can be used in subsequent jobs to conditionally manage the build process based on the pull request's context.
111-111: Excellent work passing theis-pg-buildvariable to theserver-buildjob! 🙌The code segment correctly passes the
is-pg-buildvariable as an input to theserver-buildjob. This allows theserver-buildjob to access the value of theis-pg-buildvariable and use it to conditionally manage the build process based on the pull request's context.
## Description Run the CI test limit in PG branch Fixes #`36085` ## Automation /ok-to-test tags="@tag.Sanity" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/10683137823> > Commit: 288bb1a > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=10683137823&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity` > Spec: > <hr>Tue, 03 Sep 2024 13:03:06 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **New Features** - Introduced a new output variable `is-pg-build` to enhance build handling based on pull request base branches. - Improved workflow logic to conditionally manage builds depending on the pull request context. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Description
Run the CI test limit in PG branch
Fixes #
36085Automation
/ok-to-test tags="@tag.Sanity"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10683137823
Commit: 288bb1a
Cypress dashboard.
Tags:
@tag.SanitySpec:
Tue, 03 Sep 2024 13:03:06 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit
is-pg-buildto enhance build handling based on pull request base branches.