Skip to content

ci: fix client build cache#38090

Merged
yatinappsmith merged 1 commit intoreleasefrom
ci/fix-client-push-cache
Dec 11, 2024
Merged

ci: fix client build cache#38090
yatinappsmith merged 1 commit intoreleasefrom
ci/fix-client-push-cache

Conversation

@yatinappsmith
Copy link
Contributor

@yatinappsmith yatinappsmith commented Dec 11, 2024

Description

fix client build cache

Fixes #Issue Number
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags=""

🔍 Cypress test results

Caution

If you modify the content in this section, you are likely to disrupt the CI result for your PR.

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

  • New Features

    • Introduced a new input parameter branch for specifying the build branch.
    • Added a step to create a tarball of the client build directory.
  • Improvements

    • Enhanced control flow for the client build workflow.
    • Updated logic for restoring previous run results and caching.
    • Refined checkout steps to handle various scenarios based on pull request presence.
  • Bug Fixes

    • Modified commit step to allow empty commits, ensuring workflow continuity.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 11, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request modifies the client build workflow configuration in .github/workflows/client-build.yml. Key changes include the addition of a branch input for specifying the build branch, a type change for skip-tests from boolean to string, and enhanced conditional checks for workflow execution. The workflow's checkout steps, caching logic, and build directory packaging have also been refined to improve state management and handle various event triggers effectively.

Changes

File Change Summary
.github/workflows/client-build.yml - Added branch input for specifying the build branch.
- Changed skip-tests type from boolean to string.
- Updated job conditions for running the workflow.
- Refined checkout steps for PR handling.
- Adjusted caching and restoring logic.
- Introduced step to create a tarball of the build directory.
- Enhanced logic for fetching builds from cache.
- Modified commit step to allow empty commits.
- Saved run status at the end of the workflow.

Possibly related PRs

  • CI : fix build cache #37712: This PR modifies the .github/workflows/client-build.yml file, similar to the main PR, by adding a branch input and changing the skip-tests input type, indicating a direct relationship in the workflow configuration changes.
  • chore: skipping file change #37774: This PR updates the .github/workflows/client-build.yml file, specifically modifying the logic for detecting file changes, which is relevant to the overall workflow changes in the main PR.
  • fix: Reverted changes for skip client cache #37782: This PR reverts changes in the .github/workflows/client-build.yml related to caching and file change detection, which connects to the modifications made in the main PR regarding the workflow's control flow and caching mechanisms.

Suggested labels

Performance infra, ok-to-test

Suggested reviewers

  • sharat87
  • sagar-qa007
  • yatinappsmith

🎉 In the workflow's dance, a new branch takes flight,
With tests now a string, it shines oh so bright!
Caching and restoring, all in perfect sync,
The build's now a tarball, quicker than you think!
So here's to the changes, let's give them a cheer,
For smoother builds ahead, the future is clear! 🎈


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 82c0773 and c0debc1.

📒 Files selected for processing (1)
  • .github/workflows/client-build.yml (1 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@yatinappsmith yatinappsmith merged commit a7bd7ac into release Dec 11, 2024
@yatinappsmith yatinappsmith deleted the ci/fix-client-push-cache branch December 11, 2024 06:06
@github-actions github-actions bot added skip-changelog Adding this label to a PR prevents it from being listed in the changelog CI labels Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI skip-changelog Adding this label to a PR prevents it from being listed in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants