Skip to content

chore: replace gson usage with jackson #35680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NilanshBansal merged 2 commits into from
Aug 15, 2024
Merged

chore: replace gson usage with jackson #35680

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3edb4a
replace gson usage with jackson
NilanshBansal Aug 14, 2024
599506d
added comment
NilanshBansal Aug 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 20 additions & 4 deletions ...-server/src/main/java/com/appsmith/server/solutions/ce/ActionExecutionSolutionCEImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@
import com.fasterxml.jackson.core.type.TypeReference;
import com.fasterxml.jackson.databind.JsonNode;
import com.fasterxml.jackson.databind.ObjectMapper;
import com.google.gson.Gson;
import io.micrometer.observation.ObservationRegistry;
import lombok.extern.slf4j.Slf4j;
import org.apache.commons.lang.ArrayUtils;
Expand Down Expand Up @@ -771,6 +770,25 @@ protected Function<? super Throwable, Mono<ActionExecutionResult>> executionExce
};
}

/**
* This function deep copies the actionConfiguration object to send the original object to mixpanel which contains
* the actual user query with bindings
* @param actionConfiguration
* @return
*/
private ActionConfiguration deepCopyActionConfiguration(ActionConfiguration actionConfiguration) {
try {
// Convert the ActionConfiguration object to JSON string
String json = objectMapper.writeValueAsString(actionConfiguration);

// Convert the JSON string back to an ActionConfiguration object
return objectMapper.readValue(json, ActionConfiguration.class);
} catch (JsonProcessingException e) {
e.printStackTrace();
}
return null;
}

/**
* Handles the execution logic, call to pluginExecutor with the payload post retrieval and validation of action, datasource, and plugin
*
Expand Down Expand Up @@ -799,9 +817,7 @@ protected Mono<ActionExecutionResult> getActionExecutionResult(
ActionConfiguration rawActionConfiguration = null;
if (actionDTO != null && actionDTO.getActionConfiguration() != null) {
// deep copying the actionConfiguration to avoid any changes in the original object
Gson gson = commonConfig.gsonInstance();
rawActionConfiguration = gson.fromJson(
gson.toJson(actionDTO.getActionConfiguration()), ActionConfiguration.class);
rawActionConfiguration = this.deepCopyActionConfiguration(actionDTO.getActionConfiguration());
}

log.debug(
Expand Down