chore: replace gson usage with jackson

[NilanshBansal]

Description

This PR replaces the gson usage for deepcopying actionConfiguration object with Jackson

Fixes #35696

Automation

/ok-to-test tags="@tag.Sanity"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10393746954
Commit: 599506d
Cypress dashboard.
Tags: @tag.Sanity
Spec:

---

Wed, 14 Aug 2024 19:45:36 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

• Yes
• No

Summary by CodeRabbit

• New Features
  • Introduced a method for deep copying ActionConfiguration objects, enhancing action execution reliability.
• Bug Fixes
  • Improved error handling during the deep copy process to maintain system stability.
• Refactor
  • Simplified the deep copying mechanism by removing the Gson dependency and utilizing Jackson's ObjectMapper for better code clarity and maintainability.

[coderabbitai]

Walkthrough

The recent changes to the ActionExecutionSolutionCEImpl class aim to simplify the deep copying of ActionConfiguration objects by replacing the Gson library with Jackson's ObjectMapper. A new method, deepCopyActionConfiguration, was introduced to handle serialization and deserialization in a more readable and maintainable way while ensuring that the original configurations remain untouched during processing.

Changes

File	Change Summary
.../ActionExecutionSolutionCEImpl.java	Added the deepCopyActionConfiguration method for deep copying ActionConfiguration using Jackson. Removed Gson dependency to streamline code and enhance readability. Added simple error handling for JSON processing errors.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant ActionExecutionSolutionCEImpl
    participant ObjectMapper

    User->>ActionExecutionSolutionCEImpl: Request action configuration deep copy
    ActionExecutionSolutionCEImpl->>ObjectMapper: Serialize ActionConfiguration to JSON
    ObjectMapper-->>ActionExecutionSolutionCEImpl: Return JSON string
    ActionExecutionSolutionCEImpl->>ObjectMapper: Deserialize JSON back to ActionConfiguration
    ObjectMapper-->>ActionExecutionSolutionCEImpl: Return new ActionConfiguration
    ActionExecutionSolutionCEImpl-->>User: Return deep copied ActionConfiguration

Loading

Assessment against linked issues

Objective	Addressed	Explanation
Replace Gson usage with Jackson (#35696)	✅

Poem

In the realm of code where functions play,
A deep copy blooms, keeping bugs at bay.
With Jackson's grace, we bid Gson adieu,
Clean and clear, our methods shine anew.
Simplicity reigns, as old paths we sever,
In the code's embrace, we strive for forever! 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

Failed server tests

• com.appsmith.server.solutions.ce.ActionExecutionSolutionCETest#executeActionNoStorageFound

[coderabbitai]

Actionable comments posted: 1

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between c899ba6 and 599506d.

Files selected for processing (1)

• app/server/appsmith-server/src/main/java/com/appsmith/server/solutions/ce/ActionExecutionSolutionCEImpl.java (3 hunks)

Additional comments not posted (1)

app/server/appsmith-server/src/main/java/com/appsmith/server/solutions/ce/ActionExecutionSolutionCEImpl.java (1)

820-820: Verify handling of deepCopyActionConfiguration return value.

Ensure that the return value of deepCopyActionConfiguration is handled properly, especially since it may return null. Consider adding null checks or handling potential exceptions if you refactor the method to throw exceptions.

[github-actions]

Failed server tests

• com.appsmith.server.git.CommonGitServiceCETest#updateGitMetadata_EmptyData_Success