Skip to content

chore: added logs for connection pool in mysql #35255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sneha122 merged 3 commits into from
Jul 30, 2024
Merged

chore: added logs for connection pool in mysql #35255

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
723e502
chore: added logs for connection pool in mysql
Jul 29, 2024
786e108
fix: code review comments addressed
Jul 29, 2024
2588f79
fix: debug changed to info
Jul 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 31 additions & 11 deletions app/server/appsmith-plugins/mysqlPlugin/src/main/java/com/external/plugins/MySqlPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
import com.external.utils.MySqlErrorUtils;
import com.external.utils.QueryUtils;
import io.r2dbc.pool.ConnectionPool;
import io.r2dbc.pool.PoolMetrics;
import io.r2dbc.spi.Connection;
import io.r2dbc.spi.R2dbcBadGrammarException;
import io.r2dbc.spi.R2dbcException;
Expand Down Expand Up @@ -63,18 +64,8 @@
import java.time.LocalDateTime;
import java.time.LocalTime;
import java.time.format.DateTimeFormatter;
import java.util.*;
import java.util.AbstractMap.SimpleEntry;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Comparator;
import java.util.HashMap;
import java.util.HashSet;
import java.util.Iterator;
import java.util.LinkedHashMap;
import java.util.List;
import java.util.Map;
import java.util.Set;
import java.util.TreeMap;
import java.util.concurrent.TimeoutException;
import java.util.stream.IntStream;

Expand Down Expand Up @@ -378,6 +369,21 @@ isConnectionValid && isSSHTunnelConnected(sshTunnelContext))
});
}

// Adding connection pool logs in order to debug memroy leak issue
// Refer: https://github.com/appsmithorg/appsmith/issues/34028
Optional<PoolMetrics> poolMetricsOptional = connectionPool.getMetrics();
if (poolMetricsOptional.isPresent()) {
PoolMetrics poolMetrics = poolMetricsOptional.get();
log.info(
"Execute query: connection Pool Metrics: Acquired {}, Pending: {}, Allocated: {}, idle: {}, Max allocations: {}, Max pending acquire: {}",
poolMetrics.acquiredSize(),
poolMetrics.pendingAcquireSize(),
poolMetrics.allocatedSize(),
poolMetrics.idleSize(),
poolMetrics.getMaxAllocatedSize(),
poolMetrics.getMaxPendingAcquireSize());
}

return resultMono
.map(res -> {
ActionExecutionResult result = new ActionExecutionResult();
Expand Down Expand Up @@ -723,6 +729,20 @@ public Mono<DatasourceStructure> getStructure(
.map(isConnectionValid ->
isConnectionValid && isSSHTunnelConnected(sshTunnelContext))
.flatMapMany(isValid -> {
// Adding connection pool logs in order to debug memroy leak issue
// Refer: https://github.com/appsmithorg/appsmith/issues/34028
Optional<PoolMetrics> poolMetricsOptional = connectionPool.getMetrics();
if (poolMetricsOptional.isPresent()) {
PoolMetrics poolMetrics = poolMetricsOptional.get();
log.info(
"Get structure: connection Pool Metrics: Acquired {}, Pending: {}, Allocated: {}, idle: {}, Max allocations: {}, Max pending acquire: {}",
poolMetrics.acquiredSize(),
poolMetrics.pendingAcquireSize(),
poolMetrics.allocatedSize(),
poolMetrics.idleSize(),
poolMetrics.getMaxAllocatedSize(),
poolMetrics.getMaxPendingAcquireSize());
}
if (isValid) {
return connection
.createStatement(COLUMNS_QUERY)
Expand Down