chore: added logs for connection pool in mysql#35255
Conversation
WalkthroughThe recent changes to the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant MySqlPlugin
participant ConnectionPool
User->>MySqlPlugin: Execute Query
MySqlPlugin->>ConnectionPool: Request Connection
ConnectionPool-->>MySqlPlugin: Provide Connection
MySqlPlugin->>ConnectionPool: Log Pool Metrics
MySqlPlugin->>User: Return Query Result
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
github-actions
bot
added
Integrations Product
|
/build-deploy-preview skip-tests=true |
|
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/10142214768. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- app/server/appsmith-plugins/mysqlPlugin/src/main/java/com/external/plugins/MySqlPlugin.java (4 hunks)
Additional comments not posted (2)
app/server/appsmith-plugins/mysqlPlugin/src/main/java/com/external/plugins/MySqlPlugin.java (2)
372-384: Great addition! Logging connection pool metrics is crucial for debugging.The added logging statements will help monitor the connection pool's status during query execution, which is essential for diagnosing memory leaks.
730-741: Well done! Logging connection pool metrics before retrieving the data source structure is a good practice.These logs will provide valuable insights into the connection pool's status, aiding in diagnosing memory leaks.
|
Deploy-Preview-URL: https://ce-35255.dp.appsmith.com |
Failed server tests
|
app/server/appsmith-plugins/mysqlPlugin/src/main/java/com/external/plugins/MySqlPlugin.java
Outdated
Show resolved
Hide resolved
app/server/appsmith-plugins/mysqlPlugin/src/main/java/com/external/plugins/MySqlPlugin.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- app/server/appsmith-plugins/mysqlPlugin/src/main/java/com/external/plugins/MySqlPlugin.java (4 hunks)
Files skipped from review as they are similar to previous changes (1)
- app/server/appsmith-plugins/mysqlPlugin/src/main/java/com/external/plugins/MySqlPlugin.java
Failed server tests
|
|
/build-deploy-preview skip-tests=true |
|
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/10148654041. |
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- app/server/appsmith-plugins/mysqlPlugin/src/main/java/com/external/plugins/MySqlPlugin.java (4 hunks)
Files skipped from review as they are similar to previous changes (1)
- app/server/appsmith-plugins/mysqlPlugin/src/main/java/com/external/plugins/MySqlPlugin.java
|
Deploy-Preview-URL: https://ce-35255.dp.appsmith.com |
Failed server tests
|
NilanshBansal
left a comment
NilanshBansal
left a comment
There was a problem hiding this comment.
Code LGTM.
@sneha122 is checking the failing server tests.
|
Both the failing tests are passing locally, triggering a re run |
|
Merging this PR even though log.info are not visible on mezmo, started a thread here. Closing this PR, will take up this issue separately. |
2 participants
Description
This PR adds logs around connection pool metrics in order to debug memory leak issue #34028
Following metrics are logged for Get strcuture and Excute query calls:
This information can help us understand if connections are not being released from the pool leading to memory leak.
Fixes #35158
or
Fixes
Issue URLWarning
If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.
Automation
/ok-to-test tags="@tag.Datasource"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10148654649
Commit: 2588f79
Cypress dashboard.
Tags:
@tag.DatasourceSpec:
Mon, 29 Jul 2024 17:38:32 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit
New Features
Bug Fixes