refactor: move apps link out of menu & refactor nav menu data#34313
refactor: move apps link out of menu & refactor nav menu data#34313alex-golovanov merged 1 commit intoreleasefrom
Conversation
WalkthroughThe recent updates focus on removing the Changes
Sequence Diagram(s)sequenceDiagram
participant User as User
participant Header as Header Component
participant Editor as Editor Component
participant NavigationHook as useNavigationMenuData
User->>Header: Clicks on Workspace name
Header->>Editor: Loads Workspace
Editor->>NavigationHook: Fetch Navigation Menu Data
NavigationHook-->>Editor: Returns Navigation Menu Data
Editor-->>Header: Displays updated menu
Header-->>User: Shows Workspace content
Assessment against linked issues
Poem
Warning Review ran into problemsProblems (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
github-actions
bot
added
IDE Navigation
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range and nitpick comments (1)
app/client/src/pages/Editor/EditorHeader.tsx (1)
Line range hint
1-1: Consider using React hooks for state management (useState) and effects (useEffect) consistently across the component to enhance readability and maintain the functional component conventions.
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (4)
- app/client/src/pages/Editor/EditorHeader.tsx (2 hunks)
- app/client/src/pages/Editor/EditorName/index.tsx (5 hunks)
- app/client/src/pages/Editor/EditorName/useNavigationMenuData.ts (5 hunks)
- app/client/src/pages/Editor/IDE/Header/index.tsx (9 hunks)
Files skipped from review due to trivial changes (1)
- app/client/src/pages/Editor/EditorName/index.tsx
Additional comments not posted (13)
app/client/src/pages/Editor/EditorName/useNavigationMenuData.ts (7)
1-2: Imports for React hooksuseCallbackanduseMemoare correctly added to manage memoization and callback issues as per the PR description.
29-29: The interfaceNavigationMenuDataPropshas been updated to remove theThemeProp, aligning with the removal of theme-related imports and usage as noted in the AI-generated summary.
34-34: The transformation ofGetNavigationMenuDatatouseNavigationMenuDatais a significant improvement. It adheres to React custom hooks naming conventions (useXYZ) and aligns with the functional programming style prevalent in React.
48-50: Introduction ofhasDeletePermissionusinghasDeleteApplicationPermissionfunction is a good practice. It encapsulates permission logic, which enhances code readability and maintainability.
Line range hint
66-87: TheexportAppAsJSONfunction has been correctly refactored to useuseCallbackfor better performance and fewer re-renders. The dependencies listed in the array are appropriate, ensuring that the callback is updated only when necessary.
Line range hint
89-103: ThedeleteApplicationfunction is properly usinguseCallback, ensuring that the function is not recreated unless its dependencies change. This is crucial for performance, especially in React components that could re-render often.
105-186: TheuseMemohook is used effectively to derivenavigationMenuData. This optimizes performance by memoizing the menu data only when its dependencies change. The dependencies array is comprehensive, covering all variables that determine the menu's output.app/client/src/pages/Editor/EditorHeader.tsx (2)
Line range hint
1-1: All necessary imports are included, and the file adheres to the React functional component structure.
Line range hint
1-1: ThehandleClickDeployfunction is refactored to useuseCallback, which is good practice for functions that are passed as props or triggered on events in React components.app/client/src/pages/Editor/IDE/Header/index.tsx (4)
15-15: The import forLinkfrom "design-system" is correctly added, likely used for navigation links within the IDE header.
Line range hint
169-204: ThehandlePublishfunction is refactored to useuseCallback, which is correctly implemented. The dependencies are correctly identified, ensuring that the function is only re-created when one of these dependencies changes.
206-215: ThehandleClickDeployfunction's refactoring to useuseCallbackis appropriate. It ensures that the function is not re-created unnecessarily, which can lead to performance improvements in React applications.
228-231: The use of theLinkcomponent to navigate back to the applications URL is a good UX enhancement, making it easier for users to navigate through the application.
|
/build-deploy-preview |
|
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/9575731265. |
|
Deploy-Preview-URL: https://ce-34313.dp.appsmith.com |
|
/build-deploy-preview |
|
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/9578220021. |
|
Deploy-Preview-URL: https://ce-34313.dp.appsmith.com |
## Description Reverted missed out code in #34367 ## Automation /ok-to-test tags="@tag.IDE" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/9608916182> > Commit: a252566 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9608916182&attempt=1" target="_blank">Cypress dashboard</a>. > Tags: `@tag.IDE` <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [x] No
2 participants
Description
Moved
Back to all appsfrom dropdown menu directly to header.Additionally renamed
NavigationMenuData.tstouseNavigationMenuData.tsand fixed dependency related memoization issues.Fixes #32982
Automation
/ok-to-test tags="@tag.IDE"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9567752111
Commit: 824b2fe
Cypress dashboard.
Tags:
@tag.IDECommunication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit
getNavigationMenuprop fromEditorHeaderfor streamlined navigation menu data retrieval.EditorNameto useuseNavigationMenuDatafor navigation menu items.useNavigationMenuDatato useuseCallbackanduseMemofor enhanced performance.IDE/Headerto useuseCallbackfor better efficiency.