Skip to content

fix: update dp builder #34203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pratapaprasanna merged 2 commits into from
Jun 13, 2024
Merged

fix: update dp builder #34203

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b30d27
Update deploy_preview.sh
pratapaprasanna Jun 12, 2024
db1c7ed
fix: update dp builder
pratapaprasanna Jun 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions scripts/deploy_preview.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ export DBNAME=ce"$PULL_REQUEST_NUMBER"
export DOMAINNAME=ce-"$PULL_REQUEST_NUMBER".dp.appsmith.com
export HELMCHART="appsmith"
export HELMCHART_URL="http://helm-ee.appsmith.com"
export HELMCHART_VERSION="3.0.7"
export HELMCHART_VERSION="3.1.1"


aws eks update-kubeconfig --region $region --name $cluster_name --profile eksci
Expand Down Expand Up @@ -97,10 +97,10 @@ helm upgrade -i $CHARTNAME appsmith-ee/$HELMCHART -n $NAMESPACE --create-namespa
--set persistence.efs.driver=efs.csi.aws.com --set persistence.storageClass=efs-dp-appsmith \
--set persistence.efs.volumeHandle=$DP_EFS_ID:/ce/ce$PULL_REQUEST_NUMBER \
--set resources.requests.cpu="1m" \
--set resources.requests.memory="1Mi" \
--set resources.requests.memory="2048Mi" \
--set applicationConfig.APPSMITH_SENTRY_DSN="https://abf15a075d1347969df44c746cca7eaa@o296332.ingest.sentry.io/1546547" \
--set applicationConfig.APPSMITH_SENTRY_ENVIRONMENT="$NAMESPACE" \
--set applicationConfig.APPSMITH_MONGODB_URI="mongodb+srv://$DB_USERNAME:$DB_PASSWORD@$DB_URL/$DBNAME?retryWrites=true&minPoolSize=1&maxPoolSize=10&maxIdleTimeMS=900000&authSource=admin" \
--set applicationConfig.APPSMITH_DB_URL="mongodb+srv://$DB_USERNAME:$DB_PASSWORD@$DB_URL/$DBNAME?retryWrites=true&minPoolSize=1&maxPoolSize=10&maxIdleTimeMS=900000&authSource=admin" \
Copy link
Contributor

@coderabbitai coderabbitai bot Jun 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tip

Codebase Verification

There are still references to APPSMITH_MONGODB_URI in the following files:

  • scripts/build_dp_from_branch.sh
  • deploy/docker/fs/opt/appsmith/run-with-env.sh
  • deploy/docker/fs/opt/appsmith/entrypoint.sh

Please update these references to use the new environment variable name APPSMITH_DB_URL.

Analysis chain

Change of environment variable from APPSMITH_MONGODB_URI to APPSMITH_DB_URL.

Verify that all references to the MongoDB URI in the application have been updated to use the new environment variable name.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify all references to the MongoDB URI have been updated.

# Test: Search for the old environment variable name. Expect: No occurrences.
rg --type sh $'APPSMITH_MONGODB_URI'

Length of output: 682

--set applicationConfig.APPSMITH_DISABLE_EMBEDDED_KEYCLOAK=\"1\" \
--set applicationConfig.APPSMITH_CUSTOMER_PORTAL_URL="https://release-customer.appsmith.com" \
--version $HELMCHART_VERSION