Conversation
WalkthroughThe Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Outside diff range and nitpick comments (1)
scripts/deploy_preview.sh (1)
Line range hint
30-32: Consider declaring and assigning these environment variables separately to avoid masking return values.- export AWS_ACCESS_KEY_ID=$(echo $sts_output | jq -r '.Credentials''.AccessKeyId');\ - export AWS_SECRET_ACCESS_KEY=$(echo $sts_output | jq -r '.Credentials''.SecretAccessKey');\ - export AWS_SESSION_TOKEN=$(echo $sts_output | jq -r '.Credentials''.SessionToken'); + AWS_ACCESS_KEY_ID=$(echo $sts_output | jq -r '.Credentials''.AccessKeyId') + AWS_SECRET_ACCESS_KEY=$(echo $sts_output | jq -r '.Credentials''.SecretAccessKey') + AWS_SESSION_TOKEN=$(echo $sts_output | jq -r '.Credentials''.SessionToken') + export AWS_ACCESS_KEY_ID AWS_SECRET_ACCESS_KEY AWS_SESSION_TOKEN
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- scripts/deploy_preview.sh (2 hunks)
Additional context used
Shellcheck
scripts/deploy_preview.sh
[warning] 30-30: Declare and assign separately to avoid masking return values. (SC2155)
[warning] 31-31: Declare and assign separately to avoid masking return values. (SC2155)
[warning] 32-32: Declare and assign separately to avoid masking return values. (SC2155)
Additional comments not posted (1)
scripts/deploy_preview.sh (1)
41-41: Update ofHELMCHART_VERSIONto "3.1.1" is noted.Ensure that this version of the Helm chart is compatible with the rest of your deployment specifications.
| --set applicationConfig.APPSMITH_SENTRY_DSN="https://abf15a075d1347969df44c746cca7eaa@o296332.ingest.sentry.io/1546547" \ | ||
| --set applicationConfig.APPSMITH_SENTRY_ENVIRONMENT="$NAMESPACE" \ | ||
| --set applicationConfig.APPSMITH_MONGODB_URI="mongodb+srv://$DB_USERNAME:$DB_PASSWORD@$DB_URL/$DBNAME?retryWrites=true&minPoolSize=1&maxPoolSize=10&maxIdleTimeMS=900000&authSource=admin" \ | ||
| --set applicationConfig.APPSMITH_DB_URL="mongodb+srv://$DB_USERNAME:$DB_PASSWORD@$DB_URL/$DBNAME?retryWrites=true&minPoolSize=1&maxPoolSize=10&maxIdleTimeMS=900000&authSource=admin" \ |
There was a problem hiding this comment.
Tip
Codebase Verification
There are still references to APPSMITH_MONGODB_URI in the following files:
scripts/build_dp_from_branch.shdeploy/docker/fs/opt/appsmith/run-with-env.shdeploy/docker/fs/opt/appsmith/entrypoint.sh
Please update these references to use the new environment variable name APPSMITH_DB_URL.
Analysis chain
Change of environment variable from APPSMITH_MONGODB_URI to APPSMITH_DB_URL.
Verify that all references to the MongoDB URI in the application have been updated to use the new environment variable name.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify all references to the MongoDB URI have been updated.
# Test: Search for the old environment variable name. Expect: No occurrences.
rg --type sh $'APPSMITH_MONGODB_URI'
Length of output: 682
1 participant
Summary by CodeRabbit